From: Manivannan Sadhasivam <mani@kernel.org>
To: Chunkai Deng <chunkai.deng@oss.qualcomm.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev-bot+sashiko@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, tao.zhang1@oss.qualcomm.com,
peter.chen@oss.qualcomm.com, jeff.johnson@oss.qualcomm.com,
konrad.dybcio@oss.qualcomm.com
Subject: Re: [PATCH net-next 3/3] net: qrtr: implement shutdown()
Date: Mon, 26 Oct 2026 19:23:21 +0530 [thread overview]
Message-ID: <at9XxF32WiKBEJQY@debian> (raw)
In-Reply-To: <9f76467c-5b21-40a2-95b8-e91cf1e1b47c@oss.qualcomm.com>
On Mon, Oct 26, 2026 at 06:23:18PM +0800, Chunkai Deng wrote:
> Yeah, this is a known limitation and the commit message calls it out.
>
> The sender sleeps on flow->resume_tx, which hangs off the node and is
> keyed by destination node/port, so the socket has no way to reach it.
It is fine to defer this fix as a follow-up patch, but I'm not buying the 'no
way to reach flow control' from shutdown() callback claim. Why can't you just
store the 'qtrt_tx_flow' pointer in qrtr_sock and dereference it in shutdown()
callback to wake up qrtr_tx_wait()?
Storing the pointer here is fine since all callers of qrtr_tx_wait() hold
lock_sock().
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2026-10-26 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 8:58 [PATCH net-next 0/3] net: qrtr: implement socket shutdown() Chunkai Deng
2026-10-16 8:58 ` [PATCH net-next 1/3] net: qrtr: do not take the sock lock on blocking recv Chunkai Deng
2026-10-20 9:35 ` netdev-bot+sashiko
2026-10-26 12:53 ` Manivannan Sadhasivam
2026-10-16 8:58 ` [PATCH net-next 2/3] net: qrtr: propagate sock_alloc_send_skb() errors from sendmsg() Chunkai Deng
2026-10-20 9:35 ` netdev-bot+sashiko
2026-10-26 12:54 ` Manivannan Sadhasivam
2026-10-16 8:58 ` [PATCH net-next 3/3] net: qrtr: implement shutdown() Chunkai Deng
2026-10-20 9:35 ` netdev-bot+sashiko
2026-10-21 20:35 ` Jakub Kicinski
2026-10-26 10:23 ` Chunkai Deng
2026-10-26 13:53 ` Manivannan Sadhasivam [this message]
2026-10-26 13:36 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at9XxF32WiKBEJQY@debian \
--to=mani@kernel.org \
--cc=chunkai.deng@oss.qualcomm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.chen@oss.qualcomm.com \
--cc=tao.zhang1@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®