[PATCH] staging: rtl8723bs: remove comparisons to true/false in rtw_mlme_ext.c

[PATCH] staging: rtl8723bs: remove comparisons to true/false in rtw_mlme_ext.c

[Mohammed Sohail]

Checkpatch reports "Using comparison to true/false is error prone"
in rtw_mlme_ext.c. Replace "x == true" with "x" and "x == false"
with "!x".

bwmode_updated and bxmitok are u8, but they are only ever assigned
true or false, so this does not change behavior.

Signed-off-by: Mohammed Sohail <mohd.sohail.biz@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 80194796a9f7..511eccf5b5a3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -3457,7 +3457,7 @@ static void issue_action_BSSCoexistPacket(struct adapter *padapter)
 	if ((pmlmepriv->num_FortyMHzIntolerant == 0) || (pmlmepriv->num_sta_no_ht == 0))
 		return;
 
-	if (true == pmlmeinfo->bwmode_updated)
+	if (pmlmeinfo->bwmode_updated)
 		return;
 
 	category = RTW_WLAN_CATEGORY_PUBLIC;
@@ -3625,7 +3625,7 @@ unsigned int send_beacon(struct adapter *padapter)
 			 !padapter->bSurpriseRemoved &&
 			 !padapter->driver_stopped);
 
-	} while (false == bxmitok && issue < 100 && !padapter->bSurpriseRemoved &&
+	} while (!bxmitok && issue < 100 && !padapter->bSurpriseRemoved &&
 		 !padapter->driver_stopped);
 
 	if (padapter->bSurpriseRemoved || padapter->driver_stopped)
@@ -3868,7 +3868,7 @@ u8 collect_bss_info(struct adapter *padapter, union recv_frame *precv_frame, str
 	bssid->configuration.atim_window = 0;
 
 	/* 20/40 BSS Coexistence check */
-	if ((pregistrypriv->wifi_spec == 1) && (false == pmlmeinfo->bwmode_updated)) {
+	if ((pregistrypriv->wifi_spec == 1) && (!pmlmeinfo->bwmode_updated)) {
 		struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 
 		p = rtw_get_ie(bssid->ies + ie_offset, WLAN_EID_HT_CAPABILITY, &len, bssid->ie_length - ie_offset);
-- 
2.55.0

Re: [PATCH] staging: rtl8723bs: remove comparisons to true/false in rtw_mlme_ext.c

[Dan Carpenter]

On Wed, Oct 07, 2026 at 09:51:14PM +0530, Mohammed Sohail wrote:
> @@ -3868,7 +3868,7 @@ u8 collect_bss_info(struct adapter *padapter, union recv_frame *precv_frame, str
>  	bssid->configuration.atim_window = 0;
>  
>  	/* 20/40 BSS Coexistence check */
> -	if ((pregistrypriv->wifi_spec == 1) && (false == pmlmeinfo->bwmode_updated)) {
> +	if ((pregistrypriv->wifi_spec == 1) && (!pmlmeinfo->bwmode_updated)) {

Get rid of the extra parentheses around (!pmlmeinfo->bwmode_updated).

regards,
dan carpenter