mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	linux-iio@vger.kernel.org, "Eddie James" <eajames@linux.ibm.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Rupesh Majhi" <zoone.rupert@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] iio: pressure: dps310: add Zilltek ZTS8032
Date: Thu, 15 Oct 2026 16:32:37 +0300	[thread overview]
Message-ID: <atDV9RvEocWjlicZ@ashevche-desk.local> (raw)
In-Reply-To: <20261015104945.2687162-1-paulius.zaleckas@gmail.com>

On Thu, Oct 15, 2026 at 01:49:40PM +0300, Paulius Zaleckas wrote:
> The Zilltek ZTS8032 is a register compatible DPS310 with two more
> pressure calibration coefficients (c31, c40) and a different TMP_CFG
> layout.
> 
> 1-2: Vendor prefix and the zilltek,zts8032 compatible.
> 3: Per-chip data in the I2C and ACPI match data, no functional change.
> 4: OF match table.
> 5: ZTS8032 chip data: the coefficient count, the TMP_CFG startup value,
>    and a Horner step each for c40 and c31.
> 
> Based on iio/testing, on top of a22dc7ebb21a ("iio: pressure: dps310:
> fix overflow in pressure compensation"). That fix replaces v2's patch 1,
> and patch 5 extends its Horner evaluation.
> 
> There is no public ZTS8032 datasheet.
> 
> Testing: ZTS8032 on an arm64 (MT7987) board, the series and a22dc7ebb21a
> backported to 6.12. in_pressure_input matches the datasheet formula
> evaluated from the raw and coefficient registers to within 1 Pa at every
> oversampling rate from 1 to 128, and TMP_CFG reads 0x00 after probe.
> Every patch builds without warnings with W=1 on x86_64 and i386,
> dt_binding_check passes. I have no DPS310, so patches 3-4 are untested
> on one.
> 
> An LLM coding assistant (Claude Code) was used for this series: it
> ported the ZTS8032 support from the vendor driver, wrote the code and
> changelogs and the hardware test scripts, under my direction. I
> reviewed and tested the result.

I have a single nit-pick (but two patches might be updated), otherwise
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
for the whole series.

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-10-15 13:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 10:49 Paulius Zaleckas
2026-10-15 10:49 ` [PATCH v3 1/5] dt-bindings: vendor-prefixes: Add ZillTek Technology Paulius Zaleckas
2026-10-15 10:49 ` [PATCH v3 2/5] dt-bindings: iio: pressure: infineon,dps310: Add Zilltek ZTS8032 Paulius Zaleckas
2026-10-15 10:49 ` [PATCH v3 3/5] iio: pressure: dps310: add per-chip data Paulius Zaleckas
2026-10-15 13:12   ` Joshua Crofts
2026-10-15 10:49 ` [PATCH v3 4/5] iio: pressure: dps310: add an OF match table Paulius Zaleckas
2026-10-15 13:14   ` Joshua Crofts
2026-10-15 10:49 ` [PATCH v3 5/5] iio: pressure: dps310: add Zilltek ZTS8032 support Paulius Zaleckas
2026-10-15 13:31   ` Andy Shevchenko
2026-10-15 13:32 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atDV9RvEocWjlicZ@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=eajames@linux.ibm.com \
    --cc=jic23@kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=paulius.zaleckas@gmail.com \
    --cc=robh@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=zoone.rupert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®