From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
linux-iio@vger.kernel.org, "Eddie James" <eajames@linux.ibm.com>,
"Joel Stanley" <joel@jms.id.au>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rupesh Majhi" <zoone.rupert@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] iio: pressure: dps310: add Zilltek ZTS8032 support
Date: Thu, 15 Oct 2026 16:31:37 +0300 [thread overview]
Message-ID: <atDVud25tkoN58rF@ashevche-desk.local> (raw)
In-Reply-To: <20261015104945.2687162-6-paulius.zaleckas@gmail.com>
On Thu, Oct 15, 2026 at 01:49:45PM +0300, Paulius Zaleckas wrote:
> The Zilltek ZTS8032 has the DPS310 register map, scale factors and
> compensation, with these differences:
>
> - two more pressure coefficients, c31 and c40 at 0x22-0x25, adding
> c40 * Praw_sc^4 + c31 * Traw_sc * Praw_sc^3 to the polynomial
> - TMP_EXT is MEAS_CFG bit 3, and the temperature coefficients are for
> the internal sensor (COEF_SRCE reads 0x06). TMP_CFG bit 7 is the top
> bit of a 4-bit TMP_RATE, so the DPS310 TMP_EXT write would select a
> 25/16 Hz background rate instead of the external sensor.
> - product ID 0x11 instead of 0x10, the driver does not check it
>
> Add its chip data, reading 22 coefficient bytes and leaving TMP_CFG at
> 0, a Horner step for each of c40 and c31, and the I2C and OF IDs.
>
> Tested on a ZTS8032 over I2C: in_pressure_input is within 1 Pa of the
> datasheet formula evaluated from the raw and coefficient registers at
> every oversampling rate from 1 to 128, and TMP_CFG reads 0x00 after
> probe.
...
> #define DPS310_COEF_LEN 18
> -#define DPS310_MAX_COEF_LEN 18
> +#define ZTS8032_COEF_LEN 22
> +#define DPS310_MAX_COEF_LEN 22
I probably was unclear. What I meant is the agnostic name for that.
After the first patch:
#define DPS310_COEF_LEN 18
#define MAX_COEF_LEN 18
After this one
#define DPS310_COEF_LEN 18
#define ZTS8032_COEF_LEN 22
#define MAX_COEF_LEN 22
...
Everything else looks good to me.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-15 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 10:49 [PATCH v3 0/5] iio: pressure: dps310: add Zilltek ZTS8032 Paulius Zaleckas
2026-10-15 10:49 ` [PATCH v3 1/5] dt-bindings: vendor-prefixes: Add ZillTek Technology Paulius Zaleckas
2026-10-15 10:49 ` [PATCH v3 2/5] dt-bindings: iio: pressure: infineon,dps310: Add Zilltek ZTS8032 Paulius Zaleckas
2026-10-15 10:49 ` [PATCH v3 3/5] iio: pressure: dps310: add per-chip data Paulius Zaleckas
2026-10-15 13:12 ` Joshua Crofts
2026-10-15 10:49 ` [PATCH v3 4/5] iio: pressure: dps310: add an OF match table Paulius Zaleckas
2026-10-15 13:14 ` Joshua Crofts
2026-10-15 10:49 ` [PATCH v3 5/5] iio: pressure: dps310: add Zilltek ZTS8032 support Paulius Zaleckas
2026-10-15 13:31 ` Andy Shevchenko [this message]
2026-10-15 13:32 ` [PATCH v3 0/5] iio: pressure: dps310: add Zilltek ZTS8032 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atDVud25tkoN58rF@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=paulius.zaleckas@gmail.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=zoone.rupert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®