From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: John Singleton <johnsingleton@google.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@kernel.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: media: atomisp: Fix parameter indentation and block comments
Date: Thu, 15 Oct 2026 22:07:26 +0300 [thread overview]
Message-ID: <atEkbryDswpLe-iT@ashevche-desk.local> (raw)
In-Reply-To: <CAJEVk_GXoHRr-dEZZu2xz8Jk-vVyowJfmqbuGk3fcdQ05TWjag@mail.gmail.com>
On Wed, Oct 14, 2026 at 09:20:59AM -0500, John Singleton wrote:
> Thank you, Andy. Just to confirm from my examination, I think the key
> issues are:
> 1) There should be separate patches for the comment-cleanup and the
> function-header cleanup and
> 2) The preference is to do this for all files in a directory, rather than a
> subset.
>
> Is that a fair summary of the concerns?
Do not top-post!
Not only, the similar patches were sent many times, you need to collect
preliminary work and come up with the best solution out of all.
> On Mon, Oct 12, 2026 at 2:05 PM Andy Shevchenko <andy.shevchenko@gmail.com>
> wrote:
>
> > On Mon, Oct 12, 2026 at 7:13 PM John Singleton <johnsingleton@google.com>
> > wrote:
> > >
> > > Replace leading spaces with tabs in function parameter lists and
> > > format multi-line comments according to kernel coding style.
> >
> > Please, read the mail archive to understand why this patch is no-go.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-15 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 16:13 [PATCH 1/3] staging: media: atomisp: Make pmic_name array const John Singleton
2026-10-12 16:13 ` [PATCH 2/3] staging: media: atomisp: Remove extraneous dev_dbg John Singleton
2026-10-12 19:05 ` Andy Shevchenko
2026-10-12 16:13 ` [PATCH 3/3] staging: media: atomisp: Fix parameter indentation and block comments John Singleton
2026-10-12 19:04 ` Andy Shevchenko
2026-10-14 14:50 ` John Singleton
[not found] ` <CAJEVk_GXoHRr-dEZZu2xz8Jk-vVyowJfmqbuGk3fcdQ05TWjag@mail.gmail.com>
2026-10-15 19:07 ` Andy Shevchenko [this message]
2026-10-12 19:07 ` [PATCH 1/3] staging: media: atomisp: Make pmic_name array const Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atEkbryDswpLe-iT@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=johnsingleton@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®