From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: HyeongJun An <sammiee5311@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
patches@opensource.cirrus.com, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs42l56: Remove the ADC Mute Switch control
Date: Mon, 19 Oct 2026 13:53:57 +0100 [thread overview]
Message-ID: <atYS5WUcE5NAIA/4@opensource.cirrus.com> (raw)
In-Reply-To: <20261019124022.3410793-1-sammiee5311@gmail.com>
On Mon, Oct 19, 2026 at 09:40:22PM +0900, HyeongJun An wrote:
> The ADC Mute Switch control writes bits 2 and 3 of the Misc ADC Control
> register. These are the ADCA Invert and ADCB Invert bits, which have
> their own controls. The ADC mute bits are bits 0 and 1, and the DAI mute
> callback already sets them.
>
> So the control has never muted the ADCs, and nobody can be relying on
> it. Remove it rather than point it at the mute bits, so the ADCs are
> muted in one place only.
>
> Fixes: 272b5edd3b8f ("ASoC: Add support for CS42L56 CODEC")
> Suggested-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Link: https://lore.kernel.org/all/atXh3Br+fuH83S0q@opensource.cirrus.com/
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
prev parent reply other threads:[~2026-10-19 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 12:40 HyeongJun An
2026-10-19 12:53 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atYS5WUcE5NAIA/4@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=sammiee5311@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®