[PATCH] ASoC: cs42l56: Remove the ADC Mute Switch control

[PATCH] ASoC: cs42l56: Remove the ADC Mute Switch control

[HyeongJun An]

The ADC Mute Switch control writes bits 2 and 3 of the Misc ADC Control
register. These are the ADCA Invert and ADCB Invert bits, which have
their own controls. The ADC mute bits are bits 0 and 1, and the DAI mute
callback already sets them.

So the control has never muted the ADCs, and nobody can be relying on
it. Remove it rather than point it at the mute bits, so the ADCs are
muted in one place only.

Fixes: 272b5edd3b8f ("ASoC: Add support for CS42L56 CODEC")
Suggested-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/all/atXh3Br+fuH83S0q@opensource.cirrus.com/
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
---
 sound/soc/codecs/cs42l56.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c
index 54d23857b0ad..ecce51985a11 100644
--- a/sound/soc/codecs/cs42l56.c
+++ b/sound/soc/codecs/cs42l56.c
@@ -419,7 +419,6 @@ static const struct snd_kcontrol_new cs42l56_snd_controls[] = {
 			      CS42L56_PGAB_MUX_VOLUME, 0, 0x34, 0x24, pga_tlv),
 	SOC_DOUBLE_R_TLV("ADC Volume", CS42L56_ADCA_ATTENUATOR,
 			      CS42L56_ADCB_ATTENUATOR, 0, 0x00, 1, adc_tlv),
-	SOC_DOUBLE("ADC Mute Switch", CS42L56_MISC_ADC_CTL, 2, 3, 1, 1),
 	SOC_DOUBLE("ADC Boost Switch", CS42L56_GAIN_BIAS_CTL, 3, 2, 1, 1),
 
 	SOC_DOUBLE_R_SX_TLV("Headphone Volume", CS42L56_HPA_VOLUME,
-- 
2.43.0

Re: [PATCH] ASoC: cs42l56: Remove the ADC Mute Switch control

[Charles Keepax]

On Mon, Oct 19, 2026 at 09:40:22PM +0900, HyeongJun An wrote:
> The ADC Mute Switch control writes bits 2 and 3 of the Misc ADC Control
> register. These are the ADCA Invert and ADCB Invert bits, which have
> their own controls. The ADC mute bits are bits 0 and 1, and the DAI mute
> callback already sets them.
> 
> So the control has never muted the ADCs, and nobody can be relying on
> it. Remove it rather than point it at the mute bits, so the ADCs are
> muted in one place only.
> 
> Fixes: 272b5edd3b8f ("ASoC: Add support for CS42L56 CODEC")
> Suggested-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Link: https://lore.kernel.org/all/atXh3Br+fuH83S0q@opensource.cirrus.com/
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles