From: Stefano Radaelli <stefano.radaelli21@gmail.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Frank Li <Frank.Li@nxp.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
pierluigi.p@variscite.com,
Stefano Radaelli <stefano.r@variscite.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v1 0/4] arm64: dts: Mark Variscite i.MX9 I2C recovery GPIOs as open drain
Date: Tue, 20 Oct 2026 15:59:53 +0200 [thread overview]
Message-ID: <atdz2TonrGyL9Ox4@Lord-Beerus.station> (raw)
In-Reply-To: <20261020064106.197223-1-peng.fan@oss.nxp.com>
On Tue, Oct 20, 2026 at 02:41:04PM +0800, Peng Fan (OSS) wrote:
> On Sun, 18 Oct 2026 14:32:23 +0200 Stefano Radaelli <stefano.radaelli21@gmail.com> wrote:
>
> > The I2C recovery GPIOs on VAR-SOM-MX91 and VAR-SOM-MX93, including their
> > Symphony carrier boards, are missing the open-drain flag.
> >
> > This series adds GPIO_OPEN_DRAIN to the SCL and SDA GPIO specifiers to
> > match the I2C bus requirements and avoid the warning emitted when the
> > I2C core enforces open-drain operation on SCL.
> >
> > Stefano Radaelli (4):
> > arm64: dts: imx91-var-som: Mark I2C recovery GPIOs as open drain
> > arm64: dts: imx91-var-som-symphony: Mark I2C recovery GPIOs as open
> > drain
> > arm64: dts: imx93-var-som: Mark I2C recovery GPIOs as open drain
> > arm64: dts: imx93-var-som-symphony: Mark I2C recovery GPIOs as open
> > drain
> >
> > arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts | 4 ++--
> > arch/arm64/boot/dts/freescale/imx91-var-som.dtsi | 4 ++--
> > arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts | 8 ++++----
> > arch/arm64/boot/dts/freescale/imx93-var-som.dtsi | 4 ++--
> > 4 files changed, 10 insertions(+), 10 deletions(-)
> >
>
> LGTM:
>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
>
> BTW: Do you need fixes tag?
Hi Peng,
Thanks for the review!
I treated this as a DT cleanup since the core already enforces
open-drain operation on SCL, so I think it is fine to keep the series
without Fixes tags.
Thanks,
Best Regards,
Stefano
prev parent reply other threads:[~2026-10-20 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 12:32 Stefano Radaelli
2026-10-18 12:32 ` [PATCH v1 1/4] arm64: dts: imx91-var-som: Mark " Stefano Radaelli
2026-10-18 12:32 ` [PATCH v1 2/4] arm64: dts: imx91-var-som-symphony: " Stefano Radaelli
2026-10-18 12:32 ` [PATCH v1 3/4] arm64: dts: imx93-var-som: " Stefano Radaelli
2026-10-18 12:32 ` [PATCH v1 4/4] arm64: dts: imx93-var-som-symphony: " Stefano Radaelli
2026-10-20 6:41 ` [PATCH v1 0/4] arm64: dts: Mark Variscite i.MX9 " Peng Fan (OSS)
2026-10-20 13:59 ` Stefano Radaelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atdz2TonrGyL9Ox4@Lord-Beerus.station \
--to=stefano.radaelli21@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=pierluigi.p@variscite.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=stefano.r@variscite.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®