From: Jarkko Sakkinen <jarkko@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
stable@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] KEYS: Reject descriptions larger than KEY_MAX_DESC_SIZE
Date: Wed, 21 Oct 2026 00:18:09 +0300 [thread overview]
Message-ID: <atfakaH2Gwm2FtXF@kernel.org> (raw)
In-Reply-To: <atfaI1d3heLgX5jE@kernel.org>
On Wed, Oct 21, 2026 at 12:16:23AM +0300, Jarkko Sakkinen wrote:
> On Tue, Oct 20, 2026 at 08:43:20PM +0300, Jarkko Sakkinen wrote:
>
> There is only case in key_alloc() where index_key.desc_len is not set:
>
> desclen = strlen(desc);
> if (desclen >= KEY_MAX_DESC_SIZE)
> goto error;
>
>
> Other sites match to:
>
> static int keyring_index_key_set_desc(void *desc, int desclen)
static inline int keyring_index_key_set_desc(struct keyring_index_key *index_key, void *desc, int desclen)
> {
> desclen = strlen(index_key.description);
> if (desclen >= KEY_MAX_DESC_SIZE) {
> return -EINVAL;
> }
> index_key->desc_len = desclen;
return 0;
> }
Br, Jarkko
next prev parent reply other threads:[~2026-10-20 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 17:43 [PATCH v4 0/3] KEYS: rhashtable bug fixes Jarkko Sakkinen
2026-10-20 17:43 ` [PATCH v4 1/3] KEYS: Expand key->{datalen,quotalen} to unsigned int Jarkko Sakkinen
2026-10-20 20:49 ` Jarkko Sakkinen
2026-10-20 20:59 ` Jarkko Sakkinen
2026-10-20 21:43 ` Eric Biggers
2026-10-20 22:01 ` Jarkko Sakkinen
2026-10-20 17:43 ` [PATCH v4 2/3] KEYS: Reject descriptions larger than KEY_MAX_DESC_SIZE Jarkko Sakkinen
2026-10-20 21:16 ` Jarkko Sakkinen
2026-10-20 21:18 ` Jarkko Sakkinen [this message]
2026-10-20 17:43 ` [PATCH v4 3/3] KEYS: Verify the key identity in __key_unlink_begin Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atfakaH2Gwm2FtXF@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®