mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay
@ 2026-10-20  8:42 Jean-Baptiste Maneyrol via B4 Relay
  2026-10-20  8:53 ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Jean-Baptiste Maneyrol via B4 Relay @ 2026-10-20  8:42 UTC (permalink / raw)
  To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
  Cc: linux-iio, linux-kernel, Jean-Baptiste Maneyrol

From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>

Following datasheet gyroscope specifications, the maximum start time
for gyroscope is 45ms. Stop time is required for letting gyroscope
mechanical structure settle down before enabling it back. 50ms is a
sufficient value for that.

Update values to these numbers.

Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
---
 drivers/iio/imu/inv_icm42600/inv_icm42600.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600.h b/drivers/iio/imu/inv_icm42600/inv_icm42600.h
index 3737e79dbcc1..c4a928fd3b8a 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600.h
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600.h
@@ -439,8 +439,8 @@ struct inv_icm42600_sensor_state {
 #define INV_ICM42600_POWER_UP_TIME_MS		100
 #define INV_ICM42600_RESET_TIME_MS		1
 #define INV_ICM42600_ACCEL_STARTUP_TIME_MS	20
-#define INV_ICM42600_GYRO_STARTUP_TIME_MS	60
-#define INV_ICM42600_GYRO_STOP_TIME_MS		150
+#define INV_ICM42600_GYRO_STARTUP_TIME_MS	45
+#define INV_ICM42600_GYRO_STOP_TIME_MS		50
 #define INV_ICM42600_TEMP_STARTUP_TIME_MS	14
 #define INV_ICM42600_SUSPEND_DELAY_MS		2000
 

---
base-commit: 43ffda3c7f8456bbe641ae8249a077a361b97880
change-id: 20261019-iio-imu-inv-icm42600-update-gyro-start-stop-delay-68dafe160210

Best regards,
--  
Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay
  2026-10-20  8:42 [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay Jean-Baptiste Maneyrol via B4 Relay
@ 2026-10-20  8:53 ` Andy Shevchenko
  2026-10-20 12:40   ` Jean-Baptiste Maneyrol
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-10-20  8:53 UTC (permalink / raw)
  To: jean-baptiste.maneyrol
  Cc: Jonathan Cameron, David Lechner, Nuno Sá,
	Andy Shevchenko, linux-iio, linux-kernel

On Tue, Oct 20, 2026 at 10:42:30AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:

> Following datasheet gyroscope specifications, the maximum start time

What datasheet? What specifications? Please, be more precise to refer the
Datasheet name, version, chapter, section, et cetera.

> for gyroscope is 45ms. Stop time is required for letting gyroscope
> mechanical structure settle down before enabling it back. 50ms is a
> sufficient value for that.
> 
> Update values to these numbers.

Do we need a Fixes tag?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay
  2026-10-20  8:53 ` Andy Shevchenko
@ 2026-10-20 12:40   ` Jean-Baptiste Maneyrol
  2026-10-20 12:55     ` Jean-Baptiste Maneyrol
  0 siblings, 1 reply; 5+ messages in thread
From: Jean-Baptiste Maneyrol @ 2026-10-20 12:40 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Jonathan Cameron, David Lechner, Nuno Sá,
	Andy Shevchenko, linux-iio, linux-kernel

>________________________________________
>From: Andy Shevchenko <andriy.shevchenko@intel.com>
>Sent: Tuesday, October 20, 2026 10:53
>To: Jean-Baptiste Maneyrol
>Cc: Jonathan Cameron; David Lechner; Nuno Sá; Andy Shevchenko; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay
>
>On Tue, Oct 20, 2026 at 10: 42: 30AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote: > Following datasheet gyroscope specifications, the maximum start time What datasheet? What specifications? Please, be more precise to refer the Datasheet
>ZjQcmQRYFpfptBannerStart
>This Message Is From an External Sender
>This message came from outside your organization.
>
>ZjQcmQRYFpfptBannerEnd
>
>On Tue, Oct 20, 2026 at 10:42:30AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
>
>> Following datasheet gyroscope specifications, the maximum start time
>
>What datasheet? What specifications? Please, be more precise to refer the
>Datasheet name, version, chapter, section, et cetera.

Hello Andy,

I will add the reference.

>
>> for gyroscope is 45ms. Stop time is required for letting gyroscope
>> mechanical structure settle down before enabling it back. 50ms is a
>> sufficient value for that.
>>
>> Update values to these numbers.
>
>Do we need a Fixes tag?

I don't think so, since it is not a bug fix but an enhancement. It was
working correctly before, even if it was waiting too much for nothing.

>
>--
>With Best Regards,
>Andy Shevchenko
>

Thanks,
JB

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay
  2026-10-20 12:40   ` Jean-Baptiste Maneyrol
@ 2026-10-20 12:55     ` Jean-Baptiste Maneyrol
  2026-10-21  6:47       ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Jean-Baptiste Maneyrol @ 2026-10-20 12:55 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Jonathan Cameron, David Lechner, Nuno Sá,
	Andy Shevchenko, linux-iio, linux-kernel

>
>________________________________________
>From: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>
>Sent: Tuesday, October 20, 2026 14:40
>To: Andy Shevchenko
>Cc: Jonathan Cameron; David Lechner; Nuno Sá; Andy Shevchenko; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay
>
>>________________________________________ >From: Andy Shevchenko <andriy. shevchenko@ intel. com> >Sent: Tuesday, October 20, 2026 10: 53 >To: Jean-Baptiste Maneyrol >Cc: Jonathan Cameron; David Lechner; Nuno Sá; Andy Shevchenko;
>ZjQcmQRYFpfptBannerStart
>This Message Is From an External Sender
>This message came from outside your organization.
>
>ZjQcmQRYFpfptBannerEnd
>
>>________________________________________
>>From: Andy Shevchenko <andriy.shevchenko@intel.com>
>>Sent: Tuesday, October 20, 2026 10:53
>>To: Jean-Baptiste Maneyrol
>>Cc: Jonathan Cameron; David Lechner; Nuno Sá; Andy Shevchenko; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org
>>Subject: Re: [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay
>>
>>On Tue, Oct 20, 2026 at 10: 42: 30AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote: > Following datasheet gyroscope specifications, the maximum start time What datasheet? What specifications? Please, be more precise to refer the Datasheet
>>ZjQcmQRYFpfptBannerStart
>>This Message Is From an External Sender
>>This message came from outside your organization.
>>
>>ZjQcmQRYFpfptBannerEnd
>>
>>On Tue, Oct 20, 2026 at 10:42:30AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
>>
>>> Following datasheet gyroscope specifications, the maximum start time
>>
>>What datasheet? What specifications? Please, be more precise to refer the
>>Datasheet name, version, chapter, section, et cetera.
>
>Hello Andy,
>
>I will add the reference.

Hello again,

in fact, this number is not available in the public datasheet. Only the mean
value is accessible.

Should I just modify the commit message to delete any reference to the datasheet?

>
>>
>>> for gyroscope is 45ms. Stop time is required for letting gyroscope
>>> mechanical structure settle down before enabling it back. 50ms is a
>>> sufficient value for that.
>>>
>>> Update values to these numbers.
>>
>>Do we need a Fixes tag?
>
>I don't think so, since it is not a bug fix but an enhancement. It was
>working correctly before, even if it was waiting too much for nothing.
>
>>
>>--
>>With Best Regards,
>>Andy Shevchenko
>>
>
>Thanks,
>JB
>

Thanks,
JB

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay
  2026-10-20 12:55     ` Jean-Baptiste Maneyrol
@ 2026-10-21  6:47       ` Andy Shevchenko
  0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2026-10-21  6:47 UTC (permalink / raw)
  To: Jean-Baptiste Maneyrol
  Cc: Jonathan Cameron, David Lechner, Nuno Sá,
	Andy Shevchenko, linux-iio, linux-kernel

On Tue, Oct 20, 2026 at 12:55:53PM +0000, Jean-Baptiste Maneyrol wrote:
> >From: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>
> >Sent: Tuesday, October 20, 2026 14:40
> >>From: Andy Shevchenko <andriy.shevchenko@intel.com>
> >>Sent: Tuesday, October 20, 2026 10:53
> >>On Tue, Oct 20, 2026 at 10:42:30AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
> >>
> >>> Following datasheet gyroscope specifications, the maximum start time
> >>
> >>What datasheet? What specifications? Please, be more precise to refer the
> >>Datasheet name, version, chapter, section, et cetera.

> >I will add the reference.
> 
> in fact, this number is not available in the public datasheet. Only the mean
> value is accessible.
> 
> Should I just modify the commit message to delete any reference to the datasheet?

I would rather see the full information like you put above, like

  "Unfortunately the public datasheet "$REFERENCE_TO_IT" does not specify
   these numbers".

> >>> for gyroscope is 45ms. Stop time is required for letting gyroscope
> >>> mechanical structure settle down before enabling it back. 50ms is a
> >>> sufficient value for that.
> >>>
> >>> Update values to these numbers.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-10-21  6:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-20  8:42 [PATCH] iio: imu: inv_icm42600: update gyro start and stop delay Jean-Baptiste Maneyrol via B4 Relay
2026-10-20  8:53 ` Andy Shevchenko
2026-10-20 12:40   ` Jean-Baptiste Maneyrol
2026-10-20 12:55     ` Jean-Baptiste Maneyrol
2026-10-21  6:47       ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®