mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kiryl Shutsemau <kas@kernel.org>
To: Zenghui Yu <zenghui.yu@linux.dev>
Cc: Muhammad Usama Anjum <usama.anjum@arm.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	"David Hildenbrand (Arm)" <david@kernel.org>,
	 "Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	 Baolin Wang <baolin.wang@linux.alibaba.com>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	 linux-kernel@vger.kernel.org, Usama Arif <usama.arif@linux.dev>,
	 "Nico Pache (Red Hat)" <nico.pache@linux.dev>,
	Zi Yan <ziy@nvidia.com>, Barry Song <baohua@kernel.org>,
	 Dev Jain <dev.jain@arm.com>, Hugh Dickins <hughd@google.com>,
	 Lance Yang <lance.yang@linux.dev>,
	"Liam R. Howlett" <liam@infradead.org>,
	 Michal Hocko <mhocko@suse.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	 Shuah Khan <shuah@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	 "Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	 Jason Gunthorpe <jgg@ziepe.ca>,
	Leon Romanovsky <leon@kernel.org>,
	kernel-team@meta.com
Subject: Re: [PATCH v6 16/19] selftests/mm: add khugepaged race harness
Date: Wed, 21 Oct 2026 11:34:15 +0100	[thread overview]
Message-ID: <atiU94VjdEsWzdBr@thinkstation> (raw)
In-Reply-To: <248431ea-4bbf-4a48-a80e-72287ffbae22@linux.dev>

On Thu, Oct 08, 2026 at 10:23:22PM +0800, Zenghui Yu wrote:
> On 10/8/26 4:18 PM, Muhammad Usama Anjum wrote:
> 
> > On 08/10/2026 8:30 am, Zenghui Yu wrote:
> > > On 9/19/26 8:24 AM, Kiryl Shutsemau wrote:
> > >
> > > > +		} else {	/* madvise */
> > > > +			while (now_ms() < end_ms && !corrupted) {
> > > > +				for (i = 0; i < nr_shared_areas; i++) {
> > > > +					madvise(region + i * hpage_pmd_size,
> > > > +						hpage_pmd_size, MADV_COLLAPSE);
> > >
> > > I got the following error when compiling it:
> > >
> > > khugepaged_race.c: In function ‘main’:
> > > khugepaged_race.c:506:23: error: ‘MADV_COLLAPSE’ undeclared (first use in this function); did you mean ‘MADV_COLD’?
> > >   506 |       hpage_pmd_size, MADV_COLLAPSE);
> > >       |                       ^~~~~~~~~~~~~
> > >       |                       MADV_COLD
> > > khugepaged_race.c:506:23: note: each undeclared identifier is reported only once for each function it appears in
> > > make: *** [../lib.mk:225: /data/code/mm/tools/testing/selftests/mm/khugepaged_race] Error 1
> > 
> > I've just tested with and without make headers on linux-next
> > which has this patch and I've not received such error.
> > 
> > If your system headers are old, running make headers can help.
> 
> I forgot to mention that this can be fixed like fd5295afae91.

Right. Would you like to send the fix?

-- 
  Kiryl Shutsemau / Kirill A. Shutemov

  reply	other threads:[~2026-10-21 10:34 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19  0:24 [PATCH v6 00/19] selftests/mm: improve khugepaged coverage Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 01/19] selftests/mm: raise the khugepaged test-case cap Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 02/19] selftests/mm: skip collapse_compound_extreme() where the PMD is too large Kiryl Shutsemau
2026-10-08 11:52   ` Zenghui Yu
2026-10-21 10:32     ` Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 03/19] selftests/mm: scale khugepaged's collapse wait with the PMD size Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 04/19] selftests/mm: skip khugepaged page cache cases without a PMD folio Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 05/19] selftests/mm: make the swap cases' swapout reliable Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 06/19] selftests/mm: stop khugepaged during the MADV_COLLAPSE cases Kiryl Shutsemau
2026-09-23  6:25   ` Baolin Wang
2026-09-19  0:24 ` [PATCH v6 07/19] selftests/mm: move is_backed_by_folio() into vm_util Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 08/19] selftests/mm: add folio-order check for address ranges Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 09/19] selftests/mm: add folio-order detection self-check Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 10/19] selftests/mm: add khugepaged completion barrier helper Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 11/19] selftests/mm: add order-parameterized khugepaged collapse cases Kiryl Shutsemau
2026-09-23  6:50   ` Baolin Wang
2026-09-19  0:24 ` [PATCH v6 12/19] selftests/mm: parameterize the mixed-source collapse case by source order Kiryl Shutsemau
2026-09-23  6:55   ` Baolin Wang
2026-09-19  0:24 ` [PATCH v6 13/19] selftests/mm: cover a shared-source collapse write race Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 14/19] selftests/mm: run every supported collapse order by default Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 15/19] selftests/mm: check that one khugepaged pass collapses one window Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 16/19] selftests/mm: add khugepaged race harness Kiryl Shutsemau
2026-10-08  7:30   ` Zenghui Yu
2026-10-08  8:18     ` Muhammad Usama Anjum
2026-10-08 14:23       ` Zenghui Yu
2026-10-21 10:34         ` Kiryl Shutsemau [this message]
2026-09-19  0:24 ` [PATCH v6 17/19] selftests/mm: race the collapse of windows with holes Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 18/19] selftests/mm: add memory-pressure threads to the khugepaged race harness Kiryl Shutsemau
2026-09-19  0:24 ` [PATCH v6 19/19] selftests/mm: zap whole PTE tables in " Kiryl Shutsemau
2026-09-20 23:54 ` [PATCH v6 00/19] selftests/mm: improve khugepaged coverage Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atiU94VjdEsWzdBr@thinkstation \
    --to=kas@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=hughd@google.com \
    --cc=jgg@ziepe.ca \
    --cc=kernel-team@meta.com \
    --cc=lance.yang@linux.dev \
    --cc=leon@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=nico.pache@linux.dev \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=usama.anjum@arm.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=zenghui.yu@linux.dev \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®