* [PATCH v3] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801
@ 2026-10-07 9:47 Arpit Saini
2026-11-07 22:10 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Arpit Saini @ 2026-10-07 9:47 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Linus Walleij
Cc: Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
mahadevan.p, rajeevny, Ayushi Makhija, Dmitry Baryshkov,
Konrad Dybcio, Arpit Saini
From: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>
The NT37801 Sepc V1.0 chapter "5.7.1 Power On Sequence" states
VDDI=1.65V~1.95V, so set sufficient voltage for panel nt37801.
Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
Signed-off-by: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
---
Changes in v3:
- Added my signed-off by.
- Link to v2: https://lore.kernel.org/r/4f8a2731-4ea4-49d9-924c-ebde9fc58170@oss.qualcomm.com
---
arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 64bc1cec612e..9ecb40e7e39f 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -462,7 +462,7 @@ vreg_l11b_1p0: ldo11 {
vreg_l12b_1p8: ldo12 {
regulator-name = "vreg_l12b_1p8";
- regulator-min-microvolt = <1200000>;
+ regulator-min-microvolt = <1650000>;
regulator-max-microvolt = <1800000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
---
base-commit: eea3fef32a9cf36abcb5975a5a594e4135a6b026
change-id: 20261007-resend-upstream-attention-f964719a0733
Best regards,
--
Arpit Saini <arpit.saini@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801
2026-10-07 9:47 [PATCH v3] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801 Arpit Saini
@ 2026-11-07 22:10 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2026-11-07 22:10 UTC (permalink / raw)
To: Arpit Saini
Cc: Konrad Dybcio, Abel Vesa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Neil Armstrong, Linus Walleij, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, mahadevan.p, rajeevny,
Ayushi Makhija, Dmitry Baryshkov, Konrad Dybcio
On Wed, Oct 07, 2026 at 03:17:31PM +0530, Arpit Saini wrote:
> From: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>
>
> The NT37801 Sepc V1.0 chapter "5.7.1 Power On Sequence" states
> VDDI=1.65V~1.95V, so set sufficient voltage for panel nt37801.
>
> Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
> Signed-off-by: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
> ---
> Changes in v3:
> - Added my signed-off by.
> - Link to v2: https://lore.kernel.org/r/4f8a2731-4ea4-49d9-924c-ebde9fc58170@oss.qualcomm.com
> ---
> arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> index 64bc1cec612e..9ecb40e7e39f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> @@ -462,7 +462,7 @@ vreg_l11b_1p0: ldo11 {
>
> vreg_l12b_1p8: ldo12 {
> regulator-name = "vreg_l12b_1p8";
> - regulator-min-microvolt = <1200000>;
> + regulator-min-microvolt = <1650000>;
The power grid clearly states that L12B is expected to be at 1.8V.
So, while 1.65V is within range for the NT37801, it's not what the
hardware folks has told us to use.
Please review all the regulators and ensure they have ranges matching
the expectations from the power grid documentation.
Regards,
Bjorn
> regulator-max-microvolt = <1800000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
>
> ---
> base-commit: eea3fef32a9cf36abcb5975a5a594e4135a6b026
> change-id: 20261007-resend-upstream-attention-f964719a0733
>
> Best regards,
> --
> Arpit Saini <arpit.saini@oss.qualcomm.com>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-07 22:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-07 9:47 [PATCH v3] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801 Arpit Saini
2026-11-07 22:10 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®