From: Kayra Cizmeci <kayracizmeci@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
kprateek.nayak@amd.com, joshdon@google.com, tj@kernel.org,
jakub@okonski.org
Subject: Re: [PATCH v2 2/3] sched/fair: Make cfs_rq::idle the sum of ancestor tg::idle
Date: Sat, 7 Nov 2026 16:13:38 +0300 [thread overview]
Message-ID: <au8eBgyrVXEWjhxX@scheduler.schedules> (raw)
In-Reply-To: <20261107113639.GK2668200@noisy.programming.kicks-ass.net>
Hi Peter!
On Sat, Nov 07, 2026 at 12:36:39PM +0100, Peter Zijlstra wrote:
>
> Rather than keeping cfs_rq::idle as a copy of tg::idle, make it the sum of
> all ancestor tg::idle. This makes it trivial to tell if the current cgroup
> is marked idle somewhere along its ancestral path.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
First of all,
Reviewed-by: Kayra Cizmeci <kayracizmeci@gmail.com>
With this, now tasks in an idle cfs_rq cannot be buddies.
But IMO that's more of a fix. Maybe it would be good to
add a fixes tag?
Cheers,
Kayra
next prev parent reply other threads:[~2026-11-07 13:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 16:55 [PATCH 0/3] sched/fair: Fix cgroup::idle preemption Peter Zijlstra
2026-11-05 16:55 ` [PATCH 1/3] sched/fair: Use guard in sched_group_set_idle() Peter Zijlstra
2026-11-05 17:42 ` Kayra Cizmeci
2026-11-06 16:04 ` Vincent Guittot
2026-11-05 16:55 ` [PATCH 2/3] sched/fair: Make cfs_rq::idle the sum of ancestor tg::idle Peter Zijlstra
2026-11-05 19:20 ` Kayra Cizmeci
2026-11-06 8:31 ` Peter Zijlstra
2026-11-06 8:53 ` Peter Zijlstra
2026-11-06 9:01 ` Kayra Cizmeci
2026-11-06 8:57 ` Kayra Cizmeci
2026-11-06 9:01 ` Peter Zijlstra
2026-11-06 9:11 ` Kayra Cizmeci
2026-11-06 16:24 ` Vincent Guittot
2026-11-07 11:36 ` [PATCH v2 " Peter Zijlstra
2026-11-07 13:13 ` Kayra Cizmeci [this message]
2026-11-05 16:55 ` [RFC][PATCH 3/3] sched/eevdf: Fix sched idle task group preemption Peter Zijlstra
2026-11-05 20:10 ` Kayra Cizmeci
2026-11-07 13:28 ` Kayra Cizmeci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au8eBgyrVXEWjhxX@scheduler.schedules \
--to=kayracizmeci@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jakub@okonski.org \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®