mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property
@ 2026-10-25  6:48 Vishnu Saini
  2026-10-27  8:12 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Vishnu Saini @ 2026-10-25  6:48 UTC (permalink / raw)
  To: Neil Armstrong, Jessica Zhang, David Airlie, Simona Vetter,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Arpit Saini
  Cc: dri-devel, devicetree, linux-kernel, venkata.valluru,
	Jessica Zhang, Vishnu Saini

The DLC0697 panel is lit by a separate backlight device, which is
referenced from the panel node through the common 'backlight'
property.

Declare 'backlight: true' so the property is explicitly allowed by the
schema.

Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
index ba8c5bbf8ffc..46b941c18565 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
@@ -23,6 +23,8 @@ properties:
     maxItems: 1
     description: DSI virtual channel
 
+  backlight: true
+
   vddi-supply:
     description: I/O voltage supply (1.8V)
 

---
base-commit: cf61bef3801c3c9d0d8c39026b7b2fb242898a3a
change-id: 20261025-dlc_backlight-c00d00ec8f62

Best regards,
-- 
Vishnu Saini <vishnu.saini@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property
  2026-10-25  6:48 [PATCH] dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property Vishnu Saini
@ 2026-10-27  8:12 ` Krzysztof Kozlowski
  2026-10-27 10:57   ` Vishnu Saini
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-27  8:12 UTC (permalink / raw)
  To: Vishnu Saini
  Cc: Neil Armstrong, Jessica Zhang, David Airlie, Simona Vetter,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Arpit Saini, dri-devel,
	devicetree, linux-kernel, venkata.valluru

On Sun, Oct 25, 2026 at 12:18:17PM +0530, Vishnu Saini wrote:
> The DLC0697 panel is lit by a separate backlight device, which is
> referenced from the panel node through the common 'backlight'
> property.
> 
> Declare 'backlight: true' so the property is explicitly allowed by the
> schema.

Why do you need to explicitly allow it? Since when?

I see no benefit of this patch and commit msg does not explain me what
that benefit would be.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property
  2026-10-27  8:12 ` Krzysztof Kozlowski
@ 2026-10-27 10:57   ` Vishnu Saini
  2026-10-27 14:34     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Vishnu Saini @ 2026-10-27 10:57 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Neil Armstrong, Jessica Zhang, David Airlie, Simona Vetter,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Arpit Saini, dri-devel,
	devicetree, linux-kernel, venkata.valluru

On Tue, Oct 27, 2026 at 09:12:27AM +0100, Krzysztof Kozlowski wrote:
> On Sun, Oct 25, 2026 at 12:18:17PM +0530, Vishnu Saini wrote:
> > The DLC0697 panel is lit by a separate backlight device, which is
> > referenced from the panel node through the common 'backlight'
> > property.
> > 
> > Declare 'backlight: true' so the property is explicitly allowed by the
> > schema.
> 
> Why do you need to explicitly allow it? Since when?
> 
> I see no benefit of this patch and commit msg does not explain me what
> that benefit would be.
It is required for below DLC panel, when enabling backlight using gpio-backlight driver,
Apologies, missed to add this in dependency there.
https://lore.kernel.org/all/20261021-shikra_display_overlays-v1-2-adaea735999f@oss.qualcomm.com/
> Best regards,
> Krzysztof
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property
  2026-10-27 10:57   ` Vishnu Saini
@ 2026-10-27 14:34     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-27 14:34 UTC (permalink / raw)
  To: Vishnu Saini
  Cc: Neil Armstrong, Jessica Zhang, David Airlie, Simona Vetter,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Arpit Saini, dri-devel,
	devicetree, linux-kernel, venkata.valluru

On 27/10/2026 11:57, Vishnu Saini wrote:
> On Tue, Oct 27, 2026 at 09:12:27AM +0100, Krzysztof Kozlowski wrote:
>> On Sun, Oct 25, 2026 at 12:18:17PM +0530, Vishnu Saini wrote:
>>> The DLC0697 panel is lit by a separate backlight device, which is
>>> referenced from the panel node through the common 'backlight'
>>> property.
>>>
>>> Declare 'backlight: true' so the property is explicitly allowed by the
>>> schema.
>>
>> Why do you need to explicitly allow it? Since when?
>>
>> I see no benefit of this patch and commit msg does not explain me what
>> that benefit would be.
> It is required for below DLC panel, when enabling backlight using gpio-backlight driver,

How is it required? You did not really answer, so again:

Why do you need to explicitly allow it?

Answer starts "because ... " and you provide technical arguments, not
wishes.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-27 14:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-25  6:48 [PATCH] dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property Vishnu Saini
2026-10-27  8:12 ` Krzysztof Kozlowski
2026-10-27 10:57   ` Vishnu Saini
2026-10-27 14:34     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®