From: Keith Busch <kbusch@kernel.org>
To: Erwan Velu <erwanaliasr1@gmail.com>
Cc: Erwan Velu <e.velu@criteo.com>,
linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
sagi@grimberg.me, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: honor the volatile write cache enable state
Date: Wed, 28 Oct 2026 11:47:25 -0600 [thread overview]
Message-ID: <auI1LR6Ql397Kl2b@kbusch-mbp> (raw)
In-Reply-To: <CAL2JzuzMo3xTMbF6LK97yf6-CB0_NGhr7sGpf69Gv3ONvZQ1KQ@mail.gmail.com>
On Wed, Oct 28, 2026 at 06:08:17PM +0100, Erwan Velu wrote:
> Le mer. 28 oct. 2026 à 17:08, Keith Busch <kbusch@kernel.org> a écrit :
> [...]
> > > Considering the performance impact for these type of device,s would you be
> > > open to a backport to stable once merged ?
> >
> > Not sure when a performance improvement is stable worthy. I'm more
> > concerned that doing this is going to expose corruption, but it's what
> > the device is asking for, so fine to introduce it, but stable is
> > questionable.
> If we consider this dangerous for this device, should we add a quirk
> for some devices that could be seen as lying?
Let's just assume spec complaince for now until proven otherwise.
When/if a device is discovered to be quirky on this feature, we can
introduce handling to ignore WCE.
prev parent reply other threads:[~2026-10-28 17:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 14:12 Erwan Velu
2026-10-16 16:57 ` Keith Busch
2026-10-16 17:15 ` Erwan Velu
2026-10-16 17:27 ` Keith Busch
2026-10-16 17:43 ` Erwan Velu
2026-10-16 17:55 ` Keith Busch
2026-10-17 4:25 ` Erwan Velu
2026-10-22 13:27 ` Erwan Velu
2026-10-22 23:17 ` Keith Busch
2026-10-23 14:53 ` Erwan Velu
2026-10-28 16:08 ` Keith Busch
2026-10-28 16:16 ` Christoph Hellwig
2026-10-28 17:08 ` Erwan Velu
2026-10-28 17:47 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auI1LR6Ql397Kl2b@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=e.velu@criteo.com \
--cc=erwanaliasr1@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®