[PATCH] staging: greybus: audio_manager: Add newline to sysfs output

[PATCH] staging: greybus: audio_manager: Add newline to sysfs output

[Maria Sheikh]

Fix checkpatch warning:

WARNING: return sysfs_emit(. . .) formats should include a terminating
newline.

Add "\n" to the sysfs_emit() format strings of the name, vid, pid,
intf_id, ip_devices and op_devices attributes.

Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>
---
 drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index dc90cc2d2308..5737f2a32f5a 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj)
 static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
 					 struct gb_audio_manager_module_attribute *attr, char *buf)
 {
-	return sysfs_emit(buf, "%s", module->desc.name);
+	return sysfs_emit(buf, "%s\n", module->desc.name);
 }
 
 static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
@@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
 static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module,
 					struct gb_audio_manager_module_attribute *attr, char *buf)
 {
-	return sysfs_emit(buf, "%d", module->desc.vid);
+	return sysfs_emit(buf, "%d\n", module->desc.vid);
 }
 
 static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
@@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
 static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module,
 					struct gb_audio_manager_module_attribute *attr, char *buf)
 {
-	return sysfs_emit(buf, "%d", module->desc.pid);
+	return sysfs_emit(buf, "%d\n", module->desc.pid);
 }
 
 static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute =
@@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu
 					    struct gb_audio_manager_module_attribute *attr,
 					    char *buf)
 {
-	return sysfs_emit(buf, "%d", module->desc.intf_id);
+	return sysfs_emit(buf, "%d\n", module->desc.intf_id);
 }
 
 static struct gb_audio_manager_module_attribute
@@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m
 					       struct gb_audio_manager_module_attribute *attr,
 					       char *buf)
 {
-	return sysfs_emit(buf, "0x%X", module->desc.ip_devices);
+	return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices);
 }
 
 static struct gb_audio_manager_module_attribute
@@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m
 					       struct gb_audio_manager_module_attribute *attr,
 					       char *buf)
 {
-	return sysfs_emit(buf, "0x%X", module->desc.op_devices);
+	return sysfs_emit(buf, "0x%X\n", module->desc.op_devices);
 }
 
 static struct gb_audio_manager_module_attribute
-- 
2.53.0

Re: [PATCH] staging: greybus: audio_manager: Add newline to sysfs output

[Dan Carpenter]

On Thu, Oct 29, 2026 at 11:19:40PM +0500, Maria Sheikh wrote:
> Fix checkpatch warning:
> 
> WARNING: return sysfs_emit(. . .) formats should include a terminating
> newline.
> 
> Add "\n" to the sysfs_emit() format strings of the name, vid, pid,
> intf_id, ip_devices and op_devices attributes.
> 
> Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>

This changes how the sysfs file appears to the user and potentially
breaks a script or something.  You can't do it without testing.

regards,
dan carpenter

Re: [PATCH] staging: greybus: audio_manager: Add newline to sysfs output

[Julia Lawall]

Please read the recent mailing list archives. A similar patch was already rejected.

> On 29 Oct 2026, at 14:25, Maria Sheikh <mariasheikh812@gmail.com> wrote:
> 
> Fix checkpatch warning:
> 
> WARNING: return sysfs_emit(. . .) formats should include a terminating
> newline.
> 
> Add "\n" to the sysfs_emit() format strings of the name, vid, pid,
> intf_id, ip_devices and op_devices attributes.
> 
> Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>
> ---
> drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> index dc90cc2d2308..5737f2a32f5a 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj)
> static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
>                     struct gb_audio_manager_module_attribute *attr, char *buf)
> {
> -    return sysfs_emit(buf, "%s", module->desc.name);
> +    return sysfs_emit(buf, "%s\n", module->desc.name);
> }
> 
> static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
> @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
> static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module,
>                    struct gb_audio_manager_module_attribute *attr, char *buf)
> {
> -    return sysfs_emit(buf, "%d", module->desc.vid);
> +    return sysfs_emit(buf, "%d\n", module->desc.vid);
> }
> 
> static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
> @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
> static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module,
>                    struct gb_audio_manager_module_attribute *attr, char *buf)
> {
> -    return sysfs_emit(buf, "%d", module->desc.pid);
> +    return sysfs_emit(buf, "%d\n", module->desc.pid);
> }
> 
> static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute =
> @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu
>                        struct gb_audio_manager_module_attribute *attr,
>                        char *buf)
> {
> -    return sysfs_emit(buf, "%d", module->desc.intf_id);
> +    return sysfs_emit(buf, "%d\n", module->desc.intf_id);
> }
> 
> static struct gb_audio_manager_module_attribute
> @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m
>                           struct gb_audio_manager_module_attribute *attr,
>                           char *buf)
> {
> -    return sysfs_emit(buf, "0x%X", module->desc.ip_devices);
> +    return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices);
> }
> 
> static struct gb_audio_manager_module_attribute
> @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m
>                           struct gb_audio_manager_module_attribute *attr,
>                           char *buf)
> {
> -    return sysfs_emit(buf, "0x%X", module->desc.op_devices);
> +    return sysfs_emit(buf, "0x%X\n", module->desc.op_devices);
> }
> 
> static struct gb_audio_manager_module_attribute
> --
> 2.53.0
> 
>