From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nicolae-Daniel Deaconescu <Nicolae-daniel.Deaconescu@analog.com>
Cc: sergiu.cuciurean@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
ukleinek@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH 0/2] iio: adc: add LTC2387 and ADAQ2387x support
Date: Sat, 31 Oct 2026 10:36:27 +0200 [thread overview]
Message-ID: <auWoi0Vad8F-aTmJ@ashevche-desk.local> (raw)
In-Reply-To: <20261030150705.411102-1-Nicolae-daniel.Deaconescu@analog.com>
On Fri, Oct 30, 2026 at 05:07:05PM +0200, Nicolae-Daniel Deaconescu wrote:
> On Fri, 30 Oct 2026 16:41:27 +0200, Andy Shevchenko wrote:
> > But these difference doesn't explain why you need a brand new driver.
> > Is hard to configure this at run-time by choosing the respective driver
> > data based on the compatible string?
>
> Looking at ad7625.c again, most of it can come from chip data,
> like the driver already does for max_sample_freq_hz. The lack of
> en pins could probably also be parametrized.
>
> However, doing it this way would risk clashing with the sampling
> path of the existing driver. Keeping it separate would make testing
> easier, as well as isolating drivers for unrelated families, which
> might be out of scope for this.
> Ultimately I think keeping them separate would be simpler, but
> I'll integrate it if you believe it's worth it. We might also
> need to consult with the authors of the original driver, as I
> haven't worked with the ad7625 before.
If there is no big differences on RTL or programming flow, no need to create
a brand new driver. Even if there are some differences which are minor, we
may quirk that in the code. See infamous drivers/gpio/gpio-pca953x.c for how
many similar, but not fully chips are supported. With your elaboration above
I believe we may join these drivers to the existing one.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-10-31 8:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 13:44 Nicolae-Daniel Deaconescu
2026-10-27 13:44 ` [PATCH 1/2] dt-bindings: iio: adc: add lltc,ltc2387 Nicolae-Daniel Deaconescu
2026-10-27 18:28 ` Conor Dooley
2026-10-30 12:02 ` Nicolae-Daniel Deaconescu
2026-10-30 20:50 ` Conor Dooley
2026-10-29 9:47 ` Krzysztof Kozlowski
2026-10-30 12:02 ` Nicolae-Daniel Deaconescu
2026-10-30 12:07 ` Krzysztof Kozlowski
2026-10-30 12:37 ` Nicolae-Daniel Deaconescu
2026-10-27 13:44 ` [PATCH 2/2] iio: adc: add ltc2387 driver Nicolae-Daniel Deaconescu
2026-10-27 14:37 ` Joshua Crofts
2026-10-28 2:39 ` Jonathan Cameron
2026-10-30 12:02 ` Nicolae-Daniel Deaconescu
2026-10-30 13:22 ` Nicolae-Daniel Deaconescu
2026-10-27 15:56 ` [PATCH 0/2] iio: adc: add LTC2387 and ADAQ2387x support Andy Shevchenko
2026-10-30 10:08 ` Nicolae-Daniel Deaconescu
2026-10-30 14:41 ` Andy Shevchenko
2026-10-30 15:07 ` Nicolae-Daniel Deaconescu
2026-10-31 8:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auWoi0Vad8F-aTmJ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Nicolae-daniel.Deaconescu@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=sergiu.cuciurean@analog.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®