From: Carlos Maiolino <cem@kernel.org>
To: Reid Downing <skibletz@gmail.com>
Cc: David Laight <david.laight.linux@gmail.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>,
Eric Sandeen <sandeen@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] xfs: fix wrong compat fields in xfs_ioctl32_bstat_copyin()
Date: Mon, 2 Nov 2026 13:43:11 +0100 [thread overview]
Message-ID: <auiFOLV7AkgH5OgC@nidhogg.toxiclabs.cc> (raw)
In-Reply-To: <20261028113127.3374246-1-skibletz@gmail.com>
On Wed, Oct 28, 2026 at 07:31:27AM -0400, Reid Downing wrote:
> Hi David, Eric, Carlos,
>
> Thank you all for the careful review, and Eric, thanks for catching
> the second line.
>
> I looked at the refactor David suggested and Eric sketched, and I
> agree it is the better way to write this function. I'm not confident
> enough in the 32-bit compat code to send it myself, and I only want to
> send changes I can fully vouch for. If the refactor should go in, I'd
> be glad to see it done.
Might be, but that's a subject for another patch, not this one.
For this one:
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
>
> Reid
next prev parent reply other threads:[~2026-11-02 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 16:17 Reid Downing
2026-10-27 16:49 ` David Laight
2026-10-28 15:18 ` Christoph Hellwig
2026-10-28 18:38 ` David Laight
2026-10-28 11:31 ` Reid Downing
2026-11-02 12:43 ` Carlos Maiolino [this message]
2026-11-04 14:11 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auiFOLV7AkgH5OgC@nidhogg.toxiclabs.cc \
--to=cem@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=skibletz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®