[PATCH v5] sched/eevdf: Fix vprot across reweighting

[PATCH v5] sched/eevdf: Fix vprot across reweighting

[Kayra Cizmeci]

Currently in reweighting, while a tasks vruntime changes dead protection
could go alive, or alive protection could decrease, increase and go dead.
Fix it in reweight_eevdf(), and just cancel it in the sched_change_end()
path.

Fixes: 80390ead2080 ("sched/fair: Separate se->vlag from se->vprot")
Fixes: bcd74b2ffdd0 ("sched/fair: Only set slice protection at pick time")
Suggested-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Kayra Cizmeci <kayracizmeci@gmail.com>
---
Changes v4->v5:
* Use Vincent's comment
* Grab Tags

v4: https://lore.kernel.org/lkml/20261016150402.6952-1-kayracizmeci@gmail.com/

Not tested.

 kernel/sched/fair.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 0feec172fd37..fd8902813c9f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4892,12 +4892,15 @@ static void reweight_eevdf(struct cfs_rq *cfs_rq, struct sched_entity *se,
 	update_load_set(&se->h_load, weight);
 
 	if (on_rq) {
-		if (rel_vprot)
-			se->vprot += avruntime;
 		se->deadline += avruntime;
 		se->rel_deadline = 0;
 		se->vruntime = avruntime - se->vlag;
 
+		if (rel_vprot)
+			se->vprot += avruntime;
+		else if (curr)
+			se->vprot = se->vruntime;
+
 		if (!curr)
 			__enqueue_entity(cfs_rq, se);
 		cfs_rq->h_nr_queued++;
@@ -8202,6 +8205,14 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
 	if (!curr) {
 		reweight_eevdf(cfs_rq, se, weight, false);
 		place_entity(cfs_rq, se, flags | ENQUEUE_QUEUED);
+		/*
+		 * During a sched_change pattern, current is dequeued and
+		 * cfs_rq->curr becomes NULL while rq->donor == p. As all
+		 * properties can change, cancel slice protection which is
+		 * not reliable anymore.
+		 */
+		if (task_current_donor(rq, p))
+			cancel_protect_slice(se);
 		__enqueue_entity(cfs_rq, se);
 	}
 
-- 
2.53.0

Re: [PATCH v5] sched/eevdf: Fix vprot across reweighting

[Kayra Cizmeci]

Hi Peter,

Gentle ping on this one. Do you think its ready to be applied?


Thanks,

Kayra