* [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't"
@ 2026-10-28 18:31 Colin Ian King
2026-11-02 10:52 ` James Clark
2026-11-03 17:07 ` Namhyung Kim
0 siblings, 2 replies; 5+ messages in thread
From: Colin Ian King @ 2026-10-28 18:31 UTC (permalink / raw)
To: John Garry, Will Deacon, James Clark, Mike Leach, Leo Yan,
Suzuki K Poulose, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
linux-arm-kernel, coresight, linux-perf-users
Cc: kernel-janitors, linux-kernel
There is a spelling mistake in a pr_err error message. Fix it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
tools/perf/util/cs-etm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index bdcf94813129..65bce2450549 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -434,7 +434,7 @@ static int cs_etm__map_unformatted_trace_ids(struct cs_etm_auxtrace *etm)
continue;
if (!intlist__empty(etmq->traceid_list)) {
- pr_err("CS_ETM: Unformatted queue should't have trace ID\n");
+ pr_err("CS_ETM: Unformatted queue shouldn't have trace ID\n");
return -EINVAL;
}
--
2.55.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't"
2026-10-28 18:31 [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't" Colin Ian King
@ 2026-11-02 10:52 ` James Clark
2026-11-02 18:01 ` Ian Rogers
2026-11-03 17:07 ` Namhyung Kim
1 sibling, 1 reply; 5+ messages in thread
From: James Clark @ 2026-11-02 10:52 UTC (permalink / raw)
To: Colin Ian King
Cc: kernel-janitors, linux-kernel, John Garry, Will Deacon,
Mike Leach, Leo Yan, Suzuki K Poulose, Peter Zijlstra,
Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, linux-arm-kernel, coresight, linux-perf-users
On 28/10/2026 18:31, Colin Ian King wrote:
> There is a spelling mistake in a pr_err error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> tools/perf/util/cs-etm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index bdcf94813129..65bce2450549 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -434,7 +434,7 @@ static int cs_etm__map_unformatted_trace_ids(struct cs_etm_auxtrace *etm)
> continue;
>
> if (!intlist__empty(etmq->traceid_list)) {
> - pr_err("CS_ETM: Unformatted queue should't have trace ID\n");
> + pr_err("CS_ETM: Unformatted queue shouldn't have trace ID\n");
> return -EINVAL;
> }
>
Reviewed-by: James Clark <james.clark@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't"
2026-11-02 10:52 ` James Clark
@ 2026-11-02 18:01 ` Ian Rogers
2026-11-03 9:33 ` James Clark
0 siblings, 1 reply; 5+ messages in thread
From: Ian Rogers @ 2026-11-02 18:01 UTC (permalink / raw)
To: James Clark, Colin Ian King
Cc: kernel-janitors, linux-kernel, John Garry, Will Deacon,
Mike Leach, Leo Yan, Suzuki K Poulose, Peter Zijlstra,
Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
linux-arm-kernel, coresight, linux-perf-users
On Mon, Nov 2, 2026 at 2:52 AM James Clark <james.clark@linaro.org> wrote:
>
>
>
> On 28/10/2026 18:31, Colin Ian King wrote:
> > There is a spelling mistake in a pr_err error message. Fix it.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> > tools/perf/util/cs-etm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> > index bdcf94813129..65bce2450549 100644
> > --- a/tools/perf/util/cs-etm.c
> > +++ b/tools/perf/util/cs-etm.c
> > @@ -434,7 +434,7 @@ static int cs_etm__map_unformatted_trace_ids(struct cs_etm_auxtrace *etm)
> > continue;
> >
> > if (!intlist__empty(etmq->traceid_list)) {
> > - pr_err("CS_ETM: Unformatted queue should't have trace ID\n");
> > + pr_err("CS_ETM: Unformatted queue shouldn't have trace ID\n");
> > return -EINVAL;
> > }
> >
>
> Reviewed-by: James Clark <james.clark@linaro.org>
>
I was curious how this passed Sashiko's review. Did Sashiko flag the
spelling mistake but the fix was missed, or did Sashiko not flag it at
all?
Thanks!
Ian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't"
2026-11-02 18:01 ` Ian Rogers
@ 2026-11-03 9:33 ` James Clark
0 siblings, 0 replies; 5+ messages in thread
From: James Clark @ 2026-11-03 9:33 UTC (permalink / raw)
To: Ian Rogers, Colin Ian King
Cc: kernel-janitors, linux-kernel, John Garry, Will Deacon,
Mike Leach, Leo Yan, Suzuki K Poulose, Peter Zijlstra,
Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
linux-arm-kernel, coresight, linux-perf-users
On 02/11/2026 18:01, Ian Rogers wrote:
> On Mon, Nov 2, 2026 at 2:52 AM James Clark <james.clark@linaro.org> wrote:
>>
>>
>>
>> On 28/10/2026 18:31, Colin Ian King wrote:
>>> There is a spelling mistake in a pr_err error message. Fix it.
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>> ---
>>> tools/perf/util/cs-etm.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
>>> index bdcf94813129..65bce2450549 100644
>>> --- a/tools/perf/util/cs-etm.c
>>> +++ b/tools/perf/util/cs-etm.c
>>> @@ -434,7 +434,7 @@ static int cs_etm__map_unformatted_trace_ids(struct cs_etm_auxtrace *etm)
>>> continue;
>>>
>>> if (!intlist__empty(etmq->traceid_list)) {
>>> - pr_err("CS_ETM: Unformatted queue should't have trace ID\n");
>>> + pr_err("CS_ETM: Unformatted queue shouldn't have trace ID\n");
>>> return -EINVAL;
>>> }
>>>
>>
>> Reviewed-by: James Clark <james.clark@linaro.org>
>>
>
> I was curious how this passed Sashiko's review. Did Sashiko flag the
> spelling mistake but the fix was missed, or did Sashiko not flag it at
> all?
>
> Thanks!
> Ian
It reviewed it, but it didn't flag it. What kind of typos is it supposed
to look for? I haven't seen it flag one before.
I have a spellchecker in my IDE which didn't catch it either because
should is correct and t is only 1 letter. Maybe there is a setting I can
tweak.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't"
2026-10-28 18:31 [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't" Colin Ian King
2026-11-02 10:52 ` James Clark
@ 2026-11-03 17:07 ` Namhyung Kim
1 sibling, 0 replies; 5+ messages in thread
From: Namhyung Kim @ 2026-11-03 17:07 UTC (permalink / raw)
To: Colin Ian King
Cc: John Garry, Will Deacon, James Clark, Mike Leach, Leo Yan,
Suzuki K Poulose, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Ian Rogers, Adrian Hunter, linux-arm-kernel,
coresight, linux-perf-users, kernel-janitors, linux-kernel
On Wed, Oct 28, 2026 at 06:31:37PM +0000, Colin Ian King wrote:
> There is a spelling mistake in a pr_err error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied to perf-tools-next, thanks!
Best regards
Namhyung
> ---
> tools/perf/util/cs-etm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index bdcf94813129..65bce2450549 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -434,7 +434,7 @@ static int cs_etm__map_unformatted_trace_ids(struct cs_etm_auxtrace *etm)
> continue;
>
> if (!intlist__empty(etmq->traceid_list)) {
> - pr_err("CS_ETM: Unformatted queue should't have trace ID\n");
> + pr_err("CS_ETM: Unformatted queue shouldn't have trace ID\n");
> return -EINVAL;
> }
>
> --
> 2.55.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-03 17:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-28 18:31 [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't" Colin Ian King
2026-11-02 10:52 ` James Clark
2026-11-02 18:01 ` Ian Rogers
2026-11-03 9:33 ` James Clark
2026-11-03 17:07 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®