mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	pierluigi.p@variscite.com, alexander.h@variscite.com,
	"Stefano Radaelli" <stefano.r@variscite.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
	"Linus Walleij" <linusw@kernel.org>,
	"Kees Cook" <kees+treewide@kernel.org>,
	"Uwe Kleine-König (The Capable Hub)"
	<u.kleine-koenig@baylibre.com>,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v1 1/1] ASoC: wm8904: Enable FLL when switching an active SYSCLK to FLL
Date: Wed, 4 Nov 2026 16:26:51 +0000	[thread overview]
Message-ID: <autcy3Wqks3Q2WXv@opensource.cirrus.com> (raw)
In-Reply-To: <20261104155832.57738-1-stefano.r@variscite.com>

On Wed, Nov 04, 2026 at 04:58:32PM +0100, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@variscite.com>
> 
> When switching SYSCLK from MCLK to FLL, DAPM may keep SYSCLK powered
> and skip the PRE_PMU event that normally enables the FLL. This leaves
> SYSCLK sourced from a disabled FLL and can cause playback to fail.
> 
> Enable FLL_OSC_ENA and FLL_ENA before selecting FLL as the SYSCLK
> source when WM8904_CLK_SYS_ENA is already set.
> 
> On VAR-SOM-MX8X, playing audio at 48 kHz followed immediately by
> 8 kHz reproduced an I/O error when switching from MCLK to FLL.
> With this change, playback succeeds.
> 
> Co-developed-by: Alexander Herfurtner <alexander.h@variscite.com>
> Signed-off-by: Alexander Herfurtner <alexander.h@variscite.com>
> Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

  reply	other threads:[~2026-11-04 16:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 15:58 Stefano Radaelli
2026-11-04 16:26 ` Charles Keepax [this message]
2026-11-04 18:37 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=autcy3Wqks3Q2WXv@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alexander.h@variscite.com \
    --cc=broonie@kernel.org \
    --cc=kees+treewide@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=pierluigi.p@variscite.com \
    --cc=stefano.r@variscite.com \
    --cc=stefano.radaelli21@gmail.com \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®