[PATCH v2 1/2] tty: serial: pch_uart: replace chan->device->dev with dmaengine_get_provider_device()

[PATCH v2 1/2] tty: serial: pch_uart: replace chan->device->dev with dmaengine_get_provider_device()

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Use the dmaengine_get_provider_device() API instead of directly
accessing chan->device->dev to get the DMA provider device.

No functional change. Prepare make to struct dma_device private to the DMA
engine.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
- split pch_uart.c to new patch
- fix indentation
---
 drivers/tty/serial/pch_uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index 9505d255f09c5..c53e6b46de4d7 100644
--- a/drivers/tty/serial/pch_uart.c
+++ b/drivers/tty/serial/pch_uart.c
@@ -655,8 +655,8 @@ static bool filter(struct dma_chan *chan, void *slave)
 {
 	struct pch_dma_slave *param = slave;
 
-	if ((chan->chan_id == param->chan_id) && (param->dma_dev ==
-						  chan->device->dev)) {
+	if ((chan->chan_id == param->chan_id) &&
+	    (param->dma_dev == dmaengine_get_provider_device(chan))) {
 		chan->private = param;
 		return true;
 	} else {
-- 
2.43.0

[PATCH v2 2/2] tty: serial: 8250: replace chan->device->dev with dmaengine_get_provider_device()

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Use the dmaengine_get_provider_device() API instead of directly
accessing chan->device->dev to get the DMA provider device.

No functional change. Prepare make to struct dma_device private to the DMA
engine.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
- split pch_uart.c to new patch and keep only 8250*
- andy's add new API suggest, defer to next release.
---
 drivers/tty/serial/8250/8250_dw.c   | 2 +-
 drivers/tty/serial/8250/8250_lpss.c | 2 +-
 drivers/tty/serial/8250/8250_mid.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index eca02e8bd6d13..9adaf5b5fbd56 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -530,7 +530,7 @@ static bool dw8250_fallback_dma_filter(struct dma_chan *chan, void *param)
 
 static bool dw8250_idma_filter(struct dma_chan *chan, void *param)
 {
-	return param == chan->device->dev;
+	return param == dmaengine_get_provider_device(chan);
 }
 
 static void dw8250_setup_dma_filter(struct uart_port *p, struct dw8250_data *data)
diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
index 7e88f2b793b5a..eed37e8b3e831 100644
--- a/drivers/tty/serial/8250/8250_lpss.c
+++ b/drivers/tty/serial/8250/8250_lpss.c
@@ -269,7 +269,7 @@ static bool lpss8250_dma_filter(struct dma_chan *chan, void *param)
 {
 	struct dw_dma_slave *dws = param;
 
-	if (dws->dma_dev != chan->device->dev)
+	if (dws->dma_dev != dmaengine_get_provider_device(chan))
 		return false;
 
 	chan->private = dws;
diff --git a/drivers/tty/serial/8250/8250_mid.c b/drivers/tty/serial/8250/8250_mid.c
index 44b43163df511..dfd2460983fab 100644
--- a/drivers/tty/serial/8250/8250_mid.c
+++ b/drivers/tty/serial/8250/8250_mid.c
@@ -252,7 +252,7 @@ static bool mid8250_dma_filter(struct dma_chan *chan, void *param)
 {
 	struct hsu_dma_slave *s = param;
 
-	if (s->dma_dev != chan->device->dev || s->chan_id != chan->chan_id)
+	if (s->dma_dev != dmaengine_get_provider_device(chan) || s->chan_id != chan->chan_id)
 		return false;
 
 	chan->private = s;
-- 
2.43.0

Re: [PATCH v2 1/2] tty: serial: pch_uart: replace chan->device->dev with dmaengine_get_provider_device()

[Andy Shevchenko]

On Wed, Nov 04, 2026 at 09:52:06AM -0500, Frank.Li@oss.nxp.com wrote:
> 
> Use the dmaengine_get_provider_device() API instead of directly
> accessing chan->device->dev to get the DMA provider device.
> 
> No functional change. Prepare make to struct dma_device private to the DMA
> engine.

Krzysztof, this patch was a split from the bundle by a reviewer request (not me
FWIW), and author obeyed. So, you can do the same in cases when you got something
you want to review independently on other content which most likely is a noise
(to you).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 1/2] tty: serial: pch_uart: replace chan->device->dev with dmaengine_get_provider_device()

[Andy Shevchenko]

On Wed, Nov 04, 2026 at 09:52:06AM -0500, Frank.Li@oss.nxp.com wrote:

> Use the dmaengine_get_provider_device() API instead of directly
> accessing chan->device->dev to get the DMA provider device.
> 
> No functional change. Prepare make to struct dma_device private to the DMA
> engine.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 2/2] tty: serial: 8250: replace chan->device->dev with dmaengine_get_provider_device()

[Andy Shevchenko]

On Wed, Nov 04, 2026 at 09:52:07AM -0500, Frank.Li@oss.nxp.com wrote:

> Use the dmaengine_get_provider_device() API instead of directly
> accessing chan->device->dev to get the DMA provider device.
> 
> No functional change. Prepare make to struct dma_device private to the DMA
> engine.

...

> -	if (s->dma_dev != chan->device->dev || s->chan_id != chan->chan_id)
> +	if (s->dma_dev != dmaengine_get_provider_device(chan) || s->chan_id != chan->chan_id)

Now it's better to wrap (I think the file doesn't really use relaxed limit of
100 characters per line).

	if (s->dma_dev != dmaengine_get_provider_device(chan) ||
	    s->chan_id != chan->chan_id)

>  		return false;

But TBH I don't care much, so
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko