mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joey Gouly <joey.gouly@arm.com>
To: Fuad Tabba <fuad.tabba@linux.dev>
Cc: Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>,
	Will Deacon <will@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Shuah Khan <shuah@kernel.org>,
	Steffen Eiden <seiden@linux.ibm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Vincent Donnefort <vdonnefort@google.com>,
	Quentin Perret <qperret@google.com>,
	Fuad Tabba <tabba@google.com>,
	kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/16] KVM: arm64: selftests: Add protected-VM boot trampoline
Date: Thu, 5 Nov 2026 13:34:09 +0000	[thread overview]
Message-ID: <auyF0ePpUlJKZgNo@e143914.arm.com> (raw)
In-Reply-To: <20261104084842.132944-6-fuad.tabba@linux.dev>

On Wed, Nov 04, 2026 at 08:48:31AM +0000, Fuad Tabba wrote:
> EL2 takes only PC and X0 from the host when it boots a protected vCPU,
> and resets everything else. So the registers the selftest library sets
> before the first run never reach the guest.
> 
> Boot a protected guest through a trampoline that restores X0-X7, seven
> EL1 system registers and the stack pointer from a block X0 points to,
> then enables the MMU and branches to the guest's entry point.
> 
> Co-developed-by: Will Deacon <will@kernel.org>
> Signed-off-by: Will Deacon <will@kernel.org>
> Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>

Similar idea to the 'realm-boot' I added, and mentioned previously. I
think it should work for Realms too.

Reviewed-by: Joey Gouly <joey.gouly@arm.com>

> ---
>  tools/testing/selftests/kvm/Makefile.kvm      |  1 +
>  .../selftests/kvm/include/arm64/pkvm.h        | 50 ++++++++++++++++
>  .../selftests/kvm/lib/arm64/pvm-entry.S       | 58 +++++++++++++++++++
>  3 files changed, 109 insertions(+)
>  create mode 100644 tools/testing/selftests/kvm/include/arm64/pkvm.h
>  create mode 100644 tools/testing/selftests/kvm/lib/arm64/pvm-entry.S
> 
> diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm
> index 17a4256e90819..c254e82f9a786 100644
> --- a/tools/testing/selftests/kvm/Makefile.kvm
> +++ b/tools/testing/selftests/kvm/Makefile.kvm
> @@ -35,6 +35,7 @@ LIBKVM_arm64 += lib/arm64/gic_v3.c
>  LIBKVM_arm64 += lib/arm64/gic_v3_its.c
>  LIBKVM_arm64 += lib/arm64/handlers.S
>  LIBKVM_arm64 += lib/arm64/processor.c
> +LIBKVM_arm64 += lib/arm64/pvm-entry.S
>  LIBKVM_arm64 += lib/arm64/spinlock.c
>  LIBKVM_arm64 += lib/arm64/ucall.c
>  LIBKVM_arm64 += lib/arm64/vgic.c
> diff --git a/tools/testing/selftests/kvm/include/arm64/pkvm.h b/tools/testing/selftests/kvm/include/arm64/pkvm.h
> new file mode 100644
> index 0000000000000..6ef769b8ff977
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/include/arm64/pkvm.h
> @@ -0,0 +1,50 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2025 Google LLC
> + * Author: Fuad Tabba <fuad.tabba@linux.dev>
> + * Author: Will Deacon <will@kernel.org>
> + */
> +
> +#ifndef SELFTEST_KVM_ARM64_PKVM_H
> +#define SELFTEST_KVM_ARM64_PKVM_H
> +
> +#ifndef __ASSEMBLER__
> +/*
> + * Register state the boot trampoline (pvm-entry.S) restores. Only PC and X0
> + * survive to a protected guest's first run, so X0 points at this block.
> + */
> +struct pvm_boot_args {
> +	u64	jump_tgt;
> +
> +	u64	regs[8];
> +	u64	cpacr_el1;
> +	u64	sctlr_el1;
> +	u64	tcr_el1;
> +	u64	mair_el1;
> +	u64	ttbr0_el1;
> +	u64	vbar_el1;
> +
> +	u64	tpidr_el1;
> +	u64	sp_el1;
> +};
> +#endif
> +
> +#define PVM_BOOT_ARGS_OFF_JUMP_TGT	0
> +#define PVM_BOOT_ARGS_OFF_X0		(PVM_BOOT_ARGS_OFF_JUMP_TGT + 8)
> +#define PVM_BOOT_ARGS_OFF_X1		(PVM_BOOT_ARGS_OFF_X0 + 8)
> +#define PVM_BOOT_ARGS_OFF_X2		(PVM_BOOT_ARGS_OFF_X1 + 8)
> +#define PVM_BOOT_ARGS_OFF_X3		(PVM_BOOT_ARGS_OFF_X2 + 8)
> +#define PVM_BOOT_ARGS_OFF_X4		(PVM_BOOT_ARGS_OFF_X3 + 8)
> +#define PVM_BOOT_ARGS_OFF_X5		(PVM_BOOT_ARGS_OFF_X4 + 8)
> +#define PVM_BOOT_ARGS_OFF_X6		(PVM_BOOT_ARGS_OFF_X5 + 8)
> +#define PVM_BOOT_ARGS_OFF_X7		(PVM_BOOT_ARGS_OFF_X6 + 8)
> +#define PVM_BOOT_ARGS_OFF_CPACR_EL1	(PVM_BOOT_ARGS_OFF_X7 + 8)
> +#define PVM_BOOT_ARGS_OFF_SCTLR_EL1	(PVM_BOOT_ARGS_OFF_CPACR_EL1 + 8)
> +#define PVM_BOOT_ARGS_OFF_TCR_EL1	(PVM_BOOT_ARGS_OFF_SCTLR_EL1 + 8)
> +#define PVM_BOOT_ARGS_OFF_MAIR_EL1	(PVM_BOOT_ARGS_OFF_TCR_EL1 + 8)
> +#define PVM_BOOT_ARGS_OFF_TTBR0_EL1	(PVM_BOOT_ARGS_OFF_MAIR_EL1 + 8)
> +#define PVM_BOOT_ARGS_OFF_VBAR_EL1	(PVM_BOOT_ARGS_OFF_TTBR0_EL1 + 8)
> +#define PVM_BOOT_ARGS_OFF_TPIDR_EL1	(PVM_BOOT_ARGS_OFF_VBAR_EL1 + 8)
> +#define PVM_BOOT_ARGS_OFF_SP_EL1	(PVM_BOOT_ARGS_OFF_TPIDR_EL1 + 8)
> +
> +#endif /* SELFTEST_KVM_ARM64_PKVM_H */
> diff --git a/tools/testing/selftests/kvm/lib/arm64/pvm-entry.S b/tools/testing/selftests/kvm/lib/arm64/pvm-entry.S
> new file mode 100644
> index 0000000000000..a0974cde78da6
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/lib/arm64/pvm-entry.S
> @@ -0,0 +1,58 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2025 Google LLC
> + * Author: Fuad Tabba <fuad.tabba@linux.dev>
> + * Author: Will Deacon <will@kernel.org>
> + */
> +
> +#include "pkvm.h"
> +
> +	.text
> +	.balign 16
> +	.globl	pvm_entry_start
> +pvm_entry_start:
> +	mov	x30, x0
> +
> +	ldr	x0, [x30, #PVM_BOOT_ARGS_OFF_X0]
> +	ldr	x1, [x30, #PVM_BOOT_ARGS_OFF_X1]
> +	ldr	x2, [x30, #PVM_BOOT_ARGS_OFF_X2]
> +	ldr	x3, [x30, #PVM_BOOT_ARGS_OFF_X3]
> +	ldr	x4, [x30, #PVM_BOOT_ARGS_OFF_X4]
> +	ldr	x5, [x30, #PVM_BOOT_ARGS_OFF_X5]
> +	ldr	x6, [x30, #PVM_BOOT_ARGS_OFF_X6]
> +	ldr	x7, [x30, #PVM_BOOT_ARGS_OFF_X7]
> +
> +	ldr	x8, [x30, #PVM_BOOT_ARGS_OFF_JUMP_TGT]
> +
> +	ldr	x9, [x30, #PVM_BOOT_ARGS_OFF_CPACR_EL1]
> +	msr	cpacr_el1, x9
> +
> +	ldr	x9, [x30, #PVM_BOOT_ARGS_OFF_TCR_EL1]
> +	msr	tcr_el1, x9
> +
> +	ldr	x9, [x30, #PVM_BOOT_ARGS_OFF_MAIR_EL1]
> +	msr	mair_el1, x9
> +
> +	ldr	x9, [x30, #PVM_BOOT_ARGS_OFF_TTBR0_EL1]
> +	msr	ttbr0_el1, x9
> +
> +	ldr	x9, [x30, #PVM_BOOT_ARGS_OFF_VBAR_EL1]
> +	msr	vbar_el1, x9
> +
> +	ldr	x9, [x30, #PVM_BOOT_ARGS_OFF_TPIDR_EL1]
> +	msr	tpidr_el1, x9
> +
> +	ldr	x9, [x30, #PVM_BOOT_ARGS_OFF_SP_EL1]
> +	mov	sp, x9
> +
> +	/* No stale TLB entries, and the writes above in effect, before the MMU is on. */
> +	tlbi	vmalle1
> +	dsb	nsh
> +	isb
> +	ldr	x9, [x30, #PVM_BOOT_ARGS_OFF_SCTLR_EL1]
> +	msr	sctlr_el1, x9
> +	isb
> +
> +	br	x8
> +	.globl	pvm_entry_end
> +pvm_entry_end:
> -- 
> 2.47.3
> 

  reply	other threads:[~2026-11-05 13:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  8:48 [PATCH 00/16] KVM: arm64: selftests: Tests for protected VMs Fuad Tabba
2026-11-04  8:48 ` [PATCH 01/16] KVM: arm64: selftests: Inject an abort before a vCPU's first run Fuad Tabba
2026-11-04  8:48 ` [PATCH 02/16] KVM: selftests: Allow arm64 tests to create protected VMs Fuad Tabba
2026-11-05 12:16   ` Joey Gouly
2026-11-04  8:48 ` [PATCH 03/16] tools: arm-smccc: Add the pKVM memory sharing function IDs Fuad Tabba
2026-11-04  8:48 ` [PATCH 04/16] KVM: selftests: Export the ucall pool's guest physical address Fuad Tabba
2026-11-04  8:48 ` [PATCH 05/16] KVM: arm64: selftests: Add protected-VM boot trampoline Fuad Tabba
2026-11-05 13:34   ` Joey Gouly [this message]
2026-11-04  8:48 ` [PATCH 06/16] KVM: arm64: selftests: Add protected-VM library helpers Fuad Tabba
2026-11-04  8:48 ` [PATCH 07/16] KVM: arm64: selftests: Add pkvm_host_abi host-interface test Fuad Tabba
2026-11-04  8:48 ` [PATCH 08/16] KVM: arm64: selftests: Add pkvm_psci multi-vCPU PSCI test Fuad Tabba
2026-11-04  8:48 ` [PATCH 09/16] KVM: arm64: selftests: Add pkvm_mem_share hypercall test Fuad Tabba
2026-11-04  8:48 ` [PATCH 10/16] KVM: arm64: selftests: Add pkvm_smccc " Fuad Tabba
2026-11-04  8:48 ` [PATCH 11/16] KVM: arm64: selftests: Add pkvm_id_regs register and trap test Fuad Tabba
2026-11-04  8:48 ` [PATCH 12/16] KVM: arm64: selftests: Add pkvm_vcpu_regs register-state test Fuad Tabba
2026-11-04  8:48 ` [PATCH 13/16] KVM: arm64: selftests: Add pkvm_irq interrupt test Fuad Tabba
2026-11-04  8:48 ` [PATCH 14/16] KVM: arm64: selftests: Add pkvm_isolation host-access test Fuad Tabba
2026-11-04  8:48 ` [PATCH 15/16] KVM: arm64: selftests: Add pkvm_lifecycle teardown test Fuad Tabba
2026-11-04  8:48 ` [PATCH 16/16] KVM: arm64: selftests: Add pkvm_exceptions debug and SError test Fuad Tabba
2026-11-04 14:10 ` [PATCH 00/16] KVM: arm64: selftests: Tests for protected VMs Joey Gouly
2026-11-04 19:38   ` Fuad Tabba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auyF0ePpUlJKZgNo@e143914.arm.com \
    --to=joey.gouly@arm.com \
    --cc=fuad.tabba@linux.dev \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qperret@google.com \
    --cc=seanjc@google.com \
    --cc=seiden@linux.ibm.com \
    --cc=shuah@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=vdonnefort@google.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®