From: Stefano Radaelli <stefano.radaelli21@gmail.com>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: Frank Li <Frank.Li@nxp.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
pierluigi.p@variscite.com, Nate.D@variscite.com,
Stefano Radaelli <stefano.r@variscite.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v1 1/1] arm64: dts: freescale: Move Variscite Ethernet LEDs to carrier boards
Date: Thu, 5 Nov 2026 18:44:39 +0100 [thread overview]
Message-ID: <auzAh7404GAsY-U0@Lord-Beerus.station> (raw)
In-Reply-To: <auy-OW_td7N8oHK_@SMW015318>
On Thu, Nov 05, 2026 at 11:34:49AM -0600, Frank Li wrote:
> On Thu, Nov 05, 2026 at 11:17:39AM +0100, Stefano Radaelli wrote:
> > From: Stefano Radaelli <stefano.r@variscite.com>
> >
> > The Ethernet LEDs are physically on the carrier boards, but the
> > VAR-SOM-MX8MP, DART-MX91, VAR-SOM-MX93 and DART-MX95 module descriptions
> > include their LED nodes. Other carriers therefore inherit LED definitions
> > that may not match their wiring.
>
> what's impact?
>
Hi Frank,
There are two main points:
1. The SOM dtsi is intended to be reused with different carriers.
Defining the LEDs there forces every carrier to inherit the reference
board’s LED configuration. Customers then have to override those
definitions or explicitly delete the LED nodes if their carrier has no LEDs.
Keeping the definitions in the carrier DTS avoids requiring customers
to undo configuration for hardware that is not part of the SoM.
2. The Ethernet connectors, LEDs and their wiring are on the carrier.
Their definitions therefore belong in the carrier DTS, while the SOM dtsi
should describe the hardware on the module.
This change makes that separation consistent across our boards.
There is no functional change for the existing Symphony and Sonata boards:
their final device trees retain the same LED configuration.
Thank you Frank,
Best Regards,
Stefano
next prev parent reply other threads:[~2026-11-05 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 10:17 Stefano Radaelli
2026-11-05 17:34 ` Frank Li
2026-11-05 17:44 ` Stefano Radaelli [this message]
2026-11-05 17:53 ` Frank Li
2026-11-05 17:56 ` Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auzAh7404GAsY-U0@Lord-Beerus.station \
--to=stefano.radaelli21@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.li@oss.nxp.com \
--cc=Nate.D@variscite.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierluigi.p@variscite.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefano.r@variscite.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®