mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
To: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
Cc: "Pandey, Radhey Shyam" <radheys@amd.com>,
	jassisinghbrar@gmail.com, michal.simek@amd.com,
	tanmay.shah@amd.com, saeed.nowshadi@amd.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	ssengar@linux.microsoft.com, tgopinath@linux.microsoft.com,
	tglx@linutronix.de
Subject: Re: [PATCH 1/2] mailbox: zynqmp-ipi: Fix CPU hotplug state cleanup
Date: Wed, 18 Nov 2026 11:38:14 +0530	[thread overview]
Message-ID: <av1Azk3TNy05J-Z3@csail.mit.edu> (raw)
In-Reply-To: <439409ae-bd42-459e-9c0d-21fc5629f635@linux.microsoft.com>

On Wed, Nov 04, 2026 at 04:51:28PM +0530, Prasanna Kumar T S M wrote:
> Hi Radhey Shyam,
> 
> Thanks for reviewing this.
> 
> On 04-11-2026 11:23, Pandey, Radhey Shyam wrote:
> > On 11/3/2026 11:50 AM, Prasanna Kumar T S M wrote:
> > > On driver removal, the CPUHP_AP_ONLINE_DYN CPU hotplug state is removed
> > > instead of the its actual state. This can leave the mailbox driver
> > > callbacks dangling. Use the actual CPU hotplug state during driver
> > > removal.
> > > 
> > > Hotplug registration failures are also ignored, allowing probe to
> > > succeed without the callbacks needed to enable interrupts on CPUs
> > > brought online later.
> > > 

[...]

> > > @@ -863,15 +864,22 @@ static int xlnx_mbox_init_sgi(struct
> > > platform_device *pdev,
> > >       irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU);
> > >       /* Setup function for the CPU hot-plug cases */
> > > -    cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "mailbox/sgi:starting",
> > > -              xlnx_mbox_cpuhp_start, xlnx_mbox_cpuhp_down);
> > > +    pdata->hp_state = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
> > > +              "mailbox/sgi:starting", xlnx_mbox_cpuhp_start,
> > 
> > what is :starting here ?
> 
> I used the existing string.

Let's please fix it while we are at it. The convention is to match the
mode in the @name argument to the CPU hotplug state that it is
associated with. So in this case, :online would be the right one to
use instead of :starting.

Also, could you consider editing the names of the callbacks for
symmetry? Ex: We can rename them to xlnx_mbox_cpuhp_startup() and
xlnx_mbox_cpuhp_teardown() instead of _start() and _down() that are
used today.

Regards,
Srivatsa

  reply	other threads:[~2026-11-18  6:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  6:20 Prasanna Kumar T S M
2026-11-03  6:35 ` [PATCH 2/2] soc: xilinx: Fix event manager " Prasanna Kumar T S M
2026-11-03 12:26   ` Jay Buddhabhatti
2026-11-03 15:18     ` Prasanna Kumar T S M
2026-11-18  6:33   ` Srivatsa S. Bhat
2026-11-03 16:05 ` [PATCH 1/2] mailbox: zynqmp-ipi: Fix " kernel test robot
2026-11-04  5:53 ` Pandey, Radhey Shyam
2026-11-04 11:21   ` Prasanna Kumar T S M
2026-11-18  6:08     ` Srivatsa S. Bhat [this message]
2026-11-18  6:19   ` Srivatsa S. Bhat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av1Azk3TNy05J-Z3@csail.mit.edu \
    --to=srivatsa@csail.mit.edu \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=ptsm@linux.microsoft.com \
    --cc=radheys@amd.com \
    --cc=saeed.nowshadi@amd.com \
    --cc=ssengar@linux.microsoft.com \
    --cc=tanmay.shah@amd.com \
    --cc=tglx@linutronix.de \
    --cc=tgopinath@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®