From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Volodymyr Chapman <volodymyrchapman@gmail.com>
Cc: lee@kernel.org, pavel@kernel.org, griffin@kroah.com,
hansg@kernel.org, andy@kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: flash: Add driver for the TI LM3554
Date: Wed, 18 Nov 2026 09:32:18 +0200 [thread overview]
Message-ID: <av1Ugv6BQYC3PS4Q@ashevche-desk.local> (raw)
In-Reply-To: <20261117175745.11897-1-volodymyrchapman@gmail.com>
On Tue, Nov 17, 2026 at 05:57:45PM +0000, Volodymyr Chapman wrote:
> Hi Lee, Pavel,
>
> Andy Shevchenko pointed out, in review of a related camera series, that
> drivers/leds/leds-lm355x.c already lists the LM3554. I should have
> mentioned it in the commit message.
>
> It can't be used on the Lenovo ThinkPad 10 as it is: it only probes with
> platform data (no ACPI or DT matching, and nothing in the tree provides
> the platform data), it does not drive the HWEN enable line, which has to
> be raised here before the chip responds, and it registers three plain
> LED class devices rather than a flash LED class device, so there is no
> flash timeout or fault reporting.
>
> This patch follows commit f1aa35ab5943 ("media: atomisp: Drop the
> atomisp custom lm3554 flash driver"), which removed the atomisp-specific
> LM3554 driver for the same hardware and said that it should be
> re-implemented with the led-class-flash API if needed.
>
> Would you prefer a separate flash class driver for the LM3554 as in this
> patch, or extending leds-lm355x (fwnode/ACPI matching, the enable GPIO
> and the flash class)? I'll do whichever you prefer in v2, together with
> the fixes for the issues the Sashiko review found.
Since lm355x has no fwnode support, I think we have no users for it
in kernel (there are no users of platform data either).
I would move the driver to the flash subfolder (and rename it back to lm3556
as all those 'x' variants showed quite a confusion for the users and developers
as we noticed in IIO and have now even requirement to not make any driver names
with wildcard in it) and develop necessary support.
Also the documentation Documentation/leds/leds-lm3556.rst needs to be amended.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-18 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 18:08 Volodymyr Chapman
2026-11-17 14:14 ` Uwe Kleine-König
2026-11-17 17:57 ` Volodymyr Chapman
2026-11-18 7:32 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av1Ugv6BQYC3PS4Q@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=griffin@kroah.com \
--cc=hansg@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=volodymyrchapman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®