mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Cheng <icheng@nvidia.com>
To: "Gregory Price (Meta)" <gourry@gourry.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com,  linux-doc@vger.kernel.org,
	driver-core@lists.linux.dev, linux-serial@vger.kernel.org,
	 linux-pm@vger.kernel.org, damon@lists.linux.dev,
	linux-cxl@vger.kernel.org,  akpm@linux-foundation.org,
	david@kernel.org, liam@infradead.org, vbabka@kernel.org,
	 rppt@kernel.org, surenb@google.com, mhocko@suse.com,
	corbet@lwn.net,  skhan@linuxfoundation.org,
	rdunlap@infradead.org, gregkh@linuxfoundation.org,
	 rafael@kernel.org, dakr@kernel.org, johan@kernel.org,
	jirislaby@kernel.org,  kasong@tencent.com, qi.zheng@linux.dev,
	shakeel.butt@linux.dev, baohua@kernel.org,
	 axelrasmussen@google.com, yuanchu@google.com,
	weixugc@google.com, baoquan.he@linux.dev,
	 baolin.wang@linux.alibaba.com, yury.norov@gmail.com,
	linux@rasmusvillemoes.dk, pavel@kernel.org,  lenb@kernel.org,
	hannes@cmpxchg.org, brendan.jackman@linux.dev, ziy@nvidia.com,
	 sj@kernel.org, muchun.song@linux.dev, osalvador@suse.de,
	nico.pache@linux.dev,  ryan.roberts@arm.com, dev.jain@arm.com,
	lance.yang@linux.dev, usama.arif@linux.dev,  kas@kernel.org,
	xu.xin@linux.dev, chengming.zhou@linux.dev,
	 joshua.hahnjy@gmail.com, rakie.kim@sk.com,
	ying.huang@linux.alibaba.com,  matthew.brost@intel.com,
	byungchul@sk.com, apopple@nvidia.com, rientjes@google.com
Subject: Re: [PATCH 02/22] mm: publish and clear node memory states via helpers
Date: Wed, 18 Nov 2026 15:53:54 +0800	[thread overview]
Message-ID: <av1ZBTpLpJC6DJqA@MWDK4CY14F> (raw)
In-Reply-To: <20261114070959.3490008-3-gourry@gourry.net>

On Sat, Nov 14, 2026 at 02:09:39AM +0800, Gregory Price (Meta) wrote:
> N_MEMORY, N_NORMAL_MEMORY and N_HIGH_MEMORY are set separately in
> free_area_init(), check_for_memory() and online_pages(), and cleared
> in offline_pages().
> 
> Centralize those updates in node_set/clear_memory_state().
> 
> Behavior is unchanged.
> 
> Signed-off-by: Gregory Price (Meta) <gourry@gourry.net>
> ---
>  mm/internal.h       |  3 +++
>  mm/memory_hotplug.c | 11 ++++-------
>  mm/mm_init.c        | 14 ++++++--------
>  mm/page_alloc.c     | 15 +++++++++++++++
>  4 files changed, 28 insertions(+), 15 deletions(-)
> 
> diff --git a/mm/internal.h b/mm/internal.h
> index cd3675c044e0a..608a83c34c224 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -62,6 +62,9 @@ void lru_add_drain_cpu_zone(struct zone *zone);
>  void folio_deactivate(struct folio *folio);
>  void folio_mark_lazyfree(struct folio *folio);
>  
> +void node_set_memory_state(int nid, bool high, bool normal);
> +void node_clear_memory_state(int nid);
> +
>  /* mm/vmscan.c */
>  unsigned long zone_reclaimable_pages(struct zone *zone);
>  unsigned long try_to_free_pages(struct zonelist *zonelist, int order,
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index f04a248d8adaf..490f400498f14 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1184,14 +1184,11 @@ int online_pages(unsigned long pfn, unsigned long nr_pages,
>  	online_pages_range(pfn, nr_pages);
>  	adjust_present_page_count(pfn_to_page(pfn), group, nr_pages);
>  
> -	if (node_arg.nid >= 0)
> -		node_set_state(nid, N_MEMORY);
>  	/*
> -	 * Check whether we are adding normal memory to the node for the first
> -	 * time.
> +	 * Publish this node's memory states, including any newly-normal zone.
> +	 * Hotplug never adds highmem.
>  	 */
> -	if (!node_state(nid, N_NORMAL_MEMORY) && zone_idx(zone) <= ZONE_NORMAL)
> -		node_set_state(nid, N_NORMAL_MEMORY);
> +	node_set_memory_state(nid, false, zone_idx(zone) <= ZONE_NORMAL);
> 

Um, so I am not sure how much cache pressure this will add, I assume it's small ?

Just want to point out that the old code only wrote these bits for a node's first
memory. THis now does up to 3 set_bit() calls on node_states[] for every onlined block.
The result is the same, but node_states[] is __read_mostly. A test-before-set in the helper
would keep the old behavior, or if you would like to keep it, please address in commit message.

Best regards,
Richard Cheng.


>  	if (need_zonelists_rebuild)
>  		build_all_zonelists(NULL);
> @@ -2146,7 +2143,7 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages,
>  	 * list. Otherwise this node would still appear in the fallback lists.
>  	 */
>  	if (node_arg.nid >= 0)
> -		node_clear_state(node, N_MEMORY);
> +		node_clear_memory_state(node);
>  	if (!populated_zone(zone)) {
>  		zone_pcp_reset(zone);
>  		build_all_zonelists(NULL);
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a9d848c92678b..b4c4dba93652d 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1763,21 +1763,21 @@ static void __init free_area_init_node(int nid)
>  	lru_gen_init_pgdat(pgdat);
>  }
>  
> -/* Any regular or high memory on that node? */
> +/* Publish the memory states of a node that has present pages. */
>  static void __init check_for_memory(pg_data_t *pgdat)
>  {
>  	enum zone_type zone_type;
> +	bool high = false, normal = false;
>  
>  	for (zone_type = 0; zone_type <= ZONE_MOVABLE - 1; zone_type++) {
>  		struct zone *zone = &pgdat->node_zones[zone_type];
>  		if (populated_zone(zone)) {
> -			if (IS_ENABLED(CONFIG_HIGHMEM))
> -				node_set_state(pgdat->node_id, N_HIGH_MEMORY);
> -			if (zone_type <= ZONE_NORMAL)
> -				node_set_state(pgdat->node_id, N_NORMAL_MEMORY);
> +			high = IS_ENABLED(CONFIG_HIGHMEM);
> +			normal = zone_type <= ZONE_NORMAL;
>  			break;
>  		}
>  	}
> +	node_set_memory_state(pgdat->node_id, high, normal);
>  }
>  
>  #if MAX_NUMNODES > 1
> @@ -1924,10 +1924,8 @@ static void __init free_area_init(void)
>  		 *memory-less node. The pgdat will get fully initialized by
>  		 *hotadd_init_pgdat() when memory is hotplugged into this node.
>  		 */
> -		if (pgdat->node_present_pages) {
> -			node_set_state(nid, N_MEMORY);
> +		if (pgdat->node_present_pages)
>  			check_for_memory(pgdat);
> -		}
>  	}
>  
>  	calc_nr_kernel_pages();
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 8532af052d74b..834d199ff8429 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -208,6 +208,21 @@ nodemask_t node_states[NR_NODE_STATES] __read_mostly = {
>  };
>  EXPORT_SYMBOL(node_states);
>  
> +void __meminit node_set_memory_state(int nid, bool high, bool normal)
> +{
> +	node_set_state(nid, N_MEMORY);
> +	if (high)
> +		node_set_state(nid, N_HIGH_MEMORY);
> +	if (normal)
> +		node_set_state(nid, N_NORMAL_MEMORY);
> +}
> +
> +void __meminit node_clear_memory_state(int nid)
> +{
> +	node_clear_state(nid, N_NORMAL_MEMORY);
> +	node_clear_state(nid, N_MEMORY);
> +}
> +
>  gfp_t gfp_allowed_mask __read_mostly = GFP_BOOT_MASK;
>  
>  #ifdef CONFIG_HUGETLB_PAGE_SIZE_VARIABLE
> -- 
> 2.53.1-Meta
> 
> 

  reply	other threads:[~2026-11-18  7:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14  7:09 [PATCH 00/22] mm: introduce N_MEMORY_COMMON Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 01/22] mm: add node-state-filtered zone and node iterators Gregory Price (Meta)
2026-11-18  8:29   ` Richard Cheng
2026-11-14  7:09 ` [PATCH 02/22] mm: publish and clear node memory states via helpers Gregory Price (Meta)
2026-11-18  7:53   ` Richard Cheng [this message]
2026-11-14  7:09 ` [PATCH 03/22] mm: introduce the common-memory node state Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 04/22] mm/page_alloc: build zonelists from common memory Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 05/22] mm/mempolicy: keep interleave and tmpfs mount policies on " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 06/22] mm: base hash distribution on common memory nodes Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 07/22] mm/memory_hotplug: migrate offlined pages to common memory Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 08/22] mm/memory-tiers: restrict demotion topology " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 09/22] mm/ksm: restrict merging " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 10/22] mm/khugepaged: restrict collapse " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 11/22] mm/mempolicy: don't NUMA-hint folios outside " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 12/22] mm/damon: restrict DAMON-native folio operations to " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 13/22] mm/hugetlb: restrict pool growth " Gregory Price (Meta)
2026-11-18  7:32   ` Richard Cheng
2026-11-14  7:09 ` [PATCH 14/22] mm/page_alloc: count common memory nodes for kswapd recovery Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 15/22] mm/oom_kill: compare OOM constraints against common memory Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 16/22] tty/sysrq: use common memory for the manual OOM zonelist Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 17/22] mm/vmscan: restrict reclaim to common memory Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 18/22] mm/compaction: restrict compaction " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 19/22] mm/migrate: restrict move_pages() destinations " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 20/22] PM: hibernate: size the image from " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 21/22] mm/khugepaged: base the recommended min_free_kbytes on " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 22/22] nodemask: remove the now-unused first_memory_node/next_memory_node Gregory Price (Meta)
2026-11-18  7:01 ` [PATCH 00/22] mm: introduce N_MEMORY_COMMON Richard Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av1ZBTpLpJC6DJqA@MWDK4CY14F \
    --to=icheng@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baoquan.he@linux.dev \
    --cc=brendan.jackman@linux.dev \
    --cc=byungchul@sk.com \
    --cc=chengming.zhou@linux.dev \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gourry@gourry.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kas@kernel.org \
    --cc=kasong@tencent.com \
    --cc=kernel-team@meta.com \
    --cc=lance.yang@linux.dev \
    --cc=lenb@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=matthew.brost@intel.com \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=nico.pache@linux.dev \
    --cc=osalvador@suse.de \
    --cc=pavel@kernel.org \
    --cc=qi.zheng@linux.dev \
    --cc=rafael@kernel.org \
    --cc=rakie.kim@sk.com \
    --cc=rdunlap@infradead.org \
    --cc=rientjes@google.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=shakeel.butt@linux.dev \
    --cc=sj@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=weixugc@google.com \
    --cc=xu.xin@linux.dev \
    --cc=ying.huang@linux.alibaba.com \
    --cc=yuanchu@google.com \
    --cc=yury.norov@gmail.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®