From: Richard Cheng <icheng@nvidia.com>
To: "Gregory Price (Meta)" <gourry@gourry.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, linux-doc@vger.kernel.org,
driver-core@lists.linux.dev, linux-serial@vger.kernel.org,
linux-pm@vger.kernel.org, damon@lists.linux.dev,
linux-cxl@vger.kernel.org, akpm@linux-foundation.org,
david@kernel.org, liam@infradead.org, vbabka@kernel.org,
rppt@kernel.org, surenb@google.com, mhocko@suse.com,
corbet@lwn.net, skhan@linuxfoundation.org,
rdunlap@infradead.org, gregkh@linuxfoundation.org,
rafael@kernel.org, dakr@kernel.org, johan@kernel.org,
jirislaby@kernel.org, kasong@tencent.com, qi.zheng@linux.dev,
shakeel.butt@linux.dev, baohua@kernel.org,
axelrasmussen@google.com, yuanchu@google.com,
weixugc@google.com, baoquan.he@linux.dev,
baolin.wang@linux.alibaba.com, yury.norov@gmail.com,
linux@rasmusvillemoes.dk, pavel@kernel.org, lenb@kernel.org,
hannes@cmpxchg.org, brendan.jackman@linux.dev, ziy@nvidia.com,
sj@kernel.org, muchun.song@linux.dev, osalvador@suse.de,
nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com,
lance.yang@linux.dev, usama.arif@linux.dev, kas@kernel.org,
xu.xin@linux.dev, chengming.zhou@linux.dev,
joshua.hahnjy@gmail.com, rakie.kim@sk.com,
ying.huang@linux.alibaba.com, matthew.brost@intel.com,
byungchul@sk.com, apopple@nvidia.com, rientjes@google.com
Subject: Re: [PATCH 01/22] mm: add node-state-filtered zone and node iterators
Date: Wed, 18 Nov 2026 16:29:37 +0800 [thread overview]
Message-ID: <av1hKrtcATVjCnCM@MWDK4CY14F> (raw)
In-Reply-To: <20261114070959.3490008-2-gourry@gourry.net>
On Sat, Nov 14, 2026 at 02:09:38AM +0800, Gregory Price (Meta) wrote:
> Add node-state-filter helper functions/macros so MM walkers can select
> their node eligibility explicitly.
>
> Add nodemask intersection and nodemask/state iterators using the bitmap
> intersection helpers, without allocating a temporary nodemask.
>
> Signed-off-by: Gregory Price (Meta) <gourry@gourry.net>
> ---
> include/linux/mmzone.h | 46 ++++++++++++++++++++++++++++++++++++++++
> include/linux/nodemask.h | 28 ++++++++++++++++++++----
> 2 files changed, 70 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index c161d563ce8fd..5ff190d870830 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1845,6 +1845,13 @@ extern struct zone *next_zone(struct zone *zone);
> ; /* do nothing */ \
> else
>
> +/* Populated zones on nodes in @state. */
> +#define for_each_populated_zone_state(zone, state) \
> + for_each_populated_zone(zone) \
> + if (!node_state(zone_to_nid(zone), state)) \
> + ; /* do nothing */ \
> + else
> +
> static inline struct zone *zonelist_zone(struct zoneref *zoneref)
> {
> return zoneref->zone;
> @@ -1937,6 +1944,45 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist,
> zone = zonelist_zone(z))
>
>
> +static inline struct zoneref *
> +next_zones_zonelist_state(struct zoneref *z, enum zone_type highest_zoneidx,
> + const nodemask_t *nodes, enum node_states state)
> +{
> + z = next_zones_zonelist(z, highest_zoneidx, nodes);
> + while (zonelist_zone(z) && !node_state(zonelist_node_idx(z), state))
> + z = next_zones_zonelist(++z, highest_zoneidx, nodes);
> + return z;
> +}
> +
> +static inline struct zoneref *
> +first_zones_zonelist_state(struct zonelist *zonelist,
> + enum zone_type highest_zoneidx,
> + const nodemask_t *nodes, enum node_states state)
> +{
> + return next_zones_zonelist_state(zonelist->_zonerefs, highest_zoneidx,
> + nodes, state);
> +}
> +
> +/**
> + * for_each_zone_node_state - iterate zones in intersect(nodemask, node_state(state))
> + * @zone: The current zone in the iterator
> + * @z: The current pointer within zonelist->_zonerefs being iterated
> + * @zlist: The zonelist being iterated
> + * @highidx: The zone index of the highest zone to return
> + * @nodemask: Nodemask allowed by the allocator
> + * @state: The node state the zone's node must be in
> + *
> + * The state filter is part of the iteration rather than a trailing if, so that
> + * this expands to a single for statement: a macro ending in an unbraced if
> + * silently steals a following else from the caller.
> + */
> +#define for_each_zone_node_state(zone, z, zlist, highidx, nodemask, state) \
> + for (z = first_zones_zonelist_state(zlist, highidx, nodemask, state), \
> + zone = zonelist_zone(z); \
> + zone; \
> + z = next_zones_zonelist_state(++z, highidx, nodemask, state), \
> + zone = zonelist_zone(z))
> +
A question on consistency. This one is a single for statement, with 2 new helper functions.
for_each_populated_zone_state() in the same patch uses "if (!cond) ; else" form instead.
Both forms keep a caller's else correct. The only difference I can find is that the if/else
form give a -Wdangling-else warning when the loop is the unbraced body of an if.
Is that the reason for the 2 helper function here? If the warning doesn't matter, this could
use the same short form and drop the 2 functions. If it does matter, should
for_each_populated_zone_state() be a single statement too ?
Best regards,
Richard Cheng.
> /**
> * for_each_zone_zonelist - helper macro to iterate over valid zones in a zonelist at or below a given zone index
> * @zone: The current zone in the iterator
> diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
> index 607373bd83ee6..28a456c3f5964 100644
> --- a/include/linux/nodemask.h
> +++ b/include/linux/nodemask.h
> @@ -386,6 +386,10 @@ static __always_inline void __nodes_fold(nodemask_t *dstp, const nodemask_t *ori
> for ((node) = 0; (node) < 1 && !nodes_empty(mask); (node)++)
> #endif /* MAX_NUMNODES */
>
> +/* Iterate the nodes present in both masks without a temporary nodemask. */
> +#define for_each_node_mask_and(node, mask1, mask2) \
> + for_each_and_bit(node, nodes_addr(mask1), nodes_addr(mask2), MAX_NUMNODES)
> +
> /*
> * Bitmasks that are kept for all the nodes.
> */
> @@ -411,6 +415,10 @@ enum node_states {
>
> extern nodemask_t node_states[NR_NODE_STATES];
>
> +/* Iterate the nodes in a mask that also belong to the specified state. */
> +#define for_each_node_mask_state(node, mask, state) \
> + for_each_node_mask_and(node, mask, node_states[state])
> +
> #if MAX_NUMNODES > 1
> static __always_inline int node_state(int node, enum node_states state)
> {
> @@ -435,15 +443,21 @@ static __always_inline int num_node_state(enum node_states state)
> #define for_each_node_state(__node, __state) \
> for_each_node_mask((__node), node_states[__state])
>
> -#define first_online_node first_node(node_states[N_ONLINE])
> -#define first_memory_node first_node(node_states[N_MEMORY])
> +#define first_node_state(state) first_node(node_states[state])
> +static __always_inline unsigned int next_node_state(int nid, enum node_states state)
> +{
> + return next_node(nid, node_states[state]);
> +}
> +
> +#define first_online_node first_node_state(N_ONLINE)
> +#define first_memory_node first_node_state(N_MEMORY)
> static __always_inline unsigned int next_online_node(int nid)
> {
> - return next_node(nid, node_states[N_ONLINE]);
> + return next_node_state(nid, N_ONLINE);
> }
> static __always_inline unsigned int next_memory_node(int nid)
> {
> - return next_node(nid, node_states[N_MEMORY]);
> + return next_node_state(nid, N_MEMORY);
> }
>
> static __always_inline void node_set_online(int nid)
> @@ -481,6 +495,12 @@ static __always_inline int num_node_state(enum node_states state)
> #define for_each_node_state(node, __state) \
> for ( (node) = 0; (node) == 0; (node) = 1)
>
> +#define first_node_state(state) 0
> +static __always_inline unsigned int next_node_state(int nid, enum node_states state)
> +{
> + return MAX_NUMNODES;
> +}
> +
> #define first_online_node 0
> #define first_memory_node 0
> #define next_online_node(nid) (MAX_NUMNODES)
> --
> 2.53.1-Meta
>
>
next prev parent reply other threads:[~2026-11-18 8:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 7:09 [PATCH 00/22] mm: introduce N_MEMORY_COMMON Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 01/22] mm: add node-state-filtered zone and node iterators Gregory Price (Meta)
2026-11-18 8:29 ` Richard Cheng [this message]
2026-11-14 7:09 ` [PATCH 02/22] mm: publish and clear node memory states via helpers Gregory Price (Meta)
2026-11-18 7:53 ` Richard Cheng
2026-11-14 7:09 ` [PATCH 03/22] mm: introduce the common-memory node state Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 04/22] mm/page_alloc: build zonelists from common memory Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 05/22] mm/mempolicy: keep interleave and tmpfs mount policies on " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 06/22] mm: base hash distribution on common memory nodes Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 07/22] mm/memory_hotplug: migrate offlined pages to common memory Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 08/22] mm/memory-tiers: restrict demotion topology " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 09/22] mm/ksm: restrict merging " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 10/22] mm/khugepaged: restrict collapse " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 11/22] mm/mempolicy: don't NUMA-hint folios outside " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 12/22] mm/damon: restrict DAMON-native folio operations to " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 13/22] mm/hugetlb: restrict pool growth " Gregory Price (Meta)
2026-11-18 7:32 ` Richard Cheng
2026-11-14 7:09 ` [PATCH 14/22] mm/page_alloc: count common memory nodes for kswapd recovery Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 15/22] mm/oom_kill: compare OOM constraints against common memory Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 16/22] tty/sysrq: use common memory for the manual OOM zonelist Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 17/22] mm/vmscan: restrict reclaim to common memory Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 18/22] mm/compaction: restrict compaction " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 19/22] mm/migrate: restrict move_pages() destinations " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 20/22] PM: hibernate: size the image from " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 21/22] mm/khugepaged: base the recommended min_free_kbytes on " Gregory Price (Meta)
2026-11-14 7:09 ` [PATCH 22/22] nodemask: remove the now-unused first_memory_node/next_memory_node Gregory Price (Meta)
2026-11-18 7:01 ` [PATCH 00/22] mm: introduce N_MEMORY_COMMON Richard Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av1hKrtcATVjCnCM@MWDK4CY14F \
--to=icheng@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=baoquan.he@linux.dev \
--cc=brendan.jackman@linux.dev \
--cc=byungchul@sk.com \
--cc=chengming.zhou@linux.dev \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=damon@lists.linux.dev \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=driver-core@lists.linux.dev \
--cc=gourry@gourry.net \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=joshua.hahnjy@gmail.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=lenb@kernel.org \
--cc=liam@infradead.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=matthew.brost@intel.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=nico.pache@linux.dev \
--cc=osalvador@suse.de \
--cc=pavel@kernel.org \
--cc=qi.zheng@linux.dev \
--cc=rafael@kernel.org \
--cc=rakie.kim@sk.com \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=sj@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=xu.xin@linux.dev \
--cc=ying.huang@linux.alibaba.com \
--cc=yuanchu@google.com \
--cc=yury.norov@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®