mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Shivani Patel <patelshivani2283@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
	Christian Gromm <christian.gromm@microchip.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH v3 1/2] staging: most: video: Protect pending_mbos and mute with list_lock
Date: Wed, 18 Nov 2026 13:22:41 +0200	[thread overview]
Message-ID: <av2KgdP5EuLamxpe@ashevche-desk.local> (raw)
In-Reply-To: <av1t4DbqGsmUmrZJ@stanley.mountain>

On Wed, Nov 18, 2026 at 12:20:32PM +0300, Dan Carpenter wrote:
> On Tue, Nov 17, 2026 at 10:35:57PM +0530, Shivani Patel wrote:
> > data_ready() and get_top_mbo() read mdev->pending_mbos without holding
> > mdev->list_lock, racing with comp_rx_data() which modifies the list
> > under mdev->list_lock. Also, comp_vdev_close() clears mdev->mute without
> > holding mdev->list_lock.
> > 
> > Acquire mdev->list_lock in data_ready(), get_top_mbo(), and when
> > clearing mdev->mute in comp_vdev_close(). Use list_first_entry_or_null()
> > in get_top_mbo() so comp_vdev_read() can drop the redundant data_ready()
> > check inside the read loop.

...

> > -static inline bool data_ready(struct most_video_dev *mdev)
> > +static bool data_ready(struct most_video_dev *mdev)
> >  {
> > -	return !list_empty(&mdev->pending_mbos);
> > +	unsigned long flags;
> > +	bool ready;
> > +
> > +	spin_lock_irqsave(&mdev->list_lock, flags);
> > +	ready = !list_empty(&mdev->pending_mbos);
> > +	spin_unlock_irqrestore(&mdev->list_lock, flags);
> > +
> > +	return ready;
> 
> It doesn't really matter if we take the lock where since we drop it
> right away.  The list_empty() doesn't anything that requires locking
> so far as I can see.

Right, but the problem is that we possibly might compare valid pointer
(list head itself) with the stale pointer (head->next and/or head->prev).
Also don't forget that for 8-byte pointers on some architectures it
might be the cross-boundary split (most likely won't happen with struct
list_head as it should be at least 8-byte aligned, but still).

> >  }

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-18 11:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 17:05 Shivani Patel
2026-11-17 17:05 ` [PATCH v3 2/2] staging: most: video: Document locks in struct most_video_dev Shivani Patel
2026-11-18  9:20 ` [PATCH v3 1/2] staging: most: video: Protect pending_mbos and mute with list_lock Dan Carpenter
2026-11-18 11:22   ` Andy Shevchenko [this message]
2026-11-18 12:01     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av2KgdP5EuLamxpe@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=christian.gromm@microchip.com \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=parthiban.veerasooran@microchip.com \
    --cc=patelshivani2283@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®