From: Boqun Feng <boqun@kernel.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: gary@garyguo.net, aliceryhl@google.com, lyude@redhat.com,
daniel.almeida@collabora.com, work@onurozkan.dev,
ojeda@kernel.org, bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, tmgross@umich.edu, tamird@kernel.org,
acourbot@nvidia.com, viro@zeniv.linux.org.uk, brauner@kernel.org,
jack@suse.cz, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] rust: sync: add WaitQueue infrastructure
Date: Wed, 18 Nov 2026 09:23:55 -0800 [thread overview]
Message-ID: <av3fK2ybemq91riD@tardis.local> (raw)
In-Reply-To: <20261117001507.1611984-1-dakr@kernel.org>
On Tue, Nov 17, 2026 at 01:14:41AM +0100, Danilo Krummrich wrote:
> Add a WaitQueue abstraction wrapping struct wait_queue_head, providing
> wait_event()-style methods that take a condition closure directly.
>
> This is needed for a (subsequent) DRM patch series to wait for in-flight file
> close operations during driver unbind. The Tyr driver also needs it for "CSF
> firmware responses and other GPU-driven events" [1].
>
> Convert CondVar (and PollCondVar) to use WaitQueue internally, removing
> duplicate code using WaitQueue as the base primitive and add
> wait_interruptible_freezable_nonexclusive() for subsequent binder usage.
>
> This series is based on FUJITA Tomonori's CondVar timeout conversion [2].
>
> Changes in v3:
> - Use Delta<Jiffy> for timeouts and treat negative durations as zero.
> - Add might_sleep() and caller tracking to the wait_event() methods.
> - Gate the WaitQueue KUnit tests behind a dedicated Kconfig option.
>
> Changes in v2:
> - Drop the already merged workqueue patch.
> - Make as_raw() public.
> - Split error types and use bindings constants for direct C calls.
> - Avoid condition rechecks after success.
> - Check the condition before preparing a waiter.
> - Add non-exclusive wait support, including a CondVar method for subsequent
> Binder conversion.
> - Handle zero and expired timeouts before interruption; extend KUnit coverage.
>
> [1] https://lore.kernel.org/dri-devel/20260721151423.444175-2-laura.nao@collabora.com/
> [2] https://lore.kernel.org/rust-for-linux/20261104235929.1282640-1-tomo@flapping.org/
>
Nice work, thank you!
Acked-by: Boqun Feng <boqun@kernel.org>
Regards,
Boqun
> Danilo Krummrich (5):
> rust: task: add safe schedule_timeout() wrapper
> rust: sync: add WaitQueue infrastructure
> rust: sync: convert CondVar and PollCondVar to use WaitQueue
> rust: sync: condvar: use task::schedule_timeout()
> rust: sync: condvar: add non-exclusive freezable waiting
>
> rust/kernel/Kconfig.test | 10 +
> rust/kernel/sync.rs | 8 +
> rust/kernel/sync/condvar.rs | 154 +++++-----
> rust/kernel/sync/poll.rs | 19 +-
> rust/kernel/sync/wait.rs | 546 ++++++++++++++++++++++++++++++++++++
> rust/kernel/task.rs | 23 ++
> 6 files changed, 664 insertions(+), 96 deletions(-)
> create mode 100644 rust/kernel/sync/wait.rs
>
>
> base-commit: 60fff02883397e17439c16f0e72b2f8c5f6eb791
> --
> 2.56.1
>
prev parent reply other threads:[~2026-11-18 17:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 0:14 Danilo Krummrich
2026-11-17 0:14 ` [PATCH v3 1/5] rust: task: add safe schedule_timeout() wrapper Danilo Krummrich
2026-11-17 0:45 ` FUJITA Tomonori
2026-11-17 11:40 ` Gary Guo
2026-11-17 11:56 ` Danilo Krummrich
2026-11-17 12:02 ` Gary Guo
2026-11-17 13:14 ` Danilo Krummrich
2026-11-17 14:16 ` Alice Ryhl
2026-11-17 0:14 ` [PATCH v3 2/5] rust: sync: add WaitQueue infrastructure Danilo Krummrich
2026-11-17 11:59 ` Gary Guo
2026-11-18 12:22 ` Danilo Krummrich
2026-11-18 12:50 ` Gary Guo
2026-11-17 14:16 ` Alice Ryhl
2026-11-17 0:14 ` [PATCH v3 3/5] rust: sync: convert CondVar and PollCondVar to use WaitQueue Danilo Krummrich
2026-11-17 14:16 ` Alice Ryhl
2026-11-18 10:49 ` Gary Guo
2026-11-17 0:14 ` [PATCH v3 4/5] rust: sync: condvar: use task::schedule_timeout() Danilo Krummrich
2026-11-17 14:16 ` Alice Ryhl
2026-11-17 22:06 ` FUJITA Tomonori
2026-11-18 12:50 ` Gary Guo
2026-11-17 0:14 ` [PATCH v3 5/5] rust: sync: condvar: add non-exclusive freezable waiting Danilo Krummrich
2026-11-17 14:16 ` Alice Ryhl
2026-11-18 10:49 ` Gary Guo
2026-11-18 17:23 ` Boqun Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av3fK2ybemq91riD@tardis.local \
--to=boqun@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=brauner@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®