mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Siqi Chen <chensiqi@uniontech.com>
Cc: nish.malpani25@gmail.com, jic23@kernel.org, nuno.sa@analog.com,
	Michael.Hennerich@analog.com, dlechner@baylibre.com,
	andy@kernel.org, linux-iio@vger.kernel.org, linux@analog.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: gyro: adxrs290: propagate chip ID read errors
Date: Thu, 19 Nov 2026 12:12:50 +0200	[thread overview]
Message-ID: <av7LotsnpvN7lMAF@ashevche-desk.local> (raw)
In-Reply-To: <20261119030709.3792433-1-chensiqi@uniontech.com>

On Thu, Nov 19, 2026 at 11:07:09AM +0800, Siqi Chen wrote:
> spi_w8r8() returns either an unsigned 8-bit value or a negative error.
> The probe function stores its return value in a u8, truncating errors and
> treating them as unexpected chip IDs. Consequently, an SPI transfer failure
> is reported as -ENODEV instead of the actual error.
> 
> Store each result in an int and return negative errors before validating
> the chip IDs.

Starting from here the rest of the commit message should be moved to the
comment block (after '---' line).

> OpenCode was used to identify the issue and draft the code and changelog.
> 
> Compile-tested with CONFIG_ADXRS290=m using:
> 
>   make O=/tmp/opencode/linux-build-adxrs290 W=1 \
>        drivers/iio/gyro/adxrs290.o
> 
> No hardware or SPI fault-injection testing was performed.

...

Code wise seems good to me.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-19 10:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  3:07 Siqi Chen
2026-11-19 10:12 ` Andy Shevchenko [this message]
2026-11-19 10:15 ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av7LotsnpvN7lMAF@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=chensiqi@uniontech.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nish.malpani25@gmail.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®