* [PATCH] iio: gyro: adxrs290: propagate chip ID read errors
@ 2026-11-19 3:07 Siqi Chen
2026-11-19 10:12 ` Andy Shevchenko
2026-11-19 10:15 ` Joshua Crofts
0 siblings, 2 replies; 3+ messages in thread
From: Siqi Chen @ 2026-11-19 3:07 UTC (permalink / raw)
To: nish.malpani25, jic23
Cc: nuno.sa, Michael.Hennerich, dlechner, andy, linux-iio, linux,
linux-kernel, Siqi Chen
spi_w8r8() returns either an unsigned 8-bit value or a negative error.
The probe function stores its return value in a u8, truncating errors and
treating them as unexpected chip IDs. Consequently, an SPI transfer failure
is reported as -ENODEV instead of the actual error.
Store each result in an int and return negative errors before validating
the chip IDs.
OpenCode was used to identify the issue and draft the code and changelog.
Compile-tested with CONFIG_ADXRS290=m using:
make O=/tmp/opencode/linux-build-adxrs290 W=1 \
drivers/iio/gyro/adxrs290.o
No hardware or SPI fault-injection testing was performed.
Fixes: 2c8920fff145 ("iio: gyro: Add driver support for ADXRS290")
Signed-off-by: Siqi Chen <chensiqi@uniontech.com>
---
drivers/iio/gyro/adxrs290.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/drivers/iio/gyro/adxrs290.c b/drivers/iio/gyro/adxrs290.c
index b61cc81122a6..eb3306215217 100644
--- a/drivers/iio/gyro/adxrs290.c
+++ b/drivers/iio/gyro/adxrs290.c
@@ -604,7 +604,7 @@ static int adxrs290_probe(struct spi_device *spi)
struct iio_dev *indio_dev;
struct adxrs290_state *st;
u8 val, val2;
- int ret;
+ int id, ret;
indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
if (!indio_dev)
@@ -622,21 +622,27 @@ static int adxrs290_probe(struct spi_device *spi)
mutex_init(&st->lock);
- val = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_ADI_ID));
- if (val != ADXRS290_ADI_ID) {
- dev_err(&spi->dev, "Wrong ADI ID 0x%02x\n", val);
+ id = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_ADI_ID));
+ if (id < 0)
+ return dev_err_probe(&spi->dev, id, "failed to read ADI ID\n");
+ if (id != ADXRS290_ADI_ID) {
+ dev_err(&spi->dev, "Wrong ADI ID 0x%02x\n", id);
return -ENODEV;
}
- val = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_MEMS_ID));
- if (val != ADXRS290_MEMS_ID) {
- dev_err(&spi->dev, "Wrong MEMS ID 0x%02x\n", val);
+ id = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_MEMS_ID));
+ if (id < 0)
+ return dev_err_probe(&spi->dev, id, "failed to read MEMS ID\n");
+ if (id != ADXRS290_MEMS_ID) {
+ dev_err(&spi->dev, "Wrong MEMS ID 0x%02x\n", id);
return -ENODEV;
}
- val = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_DEV_ID));
- if (val != ADXRS290_DEV_ID) {
- dev_err(&spi->dev, "Wrong DEV ID 0x%02x\n", val);
+ id = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_DEV_ID));
+ if (id < 0)
+ return dev_err_probe(&spi->dev, id, "failed to read DEV ID\n");
+ if (id != ADXRS290_DEV_ID) {
+ dev_err(&spi->dev, "Wrong DEV ID 0x%02x\n", id);
return -ENODEV;
}
base-commit: 903941a9b06ae445c70646ab061b604c2dea17d3
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: gyro: adxrs290: propagate chip ID read errors
2026-11-19 3:07 [PATCH] iio: gyro: adxrs290: propagate chip ID read errors Siqi Chen
@ 2026-11-19 10:12 ` Andy Shevchenko
2026-11-19 10:15 ` Joshua Crofts
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-11-19 10:12 UTC (permalink / raw)
To: Siqi Chen
Cc: nish.malpani25, jic23, nuno.sa, Michael.Hennerich, dlechner,
andy, linux-iio, linux, linux-kernel
On Thu, Nov 19, 2026 at 11:07:09AM +0800, Siqi Chen wrote:
> spi_w8r8() returns either an unsigned 8-bit value or a negative error.
> The probe function stores its return value in a u8, truncating errors and
> treating them as unexpected chip IDs. Consequently, an SPI transfer failure
> is reported as -ENODEV instead of the actual error.
>
> Store each result in an int and return negative errors before validating
> the chip IDs.
Starting from here the rest of the commit message should be moved to the
comment block (after '---' line).
> OpenCode was used to identify the issue and draft the code and changelog.
>
> Compile-tested with CONFIG_ADXRS290=m using:
>
> make O=/tmp/opencode/linux-build-adxrs290 W=1 \
> drivers/iio/gyro/adxrs290.o
>
> No hardware or SPI fault-injection testing was performed.
...
Code wise seems good to me.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: gyro: adxrs290: propagate chip ID read errors
2026-11-19 3:07 [PATCH] iio: gyro: adxrs290: propagate chip ID read errors Siqi Chen
2026-11-19 10:12 ` Andy Shevchenko
@ 2026-11-19 10:15 ` Joshua Crofts
1 sibling, 0 replies; 3+ messages in thread
From: Joshua Crofts @ 2026-11-19 10:15 UTC (permalink / raw)
To: Siqi Chen, nish.malpani25, jic23
Cc: nuno.sa, Michael.Hennerich, dlechner, andy, linux-iio, linux,
linux-kernel
On 19-Nov-26 4:07, Siqi Chen wrote:
> spi_w8r8() returns either an unsigned 8-bit value or a negative error.
> The probe function stores its return value in a u8, truncating errors and
> treating them as unexpected chip IDs. Consequently, an SPI transfer failure
> is reported as -ENODEV instead of the actual error.
>
> Store each result in an int and return negative errors before validating
> the chip IDs.
>
> OpenCode was used to identify the issue and draft the code and changelog.
>
> Compile-tested with CONFIG_ADXRS290=m using:
>
> make O=/tmp/opencode/linux-build-adxrs290 W=1 \
> drivers/iio/gyro/adxrs290.o
>
> No hardware or SPI fault-injection testing was performed.
Remove the testing info from the commit message and put it under the ---.
Unless you tested the patch on specific hardware then no need to immortalize
it in the git log.
Side note: one would expect that patches sent to the mailing list are at
least compile tested :)
>
> Fixes: 2c8920fff145 ("iio: gyro: Add driver support for ADXRS290")
> Signed-off-by: Siqi Chen <chensiqi@uniontech.com>
> ---
> drivers/iio/gyro/adxrs290.c | 26 ++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/iio/gyro/adxrs290.c b/drivers/iio/gyro/adxrs290.c
> index b61cc81122a6..eb3306215217 100644
> --- a/drivers/iio/gyro/adxrs290.c
> +++ b/drivers/iio/gyro/adxrs290.c
> @@ -604,7 +604,7 @@ static int adxrs290_probe(struct spi_device *spi)
> struct iio_dev *indio_dev;
> struct adxrs290_state *st;
> u8 val, val2;
> - int ret;
> + int id, ret;
Why a new variable? ret should be sufficient in this case.
>
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> if (!indio_dev)
> @@ -622,21 +622,27 @@ static int adxrs290_probe(struct spi_device *spi)
>
> mutex_init(&st->lock);
>
> - val = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_ADI_ID));
> - if (val != ADXRS290_ADI_ID) {
> - dev_err(&spi->dev, "Wrong ADI ID 0x%02x\n", val);
> + id = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_ADI_ID));
> + if (id < 0)
> + return dev_err_probe(&spi->dev, id, "failed to read ADI ID\n");
> + if (id != ADXRS290_ADI_ID) {
> + dev_err(&spi->dev, "Wrong ADI ID 0x%02x\n", id);
> return -ENODEV;
Not sure how this device works, but better to just call dev_info() to
ensure that any potential compatible fallback can be matched.
Also, why not just use dev_err_probe() if the previous if check uses
it? Style unification is a good idea.
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-19 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 3:07 [PATCH] iio: gyro: adxrs290: propagate chip ID read errors Siqi Chen
2026-11-19 10:12 ` Andy Shevchenko
2026-11-19 10:15 ` Joshua Crofts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®