From: Oleksij Rempel <o.rempel@pengutronix.de>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v5 2/3] ethtool: add a PHY receive byte total
Date: Thu, 19 Nov 2026 16:34:25 +0100 [thread overview]
Message-ID: <av8XAdXQqSRIVhY1@pengutronix.de> (raw)
In-Reply-To: <CADvTj4q8Yxi3SyS+Uiue1SwwujFcAABTD3+2BsdSwS3fs89wnw@mail.gmail.com>
On Tue, Nov 17, 2026 at 08:55:50AM -0700, James Hilliard wrote:
> This is Allwinner H616 EMAC1, using dwmac-sun8i/stmmac, connected to an
> AC200 PHY over RMII. The driver reports no MAC management counters.
> The CRC and length-error statistics in ethtool -S are software counters
> updated from RX descriptor status, not independent hardware counters.
[...]
> The tested length-field mismatches did produce descriptors and increment
> rx_length_errors. The accounting gap is specifically for frames discarded
> before an RX descriptor is returned, including those bad-FCS runts.
Thanks for checking this. On this board the PHY counters are the only
counters we know of that show these frames, and I see why you want them
to be as complete as possible.
With a MAC that does not count its own drops, it does not really matter
what exactly the PHY counters include. The difference between PHY and
MAC counts cannot be attributed anyway, and for debugging the deltas are
what matters, as Andrew said. So I will not insist on a particular
definition here.
For automated diagnostics, a tool would need to know what each counter
includes, on the PHY and on the MAC side. That would be nice to have,
but it is my dream for tomorrow, not something for this series.
Oleksij
next prev parent reply other threads:[~2026-11-19 15:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 7:45 [PATCH net-next v5 0/3] net: phy: report ACx00 receive statistics James Hilliard
2026-11-15 7:45 ` [PATCH net-next v5 1/3] docs: networking: correct the PHY statistics group name James Hilliard
2026-11-15 15:01 ` Andrew Lunn
2026-11-15 7:45 ` [PATCH net-next v5 2/3] ethtool: add a PHY receive byte total James Hilliard
2026-11-15 15:25 ` Andrew Lunn
2026-11-16 4:12 ` James Hilliard
2026-11-16 4:39 ` Andrew Lunn
2026-11-16 4:56 ` James Hilliard
2026-11-16 13:14 ` Andrew Lunn
2026-11-16 18:11 ` Oleksij Rempel
2026-11-16 21:20 ` James Hilliard
2026-11-17 8:25 ` Oleksij Rempel
2026-11-17 15:55 ` James Hilliard
2026-11-19 15:34 ` Oleksij Rempel [this message]
2026-11-16 21:09 ` James Hilliard
2026-11-16 8:06 ` netdev-bot+sashiko
2026-11-15 7:45 ` [PATCH net-next v5 3/3] net: phy: acx00: report receive statistics James Hilliard
2026-11-16 8:06 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8XAdXQqSRIVhY1@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®