mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/5] arm64: dts: rockchip: Enable more features on RK3588 EVB1
@ 2026-11-06 21:57 Sebastian Reichel
  2026-11-06 21:57 ` [PATCH 1/5] arm64: dts: rockchip: Add missing PCIe wake pinmux " Sebastian Reichel
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Sebastian Reichel @ 2026-11-06 21:57 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel, Sebastian Reichel

Enable a bunch of features on the RK3588 EVB1.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
Sebastian Reichel (5):
      arm64: dts: rockchip: Add missing PCIe wake pinmux on RK3588 EVB1
      arm64: dts: rockchip: Enable NPU on RK3588 EVB1
      arm64: dts: rockchip: Enable HDMI sound on RK3588 EVB1
      arm64: dts: rockchip: Add DSI panel to RK3588 EVB1
      arm64: dts: rockchip: Add Bluetooth to RK3588 EVB1

 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 180 ++++++++++++++++++++++-
 1 file changed, 179 insertions(+), 1 deletion(-)
---
base-commit: cabb6811c38a46337d5f4252b4dc390f9296856c
change-id: 20261106-rk3588-evb1-dt-updates-d3739177c7ad

Best regards,
--  
Sebastian Reichel <sebastian.reichel@collabora.com>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/5] arm64: dts: rockchip: Add missing PCIe wake pinmux on RK3588 EVB1
  2026-11-06 21:57 [PATCH 0/5] arm64: dts: rockchip: Enable more features on RK3588 EVB1 Sebastian Reichel
@ 2026-11-06 21:57 ` Sebastian Reichel
  2026-11-06 21:57 ` [PATCH 2/5] arm64: dts: rockchip: Enable NPU " Sebastian Reichel
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 10+ messages in thread
From: Sebastian Reichel @ 2026-11-06 21:57 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel, Sebastian Reichel

Add missing pinmux for the PCIe wake signal for the onboard LAN card.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
index 8969b56f3063..87e624d1e094 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
@@ -555,7 +555,8 @@ wifi: wifi@0,0 {
 &pcie2x1l1 {
 	reset-gpios = <&gpio4 RK_PA2 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";
-	pinctrl-0 = <&pcie2_1_rst>, <&rtl8111_isolate>, <&pcie30x1m1_1_clkreqn>;
+	pinctrl-0 = <&pcie2_1_rst>, <&rtl8111_isolate>, <&pcie30x1m1_1_clkreqn>,
+		    <&pcie30x1m1_1_waken>;
 	supports-clkreq;
 	status = "okay";
 };

-- 
2.53.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 2/5] arm64: dts: rockchip: Enable NPU on RK3588 EVB1
  2026-11-06 21:57 [PATCH 0/5] arm64: dts: rockchip: Enable more features on RK3588 EVB1 Sebastian Reichel
  2026-11-06 21:57 ` [PATCH 1/5] arm64: dts: rockchip: Add missing PCIe wake pinmux " Sebastian Reichel
@ 2026-11-06 21:57 ` Sebastian Reichel
  2026-11-08  2:03   ` Chaoyi Chen
  2026-11-06 21:57 ` [PATCH 3/5] arm64: dts: rockchip: Enable HDMI sound " Sebastian Reichel
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Sebastian Reichel @ 2026-11-06 21:57 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel, Sebastian Reichel

Also enable the NPU on the RK3588 EVB1, which is very similar to
the QuartzPro64.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 34 ++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
index 87e624d1e094..6476d9e3be6f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
@@ -578,6 +578,10 @@ &pd_gpu {
 	domain-supply = <&vdd_gpu_s0>;
 };
 
+&pd_npu {
+	domain-supply = <&vdd_npu_s0>;
+};
+
 &pd_rkvdec0 {
 	domain-supply = <&vdd_vdenc_s0>;
 };
@@ -703,6 +707,36 @@ &pwm2 {
 	status = "okay";
 };
 
+&rknn_core_0 {
+	npu-supply = <&vdd_npu_s0>;
+	sram-supply = <&vdd_npu_mem_s0>;
+	status = "okay";
+};
+
+&rknn_core_1 {
+	npu-supply = <&vdd_npu_s0>;
+	sram-supply = <&vdd_npu_mem_s0>;
+	status = "okay";
+};
+
+&rknn_core_2 {
+	npu-supply = <&vdd_npu_s0>;
+	sram-supply = <&vdd_npu_mem_s0>;
+	status = "okay";
+};
+
+&rknn_mmu_0 {
+	status = "okay";
+};
+
+&rknn_mmu_1 {
+	status = "okay";
+};
+
+&rknn_mmu_2 {
+	status = "okay";
+};
+
 &saradc {
 	vref-supply = <&vcc_1v8_s0>;
 	status = "okay";

-- 
2.53.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 3/5] arm64: dts: rockchip: Enable HDMI sound on RK3588 EVB1
  2026-11-06 21:57 [PATCH 0/5] arm64: dts: rockchip: Enable more features on RK3588 EVB1 Sebastian Reichel
  2026-11-06 21:57 ` [PATCH 1/5] arm64: dts: rockchip: Add missing PCIe wake pinmux " Sebastian Reichel
  2026-11-06 21:57 ` [PATCH 2/5] arm64: dts: rockchip: Enable NPU " Sebastian Reichel
@ 2026-11-06 21:57 ` Sebastian Reichel
  2026-11-06 21:57 ` [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to " Sebastian Reichel
  2026-11-06 21:57 ` [PATCH 5/5] arm64: dts: rockchip: Add Bluetooth " Sebastian Reichel
  4 siblings, 0 replies; 10+ messages in thread
From: Sebastian Reichel @ 2026-11-06 21:57 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel, Sebastian Reichel

The RK3588 EVB1 supports audio on both HDMI ports, so enable it
accordingly.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
index 6476d9e3be6f..6a95a8bb6fb8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
@@ -379,6 +379,10 @@ hdmi0_out_con: endpoint {
 	};
 };
 
+&hdmi0_sound {
+	status = "okay";
+};
+
 &hdmi1 {
 	frl-enable-gpios = <&gpio4 RK_PB2 GPIO_ACTIVE_LOW>;
 	pinctrl-0 = <&hdmim2_tx1_cec &hdmim0_tx1_hpd
@@ -399,6 +403,10 @@ hdmi1_out_con: endpoint {
 	};
 };
 
+&hdmi1_sound {
+	status = "okay";
+};
+
 &hdmi_receiver_cma {
 	status = "okay";
 };
@@ -514,6 +522,14 @@ &i2s0_sdi0
 	status = "okay";
 };
 
+&i2s5_8ch {
+	status = "okay";
+};
+
+&i2s6_8ch {
+	status = "okay";
+};
+
 &mdio0 {
 	rgmii_phy: ethernet-phy@1 {
 		/* RTL8211F */

-- 
2.53.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to RK3588 EVB1
  2026-11-06 21:57 [PATCH 0/5] arm64: dts: rockchip: Enable more features on RK3588 EVB1 Sebastian Reichel
                   ` (2 preceding siblings ...)
  2026-11-06 21:57 ` [PATCH 3/5] arm64: dts: rockchip: Enable HDMI sound " Sebastian Reichel
@ 2026-11-06 21:57 ` Sebastian Reichel
  2026-11-08  3:15   ` Chaoyi Chen
  2026-11-06 21:57 ` [PATCH 5/5] arm64: dts: rockchip: Add Bluetooth " Sebastian Reichel
  4 siblings, 1 reply; 10+ messages in thread
From: Sebastian Reichel @ 2026-11-06 21:57 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel, Sebastian Reichel

The RK3588 EVB1 comes with a W552793DBA-V10 Touchscreen/Display
combination. It contains a Wanchanglong W552793BAA panel and a
Goodix GT1158 touchscreen. This adds the DT description of it.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 90 ++++++++++++++++++++++++
 1 file changed, 90 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
index 6a95a8bb6fb8..327ca13b60f0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
@@ -204,6 +204,15 @@ vcc12v_dcin: regulator-vcc12v-dcin {
 		regulator-max-microvolt = <12000000>;
 	};
 
+	vcc3v3_lcd_mipi: regulator-vcc3v3-lcd-mipi {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc3v3_lcd_mipi";
+		regulator-boot-on;
+		enable-active-high;
+		gpio = <&gpio1 RK_PC4 GPIO_ACTIVE_HIGH>;
+		vin-supply = <&vcc_3v3_s0>;
+	};
+
 	vcc3v3_pcie30: regulator-vcc3v3-pcie30 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc3v3_pcie30";
@@ -338,6 +347,43 @@ &cpu_l3 {
 	cpu-supply = <&vdd_cpu_lit_s0>;
 };
 
+&dsi0 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	panel@0 {
+		compatible = "wanchanglong,w552793baa", "raydium,rm67200";
+		reg = <0>;
+		backlight = <&backlight>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&lcd_rst_gpio>;
+		vdd-supply = <&vcc3v3_lcd_mipi>;
+		iovcc-supply = <&vcc3v3_lcd_mipi>;
+		vsp-supply = <&vcc5v0_sys>;
+		vsn-supply = <&vcc5v0_sys>;
+		reset-gpios = <&gpio2 RK_PB4 GPIO_ACTIVE_LOW>;
+
+		port {
+			mipi_panel_in: endpoint {
+				remote-endpoint = <&dsi0_out_panel>;
+			};
+		};
+	};
+};
+
+&dsi0_in {
+	dsi0_in_vp3: endpoint {
+		remote-endpoint = <&vp3_out_dsi0>;
+	};
+};
+
+&dsi0_out {
+	dsi0_out_panel: endpoint {
+		remote-endpoint = <&mipi_panel_in>;
+	};
+};
+
 &gmac0 {
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy>;
@@ -495,6 +541,22 @@ hym8563: rtc@51 {
 	};
 };
 
+&i2c6 {
+	status = "okay";
+
+	gt1x: touchscreen@14 {
+		compatible = "goodix,gt1158";
+		reg = <0x14>;
+		interrupt-parent = <&gpio0>;
+		interrupts = <RK_PD3 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&touchscreen_pins>;
+		reset-gpios = <&gpio0 RK_PD2 GPIO_ACTIVE_HIGH>;
+		AVDD28-supply = <&vcc3v3_lcd_mipi>;
+		VDDIO-supply = <&vcc3v3_lcd_mipi>;
+	};
+};
+
 &i2c7 {
 	status = "okay";
 
@@ -543,6 +605,10 @@ rgmii_phy: ethernet-phy@1 {
 	};
 };
 
+&mipidcphy0 {
+	status = "okay";
+};
+
 &pcie2x1l0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie2_0_rst>, <&pcie2_0_wake>, <&pcie2_0_clkreq>, <&wifi_host_wake_irq>;
@@ -664,6 +730,12 @@ hym8563_int: hym8563-int {
 		};
 	};
 
+	mipi_dsi {
+		lcd_rst_gpio: lcd-rst {
+			rockchip,pins = <2 RK_PB4 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	pcie2 {
 		pcie2_0_rst: pcie2-0-rst {
 			rockchip,pins = <4 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -692,6 +764,14 @@ vcc3v3_pcie30_en: vcc3v3-pcie30-en {
 		};
 	};
 
+	touchscreen {
+		touchscreen_pins: touchscreen-pins {
+			rockchip,pins =
+				<0 RK_PD2 RK_FUNC_GPIO &pcfg_pull_up>,
+				<0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	usb {
 		vcc5v0_host_en: vcc5v0-host-en {
 			rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -1534,3 +1614,13 @@ vp1_out_hdmi1: endpoint@ROCKCHIP_VOP2_EP_HDMI1 {
 		remote-endpoint = <&hdmi1_in_vp1>;
 	};
 };
+
+&vp3 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	vp3_out_dsi0: endpoint@ROCKCHIP_VOP2_EP_MIPI0 {
+		reg = <ROCKCHIP_VOP2_EP_MIPI0>;
+		remote-endpoint = <&dsi0_in_vp3>;
+	};
+};

-- 
2.53.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 5/5] arm64: dts: rockchip: Add Bluetooth to RK3588 EVB1
  2026-11-06 21:57 [PATCH 0/5] arm64: dts: rockchip: Enable more features on RK3588 EVB1 Sebastian Reichel
                   ` (3 preceding siblings ...)
  2026-11-06 21:57 ` [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to " Sebastian Reichel
@ 2026-11-06 21:57 ` Sebastian Reichel
  4 siblings, 0 replies; 10+ messages in thread
From: Sebastian Reichel @ 2026-11-06 21:57 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel, Sebastian Reichel

The RK3588 EVB1 has an AP6275P WIFI6/BT Module. The WLAN side is
connected via PCIe and already described. This adds the BT side, which
is connected via UART. BT is also connected to I2S, which can be used
for BT audio. By default BT audio is routed via the HCI UART interface
instead.

The added I2S complexity is avoided for now, but would require the
following steps:

1. Setup "brcm,bt-pcm-int-params" in the bluetooth node
2. Add a simple sound card for Bluetooth using &i2s2_2ch (using default
   M1 pinmux) on the CPU side and "linux,bt-sco" on the codec side
3. Extending "linux,bt-sco", so that it supports 2 channels, because
   the Rockchip I2S hardware cannot output single channel

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 37 ++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
index 327ca13b60f0..f578e7dd5aa1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
@@ -695,6 +695,20 @@ speaker_amplifier_en: speaker-amplifier-en {
 		};
 	};
 
+	bluetooth {
+		bt_pwr_en: bluetooth-pwren {
+			rockchip,pins = <3 RK_PA6 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+
+		bt_wake_host_irq: bluetooth-wake-host {
+			rockchip,pins = <3 RK_PA0 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+
+		bt_wake_gpio: bluetooth-wake {
+			rockchip,pins = <3 RK_PA1 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	rtl8111 {
 		rtl8111_isolate: rtl8111-isolate {
 			rockchip,pins = <1 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>;
@@ -1522,6 +1536,29 @@ &uart2 {
 	status = "okay";
 };
 
+&uart8 {
+	pinctrl-0 = <&uart8m1_xfer &uart8m1_ctsn &uart8m1_rtsn>;
+	pinctrl-names = "default";
+	uart-has-rtscts;
+	status = "okay";
+
+	bluetooth {
+		compatible = "brcm,bcm4345c5";
+		clocks = <&hym8563>;
+		clock-names = "lpo";
+		device-wakeup-gpios = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>;
+		interrupt-names = "host-wakeup";
+		interrupt-parent = <&gpio3>;
+		interrupts = <RK_PA0 IRQ_TYPE_LEVEL_HIGH>;
+		max-speed = <1500000>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&bt_wake_host_irq &bt_wake_gpio &bt_pwr_en>;
+		shutdown-gpios = <&gpio3 RK_PA6 GPIO_ACTIVE_HIGH>;
+		vbat-supply = <&vcc3v3_pciewl_vbat>;
+		vddio-supply = <&vccio_wl>;
+	};
+};
+
 &usb_host0_ehci {
 	status = "okay";
 };

-- 
2.53.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/5] arm64: dts: rockchip: Enable NPU on RK3588 EVB1
  2026-11-06 21:57 ` [PATCH 2/5] arm64: dts: rockchip: Enable NPU " Sebastian Reichel
@ 2026-11-08  2:03   ` Chaoyi Chen
  2026-11-08 19:29     ` Sebastian Reichel
  0 siblings, 1 reply; 10+ messages in thread
From: Chaoyi Chen @ 2026-11-08  2:03 UTC (permalink / raw)
  To: Sebastian Reichel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel

On 11/7/2026 5:57 AM, Sebastian Reichel wrote:
> Also enable the NPU on the RK3588 EVB1, which is very similar to
> the QuartzPro64.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---

I remember there was already a similar patch before?
Maybe I got something wrong.

Reviewed-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>

>  arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 34 ++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> index 87e624d1e094..6476d9e3be6f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> @@ -578,6 +578,10 @@ &pd_gpu {
>  	domain-supply = <&vdd_gpu_s0>;
>  };
>  
> +&pd_npu {
> +	domain-supply = <&vdd_npu_s0>;
> +};
> +
>  &pd_rkvdec0 {
>  	domain-supply = <&vdd_vdenc_s0>;
>  };
> @@ -703,6 +707,36 @@ &pwm2 {
>  	status = "okay";
>  };
>  
> +&rknn_core_0 {
> +	npu-supply = <&vdd_npu_s0>;
> +	sram-supply = <&vdd_npu_mem_s0>;
> +	status = "okay";
> +};
> +
> +&rknn_core_1 {
> +	npu-supply = <&vdd_npu_s0>;
> +	sram-supply = <&vdd_npu_mem_s0>;
> +	status = "okay";
> +};
> +
> +&rknn_core_2 {
> +	npu-supply = <&vdd_npu_s0>;
> +	sram-supply = <&vdd_npu_mem_s0>;
> +	status = "okay";
> +};
> +
> +&rknn_mmu_0 {
> +	status = "okay";
> +};
> +
> +&rknn_mmu_1 {
> +	status = "okay";
> +};
> +
> +&rknn_mmu_2 {
> +	status = "okay";
> +};
> +
>  &saradc {
>  	vref-supply = <&vcc_1v8_s0>;
>  	status = "okay";
> 

-- 
Best, 
Chaoyi


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to RK3588 EVB1
  2026-11-06 21:57 ` [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to " Sebastian Reichel
@ 2026-11-08  3:15   ` Chaoyi Chen
  2026-11-08 19:42     ` Sebastian Reichel
  0 siblings, 1 reply; 10+ messages in thread
From: Chaoyi Chen @ 2026-11-08  3:15 UTC (permalink / raw)
  To: Sebastian Reichel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel

Hi Sebastian,

On 11/7/2026 5:57 AM, Sebastian Reichel wrote:
> The RK3588 EVB1 comes with a W552793DBA-V10 Touchscreen/Display
> combination. It contains a Wanchanglong W552793BAA panel and a
> Goodix GT1158 touchscreen. This adds the DT description of it.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 90 ++++++++++++++++++++++++
>  1 file changed, 90 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> index 6a95a8bb6fb8..327ca13b60f0 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> @@ -204,6 +204,15 @@ vcc12v_dcin: regulator-vcc12v-dcin {
>  		regulator-max-microvolt = <12000000>;
>  	};
>  

I seem unable to apply the patch to the latest linux-next tree.

So I tried to resolve the conflict manually, but the actual
test screen did not display. I will look into this further.


> +	vcc3v3_lcd_mipi: regulator-vcc3v3-lcd-mipi {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc3v3_lcd_mipi";
> +		regulator-boot-on;
> +		enable-active-high;
> +		gpio = <&gpio1 RK_PC4 GPIO_ACTIVE_HIGH>;
> +		vin-supply = <&vcc_3v3_s0>;
> +	};
> +
>  	vcc3v3_pcie30: regulator-vcc3v3-pcie30 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vcc3v3_pcie30";
> @@ -338,6 +347,43 @@ &cpu_l3 {
>  	cpu-supply = <&vdd_cpu_lit_s0>;
>  };
>  
> +&dsi0 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	panel@0 {
> +		compatible = "wanchanglong,w552793baa", "raydium,rm67200";
> +		reg = <0>;
> +		backlight = <&backlight>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&lcd_rst_gpio>;
> +		vdd-supply = <&vcc3v3_lcd_mipi>;
> +		iovcc-supply = <&vcc3v3_lcd_mipi>;
> +		vsp-supply = <&vcc5v0_sys>;
> +		vsn-supply = <&vcc5v0_sys>;
> +		reset-gpios = <&gpio2 RK_PB4 GPIO_ACTIVE_LOW>;
> +
> +		port {
> +			mipi_panel_in: endpoint {
> +				remote-endpoint = <&dsi0_out_panel>;
> +			};
> +		};
> +	};
> +};
> +
> +&dsi0_in {
> +	dsi0_in_vp3: endpoint {
> +		remote-endpoint = <&vp3_out_dsi0>;
> +	};
> +};
> +
> +&dsi0_out {
> +	dsi0_out_panel: endpoint {
> +		remote-endpoint = <&mipi_panel_in>;
> +	};
> +};
> +
>  &gmac0 {
>  	clock_in_out = "output";
>  	phy-handle = <&rgmii_phy>;
> @@ -495,6 +541,22 @@ hym8563: rtc@51 {
>  	};
>  };
>  
> +&i2c6 {
> +	status = "okay";
> +
> +	gt1x: touchscreen@14 {
> +		compatible = "goodix,gt1158";
> +		reg = <0x14>;
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <RK_PD3 IRQ_TYPE_LEVEL_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&touchscreen_pins>;
> +		reset-gpios = <&gpio0 RK_PD2 GPIO_ACTIVE_HIGH>;
> +		AVDD28-supply = <&vcc3v3_lcd_mipi>;
> +		VDDIO-supply = <&vcc3v3_lcd_mipi>;
> +	};
> +};
> +
>  &i2c7 {
>  	status = "okay";
>  
> @@ -543,6 +605,10 @@ rgmii_phy: ethernet-phy@1 {
>  	};
>  };
>  
> +&mipidcphy0 {
> +	status = "okay";
> +};
> +
>  &pcie2x1l0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pcie2_0_rst>, <&pcie2_0_wake>, <&pcie2_0_clkreq>, <&wifi_host_wake_irq>;
> @@ -664,6 +730,12 @@ hym8563_int: hym8563-int {
>  		};
>  	};
>  
> +	mipi_dsi {
> +		lcd_rst_gpio: lcd-rst {
> +			rockchip,pins = <2 RK_PB4 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};
> +
>  	pcie2 {
>  		pcie2_0_rst: pcie2-0-rst {
>  			rockchip,pins = <4 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
> @@ -692,6 +764,14 @@ vcc3v3_pcie30_en: vcc3v3-pcie30-en {
>  		};
>  	};
>  
> +	touchscreen {
> +		touchscreen_pins: touchscreen-pins {
> +			rockchip,pins =
> +				<0 RK_PD2 RK_FUNC_GPIO &pcfg_pull_up>,
> +				<0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};
> +
>  	usb {
>  		vcc5v0_host_en: vcc5v0-host-en {
>  			rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
> @@ -1534,3 +1614,13 @@ vp1_out_hdmi1: endpoint@ROCKCHIP_VOP2_EP_HDMI1 {
>  		remote-endpoint = <&hdmi1_in_vp1>;
>  	};
>  };
> +
> +&vp3 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	vp3_out_dsi0: endpoint@ROCKCHIP_VOP2_EP_MIPI0 {
> +		reg = <ROCKCHIP_VOP2_EP_MIPI0>;
> +		remote-endpoint = <&dsi0_in_vp3>;
> +	};
> +};
> 

-- 
Best, 
Chaoyi


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/5] arm64: dts: rockchip: Enable NPU on RK3588 EVB1
  2026-11-08  2:03   ` Chaoyi Chen
@ 2026-11-08 19:29     ` Sebastian Reichel
  0 siblings, 0 replies; 10+ messages in thread
From: Sebastian Reichel @ 2026-11-08 19:29 UTC (permalink / raw)
  To: Chaoyi Chen
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel

[-- Attachment #1: Type: text/plain, Size: 2108 bytes --]

Hi,

On Sun, Nov 08, 2026 at 10:03:05AM +0800, Chaoyi Chen wrote:
> On 11/7/2026 5:57 AM, Sebastian Reichel wrote:
> > Also enable the NPU on the RK3588 EVB1, which is very similar to
> > the QuartzPro64.
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> 
> I remember there was already a similar patch before?
> Maybe I got something wrong.

TBH I haven't checked before sending this, but did now and there
doesn't seem to be anything:

https://lore.kernel.org/all/?q=file=arch%2Farm64%2Fboot%2Fdts%2Frockchip%2Frk3588-evb1-v10.dts

Greetings,

-- Sebastian

> 
> Reviewed-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> 
> >  arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 34 ++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > index 87e624d1e094..6476d9e3be6f 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > @@ -578,6 +578,10 @@ &pd_gpu {
> >  	domain-supply = <&vdd_gpu_s0>;
> >  };
> >  
> > +&pd_npu {
> > +	domain-supply = <&vdd_npu_s0>;
> > +};
> > +
> >  &pd_rkvdec0 {
> >  	domain-supply = <&vdd_vdenc_s0>;
> >  };
> > @@ -703,6 +707,36 @@ &pwm2 {
> >  	status = "okay";
> >  };
> >  
> > +&rknn_core_0 {
> > +	npu-supply = <&vdd_npu_s0>;
> > +	sram-supply = <&vdd_npu_mem_s0>;
> > +	status = "okay";
> > +};
> > +
> > +&rknn_core_1 {
> > +	npu-supply = <&vdd_npu_s0>;
> > +	sram-supply = <&vdd_npu_mem_s0>;
> > +	status = "okay";
> > +};
> > +
> > +&rknn_core_2 {
> > +	npu-supply = <&vdd_npu_s0>;
> > +	sram-supply = <&vdd_npu_mem_s0>;
> > +	status = "okay";
> > +};
> > +
> > +&rknn_mmu_0 {
> > +	status = "okay";
> > +};
> > +
> > +&rknn_mmu_1 {
> > +	status = "okay";
> > +};
> > +
> > +&rknn_mmu_2 {
> > +	status = "okay";
> > +};
> > +
> >  &saradc {
> >  	vref-supply = <&vcc_1v8_s0>;
> >  	status = "okay";
> > 
> 
> -- 
> Best, 
> Chaoyi
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to RK3588 EVB1
  2026-11-08  3:15   ` Chaoyi Chen
@ 2026-11-08 19:42     ` Sebastian Reichel
  0 siblings, 0 replies; 10+ messages in thread
From: Sebastian Reichel @ 2026-11-08 19:42 UTC (permalink / raw)
  To: Chaoyi Chen
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	kernel

[-- Attachment #1: Type: text/plain, Size: 1812 bytes --]

Hello Chaoyi,

On Sun, Nov 08, 2026 at 11:15:09AM +0800, Chaoyi Chen wrote:
> Hi Sebastian,
> 
> On 11/7/2026 5:57 AM, Sebastian Reichel wrote:
> > The RK3588 EVB1 comes with a W552793DBA-V10 Touchscreen/Display
> > combination. It contains a Wanchanglong W552793BAA panel and a
> > Goodix GT1158 touchscreen. This adds the DT description of it.
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 90 ++++++++++++++++++++++++
> >  1 file changed, 90 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > index 6a95a8bb6fb8..327ca13b60f0 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > @@ -204,6 +204,15 @@ vcc12v_dcin: regulator-vcc12v-dcin {
> >  		regulator-max-microvolt = <12000000>;
> >  	};
> >  
> 
> I seem unable to apply the patch to the latest linux-next tree.
> 
> So I tried to resolve the conflict manually, but the actual
> test screen did not display. I will look into this further.

Strange. The base of this series was Heiko's for-next tree from
Friday. No RK3588 EVB1 patches landed since then:

https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=cabb6811c38a46337d5f4252b4dc390f9296856c

If your board uses the original Rockchip bootloader, which shows a
Rockchip logo on the panel, you also need Cristian's latest YUV420
patches that reset VOP2 at probe time avoiding some issues with the
pre-initialized panel as a side effect. Those were recently applied
by Heiko to the DRM tree, so testing on linux-next is indeed
sensible.

Greetings,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-11-08 19:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-06 21:57 [PATCH 0/5] arm64: dts: rockchip: Enable more features on RK3588 EVB1 Sebastian Reichel
2026-11-06 21:57 ` [PATCH 1/5] arm64: dts: rockchip: Add missing PCIe wake pinmux " Sebastian Reichel
2026-11-06 21:57 ` [PATCH 2/5] arm64: dts: rockchip: Enable NPU " Sebastian Reichel
2026-11-08  2:03   ` Chaoyi Chen
2026-11-08 19:29     ` Sebastian Reichel
2026-11-06 21:57 ` [PATCH 3/5] arm64: dts: rockchip: Enable HDMI sound " Sebastian Reichel
2026-11-06 21:57 ` [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to " Sebastian Reichel
2026-11-08  3:15   ` Chaoyi Chen
2026-11-08 19:42     ` Sebastian Reichel
2026-11-06 21:57 ` [PATCH 5/5] arm64: dts: rockchip: Add Bluetooth " Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®