mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Wolfram Sang <wsa@kernel.org>, Felipe Balbi <balbi@kernel.org>,
	 Tony Lindgren <tony@atomide.com>,
	Hyunjung Ko <hj351016@gmail.com>,
	linux-input@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: lm8323 - remove driver
Date: Mon, 9 Nov 2026 00:01:03 -0800	[thread overview]
Message-ID: <avF9Z29GYy58K53e@google.com> (raw)
In-Reply-To: <def3815d-d3f6-4032-b7f3-d2b5e48c770f@app.fastmail.com>

On Mon, Nov 09, 2026 at 08:53:58AM +0100, Arnd Bergmann wrote:
> On Mon, Nov 9, 2026, at 08:29, Dmitry Torokhov wrote:
> > The LM8323 keypad driver relies exclusively on legacy platform data,
> > has no Device Tree or generic device property support, and has no users
> > in mainline (including the Nokia N810 DTS, which never added support
> > for it). Its PWM/LED handling and unbind lifetime are broken, and after
> > hardware-tested IRQ fixes in 2011 the driver has for over a decade only
> > received mechanical API conversions and static-analysis cleanups
> > without hardware testing.
> >
> > An inquiry on the mailing list asking whether anyone still uses or
> > wishes to keep the driver received no objections. Remove the driver
> > and its platform data header.
> >
> > Link: https://lore.kernel.org/r/Zr6I9RB5mibU_12N@google.com
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> I made an identical patch (for both drivers combined) based on the
> same conclusion, but you beat me to posting it.
> 
> I have additional Input driver patches in the same series at
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=board-remove-7.4
> 
> It's a mix of three types of changes:
> 
> - drivers that have been unused for years
> - drivers that become unused after I remove the board files
> - drivers that support both DT and platform_data, and I remove the latter
> 
> My plan was to post these after my board removal series is merged,
> and this got delayed until 7.5 now after some back and forth because
> I wanted to make sure they remain in the LTS kernel.
> 
> If you like, I can send more of these earlier.

Please send them to me so I can queue them: this way there's less chance
someone sends cleanup patches for them. And then they will be gone from
7.5.

Thanks.

-- 
Dmitry

  reply	other threads:[~2026-11-09  8:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  7:29 [PATCH 0/2] Input: remove unused lm8323 and lm8333 keypad drivers Dmitry Torokhov
2026-11-09  7:29 ` [PATCH 1/2] Input: lm8323 - remove driver Dmitry Torokhov
2026-11-09  7:46   ` khj
2026-11-09  7:53   ` Arnd Bergmann
2026-11-09  8:01     ` Dmitry Torokhov [this message]
2026-11-09  7:29 ` [PATCH 2/2] Input: lm8333 " Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avF9Z29GYy58K53e@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=arnd@arndb.de \
    --cc=balbi@kernel.org \
    --cc=hj351016@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®