mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Wolfram Sang" <wsa@kernel.org>
Cc: "Felipe Balbi" <balbi@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Hyunjung Ko" <hj351016@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: lm8323 - remove driver
Date: Mon, 09 Nov 2026 08:53:58 +0100	[thread overview]
Message-ID: <def3815d-d3f6-4032-b7f3-d2b5e48c770f@app.fastmail.com> (raw)
In-Reply-To: <20261109072950.3474308-2-dmitry.torokhov@gmail.com>

On Mon, Nov 9, 2026, at 08:29, Dmitry Torokhov wrote:
> The LM8323 keypad driver relies exclusively on legacy platform data,
> has no Device Tree or generic device property support, and has no users
> in mainline (including the Nokia N810 DTS, which never added support
> for it). Its PWM/LED handling and unbind lifetime are broken, and after
> hardware-tested IRQ fixes in 2011 the driver has for over a decade only
> received mechanical API conversions and static-analysis cleanups
> without hardware testing.
>
> An inquiry on the mailing list asking whether anyone still uses or
> wishes to keep the driver received no objections. Remove the driver
> and its platform data header.
>
> Link: https://lore.kernel.org/r/Zr6I9RB5mibU_12N@google.com
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

I made an identical patch (for both drivers combined) based on the
same conclusion, but you beat me to posting it.

I have additional Input driver patches in the same series at

https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=board-remove-7.4

It's a mix of three types of changes:

- drivers that have been unused for years
- drivers that become unused after I remove the board files
- drivers that support both DT and platform_data, and I remove the latter

My plan was to post these after my board removal series is merged,
and this got delayed until 7.5 now after some back and forth because
I wanted to make sure they remain in the LTS kernel.

If you like, I can send more of these earlier.

      Arnd

2fc6e4e7ae89 Input: serio: remove RiscPC keyboard driver
 drivers/input/serio/Kconfig  |  11 ----
 drivers/input/serio/Makefile |   1 -
 drivers/input/serio/rpckbd.c | 152 -------------------------------------------
 3 files changed, 164 deletions(-)
48553e29487a Input: mouse: remove RiscPC mouse driver
 drivers/input/mouse/Kconfig    |  10 ----
 drivers/input/mouse/Makefile   |   1 -
 drivers/input/mouse/rpcmouse.c | 113 -----------------------------------------
 3 files changed, 124 deletions(-)
cc705b30670f Input: touchscreen: remove unused iPaq micro driver
 drivers/input/touchscreen/Kconfig         |  12 ---
 drivers/input/touchscreen/Makefile        |   1 -
 drivers/input/touchscreen/ipaq-micro-ts.c | 156 ------------------------------
 3 files changed, 169 deletions(-)
e0fa7869cf39 Input: touchscreen: remove HP jornada720 support
 drivers/input/touchscreen/Kconfig         |  10 --
 drivers/input/touchscreen/Makefile        |   1 -
 drivers/input/touchscreen/jornada720_ts.c | 156 ------------------------------
 3 files changed, 167 deletions(-)
0e7bc6741e99 Input: touchscreen: remove unused mc13783 driver
 drivers/input/touchscreen/Kconfig      |  12 --
 drivers/input/touchscreen/Makefile     |   1 -
 drivers/input/touchscreen/mc13783_ts.c | 245 ---------------------------------
 3 files changed, 258 deletions(-)
b106094d20b6 Input: touchscreen: remove unused ad7877 driver
 drivers/input/touchscreen/Kconfig  |  13 -
 drivers/input/touchscreen/Makefile |   1 -
 drivers/input/touchscreen/ad7877.c | 813 -------------------------------------
 3 files changed, 827 deletions(-)
618f5f964ae6 Input: touchscreen: remove unused tps6507x driver
 drivers/input/touchscreen/Kconfig       |  12 --
 drivers/input/touchscreen/Makefile      |   1 -
 drivers/input/touchscreen/tps6507x-ts.c | 291 --------------------------------
 3 files changed, 304 deletions(-)
f19aee30274b Input: serio: remove sa1111 ps/2 driver
 drivers/input/serio/Kconfig     |   4 -
 drivers/input/serio/Makefile    |   1 -
 drivers/input/serio/sa1111ps2.c | 384 ----------------------------------------
 3 files changed, 389 deletions(-)
f89e36a6d981 Input: keyboard: remove unused ipaq-micro driver
 drivers/input/keyboard/Kconfig           |  10 --
 drivers/input/keyboard/Makefile          |   1 -
 drivers/input/keyboard/ipaq-micro-keys.c | 165 -------------------------------
 3 files changed, 176 deletions(-)
f47f4668b39e Input: keyboard: remove unused locomo driver
 drivers/input/keyboard/Kconfig     |   8 -
 drivers/input/keyboard/Makefile    |   1 -
 drivers/input/keyboard/locomokbd.c | 340 -------------------------------------
 3 files changed, 349 deletions(-)
94397d400e71 Input: keyboard: remove unused jornada720_kbd driver
 drivers/input/keyboard/Kconfig          |  10 ---
 drivers/input/keyboard/Makefile         |   1 -
 drivers/input/keyboard/jornada720_kbd.c | 142 --------------------------------
 3 files changed, 153 deletions(-)
45a0b5d9aec8 Input: keyboard: remove lm8323 and lm8333 drivers
 drivers/input/keyboard/Kconfig  |  22 --
 drivers/input/keyboard/Makefile |   2 -
 drivers/input/keyboard/lm8323.c | 813 ----------------------------------------
 drivers/input/keyboard/lm8333.c | 213 -----------
 4 files changed, 1050 deletions(-)
7b34e2e324ff Input: joystick: remove as5011 joystick driver
 drivers/input/joystick/Kconfig  |  10 --
 drivers/input/joystick/Makefile |   1 -
 drivers/input/joystick/as5011.c | 354 ----------------------------------------
 3 files changed, 365 deletions(-)
62cfa3e37cba Input: misc: remove unused mc13783-pwrbutton driver
 drivers/input/misc/Kconfig             |  10 --
 drivers/input/misc/Makefile            |   1 -
 drivers/input/misc/mc13783-pwrbutton.c | 266 ---------------------------------
 3 files changed, 277 deletions(-)
e907244315b7 Input: misc: remove unused cma3000 accelerometer driver
 drivers/input/misc/Kconfig           |  24 ---
 drivers/input/misc/Makefile          |   2 -
 drivers/input/misc/cma3000_d0x.c     | 379 -----------------------------------
 drivers/input/misc/cma3000_d0x.h     |  31 ---
 drivers/input/misc/cma3000_d0x_i2c.c | 113 -----------
 5 files changed, 549 deletions(-)
9dcaab7ec67a Input: misc: remove unused kxtj9 driver
 drivers/input/misc/Kconfig  |  10 -
 drivers/input/misc/Makefile |   1 -
 drivers/input/misc/kxtj9.c  | 548 --------------------------------------------
 3 files changed, 559 deletions(-)
82f1f73d7331 Input: misc: remove unused max8997_haptic driver
 drivers/input/misc/Kconfig          |  12 -
 drivers/input/misc/Makefile         |   1 -
 drivers/input/misc/max8997_haptic.c | 434 ------------------------------------
 3 files changed, 447 deletions(-)
8a21394cb9e7 Input: misc: remove unused bma150 driver
 drivers/input/misc/Kconfig  |  10 -
 drivers/input/misc/Makefile |   1 -
 drivers/input/misc/bma150.c | 575 --------------------------------------------
 3 files changed, 586 deletions(-)
a25190646153 Input: misc: bma150: remove platform data based probing
 drivers/input/misc/bma150.c | 49 ++++++++++++++++++++++++++++-----------------
 1 file changed, 31 insertions(+), 18 deletions(-)
3ee02d394861 Input: misc: remove unused adxl34x driver
 drivers/input/misc/Kconfig       |  37 --
 drivers/input/misc/Makefile      |   3 -
 drivers/input/misc/adxl34x-i2c.c | 137 ------
 drivers/input/misc/adxl34x-spi.c | 103 -----
 drivers/input/misc/adxl34x.c     | 872 ---------------------------------------
 drivers/input/misc/adxl34x.h     |  30 --
 6 files changed, 1182 deletions(-)
7303850802da Input: misc: remove unused ad714x driver
 drivers/input/misc/Kconfig      |   30 -
 drivers/input/misc/Makefile     |    3 -
 drivers/input/misc/ad714x-i2c.c |   97 ----
 drivers/input/misc/ad714x-spi.c |  103 ----
 drivers/input/misc/ad714x.c     | 1200 ---------------------------------------
 drivers/input/misc/ad714x.h     |   53 --
 6 files changed, 1486 deletions(-)
067581d4518d mfd: remove unused da903x driver
 drivers/input/touchscreen/Kconfig     |  13 --
 drivers/input/touchscreen/Makefile    |   1 -
 drivers/input/touchscreen/da9034-ts.c | 364 ----------------------------------
 3 files changed, 378 deletions(-)
0403fd11877e mfd: remove unused adp5520 driver
 drivers/input/keyboard/Kconfig        |  10 --
 drivers/input/keyboard/Makefile       |   1 -
 drivers/input/keyboard/adp5520-keys.c | 190 ----------------------------------
 3 files changed, 201 deletions(-)
d26d231fe10b mfd: remove unused 88pm80x driver
 drivers/input/misc/88pm80x_onkey.c | 152 -------------------------------------
 drivers/input/misc/Kconfig         |  10 ---
 drivers/input/misc/Makefile        |   1 -
 3 files changed, 163 deletions(-)


  parent reply	other threads:[~2026-11-09  7:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  7:29 [PATCH 0/2] Input: remove unused lm8323 and lm8333 keypad drivers Dmitry Torokhov
2026-11-09  7:29 ` [PATCH 1/2] Input: lm8323 - remove driver Dmitry Torokhov
2026-11-09  7:46   ` khj
2026-11-09  7:53   ` Arnd Bergmann [this message]
2026-11-09  8:01     ` Dmitry Torokhov
2026-11-09  7:29 ` [PATCH 2/2] Input: lm8333 " Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=def3815d-d3f6-4032-b7f3-d2b5e48c770f@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=balbi@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hj351016@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®