* [PATCH v2] Input: gpio-keys - do not BUG() on requested wakeirqs
@ 2026-11-07 10:48 Andreas Kemnade
2026-11-09 7:05 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Kemnade @ 2026-11-07 10:48 UTC (permalink / raw)
To: dmitry.torokhov, andreas, bartosz.golaszewski, arnd,
marco.crivellari, tony, linux-input, linux-kernel, brgl
Having the IRQ handler called when enabled IRQs arrive should be considered
as a feature not as a bug. So do not BUG() there when this happens.
Also BUG() is too harsh here.
Fixes: 3717194f24922 ("Input: gpio-keys - add system suspend support for dedicated wakeirqs")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Changes in v2:
do not BUG() at all here and remove the other similar instance of this
BUG().
drivers/input/keyboard/gpio_keys.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index fbc31c5db3db4..41a9210b40176 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -412,8 +412,6 @@ static irqreturn_t gpio_keys_gpio_isr(int irq, void *dev_id)
{
struct gpio_button_data *bdata = dev_id;
- BUG_ON(irq != bdata->irq);
-
if (bdata->button->wakeup) {
const struct gpio_keys_button *button = bdata->button;
@@ -465,8 +463,6 @@ static irqreturn_t gpio_keys_irq_isr(int irq, void *dev_id)
struct gpio_button_data *bdata = dev_id;
struct input_dev *input = bdata->input;
- BUG_ON(irq != bdata->irq);
-
guard(spinlock_irqsave)(&bdata->lock);
if (!bdata->key_pressed) {
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Input: gpio-keys - do not BUG() on requested wakeirqs
2026-11-07 10:48 [PATCH v2] Input: gpio-keys - do not BUG() on requested wakeirqs Andreas Kemnade
@ 2026-11-09 7:05 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2026-11-09 7:05 UTC (permalink / raw)
To: Andreas Kemnade
Cc: bartosz.golaszewski, arnd, marco.crivellari, tony, linux-input,
linux-kernel, brgl
On Sat, Nov 07, 2026 at 11:48:07AM +0100, Andreas Kemnade wrote:
> Having the IRQ handler called when enabled IRQs arrive should be considered
> as a feature not as a bug. So do not BUG() there when this happens.
> Also BUG() is too harsh here.
>
> Fixes: 3717194f24922 ("Input: gpio-keys - add system suspend support for dedicated wakeirqs")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-09 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-07 10:48 [PATCH v2] Input: gpio-keys - do not BUG() on requested wakeirqs Andreas Kemnade
2026-11-09 7:05 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®