mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>
Subject: Re: [PATCH 2/3] drm/xe: Remove driver side resource assignment after BAR resize
Date: Mon, 9 Nov 2026 10:00:18 -0500	[thread overview]
Message-ID: <avHgAmVk5jCTkECK@intel.com> (raw)
In-Reply-To: <20261109131011.1815-3-ilpo.jarvinen@linux.intel.com>

On Mon, Nov 09, 2026 at 03:10:09PM +0200, Ilpo Järvinen wrote:
> pci_resize_resource() assigns the resized BAR and the other BARs it
> released, or restores the original configuration on failure. Calling
> pci_assign_unassigned_bus_resources() after it is redundant. If that
> call manages to assign more resources in some scenario, the problem
> should be fixed inside pci_resize_resource() instead.
> 
> Remove the pci_assign_unassigned_bus_resources() call from
> xe_pci_rebar_resize().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

feel free to take it through your trees

> ---
>  drivers/gpu/drm/xe/xe_pci_rebar.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci_rebar.c b/drivers/gpu/drm/xe/xe_pci_rebar.c
> index 7e2c7079b6ff..f47b3c039abd 100644
> --- a/drivers/gpu/drm/xe/xe_pci_rebar.c
> +++ b/drivers/gpu/drm/xe/xe_pci_rebar.c
> @@ -100,7 +100,5 @@ void xe_pci_rebar_resize(struct xe_device *xe)
>  	pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd & ~PCI_COMMAND_MEMORY);
>  
>  	resize_bar(xe, LMEM_BAR, rebar_size);
> -
> -	pci_assign_unassigned_bus_resources(pdev->bus);
>  	pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
>  }
> -- 
> 2.47.3
> 

  reply	other threads:[~2026-11-09 15:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 13:10 [PATCH 0/3] PCI: remove redundant resource assignments done " Ilpo Järvinen
2026-11-09 13:10 ` [PATCH 1/3] PCI/sysfs: Remove resource assignment " Ilpo Järvinen
2026-11-09 13:10 ` [PATCH 2/3] drm/xe: Remove driver side " Ilpo Järvinen
2026-11-09 15:00   ` Rodrigo Vivi [this message]
2026-11-09 13:10 ` [PATCH 3/3] drm/i915: " Ilpo Järvinen
2026-11-09 13:50   ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avHgAmVk5jCTkECK@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=airlied@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®