From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Bjorn Andersson <andersson@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-remoteproc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: stm32_rproc: Do not request reset by index
Date: Mon, 9 Nov 2026 09:32:44 -0600 [thread overview]
Message-ID: <avHnnBUiH-kLOrCU@p14s> (raw)
In-Reply-To: <20261106-reset-deindex-rproc-v1-1-41a03fcc8496@pengutronix.de>
On Fri, Nov 06, 2026 at 04:46:15PM +0100, Philipp Zabel wrote:
> There is no need to request a single reset by index.
> Use devm_reset_control_get_exclusive() to request the first and only
> reset.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/remoteproc/stm32_rproc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied.
Thanks,
Mathieu
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index a47e040c6db8..1443a4013d6c 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -696,8 +696,8 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
>
> ddata->rst = devm_reset_control_get_optional(dev, "mcu_rst");
> if (!ddata->rst) {
> - /* Try legacy fallback method: get it by index */
> - ddata->rst = devm_reset_control_get_by_index(dev, 0);
> + /* Try legacy fallback method: get the first reset */
> + ddata->rst = devm_reset_control_get_exclusive(dev, NULL);
> }
> if (IS_ERR(ddata->rst))
> return dev_err_probe(dev, PTR_ERR(ddata->rst),
>
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261106-reset-deindex-rproc-3c1aa2e9325f
>
> Best regards,
> --
> Philipp Zabel <p.zabel@pengutronix.de>
>
prev parent reply other threads:[~2026-11-09 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 15:46 Philipp Zabel
2026-11-09 15:32 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avHnnBUiH-kLOrCU@p14s \
--to=mathieu.poirier@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®