* [PATCH] remoteproc: stm32_rproc: Do not request reset by index
@ 2026-11-06 15:46 Philipp Zabel
2026-11-09 15:32 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2026-11-06 15:46 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Maxime Coquelin, Alexandre Torgue
Cc: linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel,
Philipp Zabel
There is no need to request a single reset by index.
Use devm_reset_control_get_exclusive() to request the first and only
reset.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/remoteproc/stm32_rproc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index a47e040c6db8..1443a4013d6c 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -696,8 +696,8 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
ddata->rst = devm_reset_control_get_optional(dev, "mcu_rst");
if (!ddata->rst) {
- /* Try legacy fallback method: get it by index */
- ddata->rst = devm_reset_control_get_by_index(dev, 0);
+ /* Try legacy fallback method: get the first reset */
+ ddata->rst = devm_reset_control_get_exclusive(dev, NULL);
}
if (IS_ERR(ddata->rst))
return dev_err_probe(dev, PTR_ERR(ddata->rst),
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261106-reset-deindex-rproc-3c1aa2e9325f
Best regards,
--
Philipp Zabel <p.zabel@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] remoteproc: stm32_rproc: Do not request reset by index
2026-11-06 15:46 [PATCH] remoteproc: stm32_rproc: Do not request reset by index Philipp Zabel
@ 2026-11-09 15:32 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2026-11-09 15:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Bjorn Andersson, Maxime Coquelin, Alexandre Torgue,
linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel
On Fri, Nov 06, 2026 at 04:46:15PM +0100, Philipp Zabel wrote:
> There is no need to request a single reset by index.
> Use devm_reset_control_get_exclusive() to request the first and only
> reset.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/remoteproc/stm32_rproc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied.
Thanks,
Mathieu
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index a47e040c6db8..1443a4013d6c 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -696,8 +696,8 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
>
> ddata->rst = devm_reset_control_get_optional(dev, "mcu_rst");
> if (!ddata->rst) {
> - /* Try legacy fallback method: get it by index */
> - ddata->rst = devm_reset_control_get_by_index(dev, 0);
> + /* Try legacy fallback method: get the first reset */
> + ddata->rst = devm_reset_control_get_exclusive(dev, NULL);
> }
> if (IS_ERR(ddata->rst))
> return dev_err_probe(dev, PTR_ERR(ddata->rst),
>
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261106-reset-deindex-rproc-3c1aa2e9325f
>
> Best regards,
> --
> Philipp Zabel <p.zabel@pengutronix.de>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-09 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-06 15:46 [PATCH] remoteproc: stm32_rproc: Do not request reset by index Philipp Zabel
2026-11-09 15:32 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®