From: Johan Hovold <johan@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Danilo Krummrich <dakr@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org,
Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Subject: Re: [PATCH] software node: only let the owner release a managed node
Date: Mon, 9 Nov 2026 17:20:38 +0100 [thread overview]
Message-ID: <avHy1rt0Qb_IgpSs@hovoldconsulting.com> (raw)
In-Reply-To: <lhljpce4lyhuggmfyaq4c4g2mxqe5z3gwmqyrnxptlub3bahff@vdyh47ms5ua3>
On Mon, Nov 09, 2026 at 05:08:50PM +0100, Bartosz Golaszewski wrote:
> On Mon, Nov 09, 2026 at 04:55:34PM +0100, Johan Hovold wrote:
> > I've updated the commit with the missing Reviewed-by and Fixes tag. I
> > also decided to drop the reordering of releasing the swnode references
> > as that is arguable an unrelated change and the current code expects
> > users to hold a reference unless it's a managed node.
> >
>
> Ok, I won't be sending a v2 then.
>
> I'm not sure what the workflow is exactly among the driver core maintainers
> but the commit that ended up in tree looks quite different from what
> I submitted and what Link: references.
Right, and the three changes are recorded in the commit trailers (and
the rationale is documented in the Link thread).
> Such in-tree modifications from maintainers have caused problems in the
> past[1]. I would have preferred to apply changes myself based on reviews
> and send a v2 which could then be queued as it appears on the list. Just
> my 2 cents.
Since I've already done the work, and have the context fresh in mind,
another round-trip would just mean even more work.
If you think it differs too much or you don't agree with the end-result,
I can update the authorship.
Johan
prev parent reply other threads:[~2026-11-09 16:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 15:25 Bartosz Golaszewski
2026-11-04 6:47 ` Vivekanandan, Balasubramani
2026-11-04 8:19 ` Andy Shevchenko
2026-11-04 8:26 ` Vivekanandan, Balasubramani
2026-11-04 8:35 ` Andy Shevchenko
2026-11-04 8:40 ` Vivekanandan, Balasubramani
2026-11-06 17:47 ` Heikki Krogerus
2026-11-09 13:37 ` Johan Hovold
2026-11-09 14:10 ` Danilo Krummrich
2026-11-09 14:30 ` Bartosz Golaszewski
2026-11-09 14:34 ` Johan Hovold
2026-11-09 14:45 ` Danilo Krummrich
2026-11-09 14:59 ` Johan Hovold
2026-11-09 15:17 ` Danilo Krummrich
2026-11-09 15:55 ` Johan Hovold
2026-11-09 16:08 ` Bartosz Golaszewski
2026-11-09 16:20 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avHy1rt0Qb_IgpSs@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balasubramani.vivekanandan@intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®