mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Kryštof Černý" <cleverline1mc@gmail.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-serial <linux-serial@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	"Miroslav Ondra" <ondra@faster.cz>
Subject: Re: [PATCH 1/2] serial: 8250: Add RX trigger levels for U6_16550A
Date: Mon, 9 Nov 2026 23:34:12 +0200	[thread overview]
Message-ID: <avI8VFpnwlK7eadS@ashevche-desk.local> (raw)
In-Reply-To: <800f8d42-e35d-47ec-bbe6-e437a86d6e70@gmail.com>

On Mon, Nov 09, 2026 at 04:37:43PM +0100, Kryštof Černý wrote:
> > On Mon, 9 Nov 2026, Kryštof Černý via B4 Relay wrote:

...

> > Reusing U6 entry for DW UARTs seems misleading.
> > 
> > We've better mechanism coming up for defining rxtrig in a one pending
> > series so this constant friction with the uart config types can be put
> > into rest.
> > 
> > Please build on top of that other series and help in testing and reviewing
> > it.
> 
> Thanks for the information, I started the work about a month ago
> and not sure if the patch existed before. I will test the other series on my
> hardware. I like that approach more.

+1 to what Ilpo said. Please, make a joint effort with that patch series (test,
review, et cetera) to get it better.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-09 21:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 14:40 [PATCH 0/2] serial: 8250_dw: Fix RX trigger levels for 64-byte FIFOs Kryštof Černý via B4 Relay
2026-11-09 14:40 ` [PATCH 1/2] serial: 8250: Add RX trigger levels for U6_16550A Kryštof Černý via B4 Relay
2026-11-09 14:55   ` Ilpo Järvinen
2026-11-09 15:37     ` Kryštof Černý
2026-11-09 21:34       ` Andy Shevchenko [this message]
2026-11-09 14:41 ` [PATCH 2/2] serial: 8250_dw: Select U6_16550A for 64-byte FIFO Kryštof Černý via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avI8VFpnwlK7eadS@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=cleverline1mc@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=ondra@faster.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®