From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v8 01/11] serial: 8250_dw: allow port setup to report errors
Date: Tue, 10 Nov 2026 01:05:22 +0200 [thread overview]
Message-ID: <avJRsij5P7Ch3tqE@ashevche-desk.local> (raw)
In-Reply-To: <20261105-submit-h616-uart-fifo-v1-v8-1-14024d2b184b@gmail.com>
On Thu, Nov 05, 2026 at 01:52:02PM -0700, James Hilliard wrote:
> Return a status from dw8250_setup_port() and propagate failures through
> the DW and LPSS probe paths before registering the UART. Use the existing
> LPSS cleanup path to release board resources and IRQ vectors on failure.
>
> Keep the current setup behavior by returning zero on both successful
> paths. This separates error propagation from the configuration validation
> that will use it.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
after addressing below piece.
...
> - if (!data->skip_autocfg)
> - dw8250_setup_port(p);
> + if (!data->skip_autocfg) {
> + err = dw8250_setup_port(p);
> + if (err)
> + return err;
> + }
No, don't change it here, the return value will be simply ignored until the
change that will make use of it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-11-09 23:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 20:52 [PATCH v8 00/11] serial: 8250_dw: share RX trigger setup and describe Allwinner UARTs James Hilliard
2026-11-05 20:52 ` [PATCH v8 01/11] serial: 8250_dw: allow port setup to report errors James Hilliard
2026-11-09 23:05 ` Andy Shevchenko [this message]
2026-11-09 23:06 ` Andy Shevchenko
2026-11-05 20:52 ` [PATCH v8 02/11] serial: 8250_dw: select port setup through platform data James Hilliard
2026-11-05 20:52 ` [PATCH v8 03/11] serial: 8250: widen RX trigger byte counts to 16 bits James Hilliard
2026-11-05 20:52 ` [PATCH v8 04/11] serial: 8250: share the RX trigger conversion helper James Hilliard
2026-11-05 20:52 ` [PATCH v8 05/11] serial: 8250: expose RX trigger controls for custom callbacks James Hilliard
2026-11-05 20:52 ` [PATCH v8 06/11] serial: 8250_dw: derive RX trigger thresholds from the FIFO depth James Hilliard
2026-11-09 23:10 ` Andy Shevchenko
2026-11-05 20:52 ` [PATCH v8 07/11] dt-bindings: serial: snps-dw-apb-uart: add Allwinner H616 James Hilliard
2026-11-05 20:52 ` [PATCH v8 08/11] serial: 8250_dw: configure the Allwinner H616 UART James Hilliard
2026-11-05 20:52 ` [PATCH v8 09/11] dt-bindings: serial: snps-dw-apb-uart: add Allwinner A523 James Hilliard
2026-11-05 20:52 ` [PATCH v8 10/11] serial: 8250_dw: discover Allwinner A523 FIFO depths through FCC James Hilliard
2026-11-05 20:52 ` [PATCH v8 11/11] serial: 8250_dw: configure RX trigger thresholds for Octeon James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avJRsij5P7Ch3tqE@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=james.hilliard1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®