From: Dan Carpenter <dan@cryspen.com>
To: Platon Miller <platon.ksenzenkokk@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: remove unused macros in sm750_cursor.c
Date: Tue, 10 Nov 2026 08:00:27 +0300 [thread overview]
Message-ID: <avKk63Z5_ofZZcGk@stanley.mountain> (raw)
In-Reply-To: <20261109231414.25021-1-platon.ksenzenkokk@gmail.com>
On Tue, Nov 10, 2026 at 12:14:14AM +0100, Platon Miller wrote:
> The macros HWC_ADDRESS_EXT, HWC_ADDRESS_CS, HWC_LOCATION_TOP, and
> HWC_LOCATION_LEFT are defined in sm750_cursor.c but are never used
> anywhere in the driver. Remove them to clean up unused code as
> specified in drivers/staging/sm750fb/TODO.
>
> Signed-off-by: Platon Miller <platon.ksenzenkokk@gmail.com>
> ---
Leave this sort of macro. It documents the hardware and doesn't
hurt readability at all.
regards,
dan carpenter
prev parent reply other threads:[~2026-11-10 5:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 23:14 Platon Miller
2026-11-10 5:00 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avKk63Z5_ofZZcGk@stanley.mountain \
--to=dan@cryspen.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=platon.ksenzenkokk@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®