* [PATCH] staging: sm750fb: remove unused macros in sm750_cursor.c
@ 2026-11-09 23:14 Platon Miller
2026-11-10 5:00 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Platon Miller @ 2026-11-09 23:14 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: linux-fbdev, linux-staging, linux-kernel, Platon Miller
The macros HWC_ADDRESS_EXT, HWC_ADDRESS_CS, HWC_LOCATION_TOP, and
HWC_LOCATION_LEFT are defined in sm750_cursor.c but are never used
anywhere in the driver. Remove them to clean up unused code as
specified in drivers/staging/sm750fb/TODO.
Signed-off-by: Platon Miller <platon.ksenzenkokk@gmail.com>
---
drivers/staging/sm750fb/sm750_cursor.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index f822d147e..571cf86fd 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -10,15 +10,11 @@ writel((data), cursor->mmio + (addr))
/* cursor control for voyager and 718/750*/
#define HWC_ADDRESS 0x0
#define HWC_ADDRESS_ENABLE BIT(31)
-#define HWC_ADDRESS_EXT BIT(27)
-#define HWC_ADDRESS_CS BIT(26)
#define HWC_ADDRESS_ADDRESS_MASK 0x3ffffff
#define HWC_LOCATION 0x4
-#define HWC_LOCATION_TOP BIT(27)
#define HWC_LOCATION_Y_SHIFT 16
#define HWC_LOCATION_Y_MASK (0x7ff << 16)
-#define HWC_LOCATION_LEFT BIT(11)
#define HWC_LOCATION_X_MASK 0x7ff
#define HWC_COLOR_12 0x8
--
2.56.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sm750fb: remove unused macros in sm750_cursor.c
2026-11-09 23:14 [PATCH] staging: sm750fb: remove unused macros in sm750_cursor.c Platon Miller
@ 2026-11-10 5:00 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-11-10 5:00 UTC (permalink / raw)
To: Platon Miller
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel
On Tue, Nov 10, 2026 at 12:14:14AM +0100, Platon Miller wrote:
> The macros HWC_ADDRESS_EXT, HWC_ADDRESS_CS, HWC_LOCATION_TOP, and
> HWC_LOCATION_LEFT are defined in sm750_cursor.c but are never used
> anywhere in the driver. Remove them to clean up unused code as
> specified in drivers/staging/sm750fb/TODO.
>
> Signed-off-by: Platon Miller <platon.ksenzenkokk@gmail.com>
> ---
Leave this sort of macro. It documents the hardware and doesn't
hurt readability at all.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-10 5:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-09 23:14 [PATCH] staging: sm750fb: remove unused macros in sm750_cursor.c Platon Miller
2026-11-10 5:00 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®