Re: [PATCH 1/1] Input: trackpoint - Add new ELAN trackpoint device variant id 7

[Yao Yuan <yaoyuan0329os@gmail.com>]

On Tue, Nov 10, 2026 at 05:26:21AM +0000, Jingle Wu 吳金國 wrote:

Hi Wu,

> Hi Dmitry/Yuan:
>
> We have confirmed that FW A1 was never released by Elan. The Elan Variant ID has always been 3.

Thanks for your information, Let me share more details:

The trackpoint has driver from "ELAN
Microelectronics Corp." in windows 11 on same device.

In Linux I found the device is probed as generic mouse
device but not trackpoint device, it's hard to use due to
no sensitivity setting from sysfs. I found the reported id
0x7 is not in drivers/input/mouse/trackpoint.c's
trackpoint_start_protocol() after debugging, the trackpoint
is probed and works well after add the id 0x7 there.

So I thought this should be a ELAN device w/ ID 0x7 and
cooked this patch.


>
> THANKS
> JINGLE
>
> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Sent: Tuesday, November 10, 2026 10:36 AM
> To: Yuan Yao <yaoyuan0329os@gmail.com>; Jingle Wu 吳金國 <jingle.wu@emc.com.tw>
> Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>; Vishnu Sankar <vishnuocv@gmail.com>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Phoenix Huang 黃世鵬 <phoenix@emc.com.tw>; Stanley Chen 陳建維 <stanley.chen@emc.com.tw>
> Subject: Re: [PATCH 1/1] Input: trackpoint - Add new ELAN trackpoint device variant id 7
>
> ⚠ External Email: This email originated from outside the organization. Please use caution when opening links or attachments.
> ⚠ 外部郵件： 此郵件來自公司外部，請謹慎開啟連結或附件。
>
> Hi Yuan,
>
> On Mon, Nov 02, 2026 at 09:08:36PM +0800, Yuan Yao wrote:
> > The new ELAN trackpoint variant id 7 is found on thinkpad
> > X14 Gen1 laptop(Product Name: 21XMA006CD), it's now incorrectly probed
> > as Generic or Logitech PS/2 mouse.
> >
> > Add ELAN variant id 7 to match the TP_READ_ID command return value,
> > probe the device as trackpoint correctly.
> >
> > BEFORE:
> > input: PS/2 Generic Mouse as
> > /devices/platform/i8042/serio1/input/input63
> >
> > AFTER:
> > psmouse serio1: trackpoint: Elan_variant7 TrackPoint firmware: 0xa1,
> > buttons: 3/3
> > input: TPPS/2 Elan_variant7 TrackPoint as
> > /devices/platform/i8042/serio1/input/input65
> >
> > Signed-off-by: Yuan Yao <yaoyuan0329os@gmail.com>
> > ---
> >  drivers/input/mouse/trackpoint.c | 2 ++
> > drivers/input/mouse/trackpoint.h | 1 +
> >  2 files changed, 3 insertions(+)
> >
> > diff --git a/drivers/input/mouse/trackpoint.c
> > b/drivers/input/mouse/trackpoint.c
> > index 3bd8fdf56cd3..f46fc1665c96 100644
> > --- a/drivers/input/mouse/trackpoint.c
> > +++ b/drivers/input/mouse/trackpoint.c
> > @@ -25,6 +25,7 @@ static const char * const trackpoint_variants[] = {
> >       [TP_VARIANT_NXP]                = "NXP",
> >       [TP_VARIANT_JYT_SYNAPTICS]      = "JYT_Synaptics",
> >       [TP_VARIANT_SYNAPTICS]          = "Synaptics",
> > +     [TP_VARIANT_ELAN_ID_7]          = "Elan_variant7"
>
> I wonder if we really need to say "Elan_variant7" or if we should simply say "Elan" here as well.
>
> Jingle, is this your part? What is the difference from Elan trackpoint reporting 0x03 as its variant?
>
> Thanks.
>
> --
> Dmitry