* [PATCH 0/1] Input/trackpoint: Add new ELAN trackpoint device variant id 7 @ 2026-11-02 13:08 Yuan Yao 2026-11-02 13:08 ` [PATCH 1/1] Input: trackpoint - " Yuan Yao 0 siblings, 1 reply; 6+ messages in thread From: Yuan Yao @ 2026-11-02 13:08 UTC (permalink / raw) To: Ilpo Järvinen, Dmitry Torokhov, Vishnu Sankar Cc: linux-input, linux-kernel, Yuan Yao The new ELAN trackpoint variant id 7 is found on thinkpad X14 Gen1 laptop(Product Name: 21XMA006CD), it's now incorrectly probed as Generic or Logitech PS/2 mouse but not trackpoint. Add ELAN variant id 7 to match the TP_READ_ID command return value, probe the device as trackpoint correctly. I tested the sensitivity/middle button lock/rate/resolution setting, the trackpoint works well in daily usage and when resume form system sleeping, no issue is found in my last weeks usage. BEFORE: input: PS/2 Generic Mouse as /devices/platform/i8042/serio1/input/input63 AFTER: psmouse serio1: trackpoint: Elan_variant7 TrackPoint firmware: 0xa1, buttons: 3/3 input: TPPS/2 Elan_variant7 TrackPoint as /devices/platform/i8042/serio1/input/input65 The patch is rebased to 7.4-rc1. Yuan Yao (1): Input: trackpoint - Add new ELAN trackpoint device variant id 7 drivers/input/mouse/trackpoint.c | 2 ++ drivers/input/mouse/trackpoint.h | 1 + 2 files changed, 3 insertions(+) base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4 -- 2.56.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] Input: trackpoint - Add new ELAN trackpoint device variant id 7 2026-11-02 13:08 [PATCH 0/1] Input/trackpoint: Add new ELAN trackpoint device variant id 7 Yuan Yao @ 2026-11-02 13:08 ` Yuan Yao 2026-11-10 2:36 ` Dmitry Torokhov 0 siblings, 1 reply; 6+ messages in thread From: Yuan Yao @ 2026-11-02 13:08 UTC (permalink / raw) To: Ilpo Järvinen, Dmitry Torokhov, Vishnu Sankar Cc: linux-input, linux-kernel, Yuan Yao The new ELAN trackpoint variant id 7 is found on thinkpad X14 Gen1 laptop(Product Name: 21XMA006CD), it's now incorrectly probed as Generic or Logitech PS/2 mouse. Add ELAN variant id 7 to match the TP_READ_ID command return value, probe the device as trackpoint correctly. BEFORE: input: PS/2 Generic Mouse as /devices/platform/i8042/serio1/input/input63 AFTER: psmouse serio1: trackpoint: Elan_variant7 TrackPoint firmware: 0xa1, buttons: 3/3 input: TPPS/2 Elan_variant7 TrackPoint as /devices/platform/i8042/serio1/input/input65 Signed-off-by: Yuan Yao <yaoyuan0329os@gmail.com> --- drivers/input/mouse/trackpoint.c | 2 ++ drivers/input/mouse/trackpoint.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c index 3bd8fdf56cd3..f46fc1665c96 100644 --- a/drivers/input/mouse/trackpoint.c +++ b/drivers/input/mouse/trackpoint.c @@ -25,6 +25,7 @@ static const char * const trackpoint_variants[] = { [TP_VARIANT_NXP] = "NXP", [TP_VARIANT_JYT_SYNAPTICS] = "JYT_Synaptics", [TP_VARIANT_SYNAPTICS] = "Synaptics", + [TP_VARIANT_ELAN_ID_7] = "Elan_variant7" }; /* @@ -283,6 +284,7 @@ static int trackpoint_start_protocol(struct psmouse *psmouse, case TP_VARIANT_IBM: case TP_VARIANT_ALPS: case TP_VARIANT_ELAN: + case TP_VARIANT_ELAN_ID_7: case TP_VARIANT_NXP: case TP_VARIANT_JYT_SYNAPTICS: case TP_VARIANT_SYNAPTICS: diff --git a/drivers/input/mouse/trackpoint.h b/drivers/input/mouse/trackpoint.h index 3e03cdb39449..b67fc228cf3e 100644 --- a/drivers/input/mouse/trackpoint.h +++ b/drivers/input/mouse/trackpoint.h @@ -30,6 +30,7 @@ #define TP_VARIANT_NXP 0x04 #define TP_VARIANT_JYT_SYNAPTICS 0x05 #define TP_VARIANT_SYNAPTICS 0x06 +#define TP_VARIANT_ELAN_ID_7 0x07 /* * Commands -- 2.56.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Input: trackpoint - Add new ELAN trackpoint device variant id 7 2026-11-02 13:08 ` [PATCH 1/1] Input: trackpoint - " Yuan Yao @ 2026-11-10 2:36 ` Dmitry Torokhov 2026-11-10 5:26 ` Jingle Wu 吳金國 2026-11-10 13:22 ` Yao Yuan 0 siblings, 2 replies; 6+ messages in thread From: Dmitry Torokhov @ 2026-11-10 2:36 UTC (permalink / raw) To: Yuan Yao, Jingle Wu Cc: Ilpo Järvinen, Vishnu Sankar, linux-input, linux-kernel, Phoenix Huang 黃世鵬, Stanley Chen 陳建維 Hi Yuan, On Mon, Nov 02, 2026 at 09:08:36PM +0800, Yuan Yao wrote: > The new ELAN trackpoint variant id 7 is found on thinkpad > X14 Gen1 laptop(Product Name: 21XMA006CD), it's now > incorrectly probed as Generic or Logitech PS/2 mouse. > > Add ELAN variant id 7 to match the TP_READ_ID command > return value, probe the device as trackpoint correctly. > > BEFORE: > input: PS/2 Generic Mouse as /devices/platform/i8042/serio1/input/input63 > > AFTER: > psmouse serio1: trackpoint: Elan_variant7 TrackPoint firmware: 0xa1, buttons: 3/3 > input: TPPS/2 Elan_variant7 TrackPoint as /devices/platform/i8042/serio1/input/input65 > > Signed-off-by: Yuan Yao <yaoyuan0329os@gmail.com> > --- > drivers/input/mouse/trackpoint.c | 2 ++ > drivers/input/mouse/trackpoint.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c > index 3bd8fdf56cd3..f46fc1665c96 100644 > --- a/drivers/input/mouse/trackpoint.c > +++ b/drivers/input/mouse/trackpoint.c > @@ -25,6 +25,7 @@ static const char * const trackpoint_variants[] = { > [TP_VARIANT_NXP] = "NXP", > [TP_VARIANT_JYT_SYNAPTICS] = "JYT_Synaptics", > [TP_VARIANT_SYNAPTICS] = "Synaptics", > + [TP_VARIANT_ELAN_ID_7] = "Elan_variant7" I wonder if we really need to say "Elan_variant7" or if we should simply say "Elan" here as well. Jingle, is this your part? What is the difference from Elan trackpoint reporting 0x03 as its variant? Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/1] Input: trackpoint - Add new ELAN trackpoint device variant id 7 2026-11-10 2:36 ` Dmitry Torokhov @ 2026-11-10 5:26 ` Jingle Wu 吳金國 2026-11-10 13:48 ` Yao Yuan 2026-11-10 13:22 ` Yao Yuan 1 sibling, 1 reply; 6+ messages in thread From: Jingle Wu 吳金國 @ 2026-11-10 5:26 UTC (permalink / raw) To: Dmitry Torokhov, Yuan Yao Cc: Ilpo Järvinen, Vishnu Sankar, linux-input, linux-kernel, Phoenix Huang 黃世鵬, Stanley Chen 陳建維 Hi Dmitry/Yuan: We have confirmed that FW A1 was never released by Elan. The Elan Variant ID has always been 3. THANKS JINGLE -----Original Message----- From: Dmitry Torokhov <dmitry.torokhov@gmail.com> Sent: Tuesday, November 10, 2026 10:36 AM To: Yuan Yao <yaoyuan0329os@gmail.com>; Jingle Wu 吳金國 <jingle.wu@emc.com.tw> Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>; Vishnu Sankar <vishnuocv@gmail.com>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Phoenix Huang 黃世鵬 <phoenix@emc.com.tw>; Stanley Chen 陳建維 <stanley.chen@emc.com.tw> Subject: Re: [PATCH 1/1] Input: trackpoint - Add new ELAN trackpoint device variant id 7 ⚠ External Email: This email originated from outside the organization. Please use caution when opening links or attachments. ⚠ 外部郵件： 此郵件來自公司外部，請謹慎開啟連結或附件。 Hi Yuan, On Mon, Nov 02, 2026 at 09:08:36PM +0800, Yuan Yao wrote: > The new ELAN trackpoint variant id 7 is found on thinkpad > X14 Gen1 laptop(Product Name: 21XMA006CD), it's now incorrectly probed > as Generic or Logitech PS/2 mouse. > > Add ELAN variant id 7 to match the TP_READ_ID command return value, > probe the device as trackpoint correctly. > > BEFORE: > input: PS/2 Generic Mouse as > /devices/platform/i8042/serio1/input/input63 > > AFTER: > psmouse serio1: trackpoint: Elan_variant7 TrackPoint firmware: 0xa1, > buttons: 3/3 > input: TPPS/2 Elan_variant7 TrackPoint as > /devices/platform/i8042/serio1/input/input65 > > Signed-off-by: Yuan Yao <yaoyuan0329os@gmail.com> > --- > drivers/input/mouse/trackpoint.c | 2 ++ > drivers/input/mouse/trackpoint.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/input/mouse/trackpoint.c > b/drivers/input/mouse/trackpoint.c > index 3bd8fdf56cd3..f46fc1665c96 100644 > --- a/drivers/input/mouse/trackpoint.c > +++ b/drivers/input/mouse/trackpoint.c > @@ -25,6 +25,7 @@ static const char * const trackpoint_variants[] = { > [TP_VARIANT_NXP] = "NXP", > [TP_VARIANT_JYT_SYNAPTICS] = "JYT_Synaptics", > [TP_VARIANT_SYNAPTICS] = "Synaptics", > + [TP_VARIANT_ELAN_ID_7] = "Elan_variant7" I wonder if we really need to say "Elan_variant7" or if we should simply say "Elan" here as well. Jingle, is this your part? What is the difference from Elan trackpoint reporting 0x03 as its variant? Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Input: trackpoint - Add new ELAN trackpoint device variant id 7 2026-11-10 5:26 ` Jingle Wu 吳金國 @ 2026-11-10 13:48 ` Yao Yuan 0 siblings, 0 replies; 6+ messages in thread From: Yao Yuan @ 2026-11-10 13:48 UTC (permalink / raw) To: Jingle Wu 吳金國 Cc: Dmitry Torokhov, Ilpo Järvinen, Vishnu Sankar, linux-input, linux-kernel, Phoenix Huang 黃世鵬, Stanley Chen 陳建維 On Tue, Nov 10, 2026 at 05:26:21AM +0000, Jingle Wu 吳金國 wrote: Hi Wu, > Hi Dmitry/Yuan: > > We have confirmed that FW A1 was never released by Elan. The Elan Variant ID has always been 3. Thanks for your information, Let me share more details: The trackpoint has driver from "ELAN Microelectronics Corp." in windows 11 on same device. In Linux I found the device is probed as generic mouse device but not trackpoint device, it's hard to use due to no sensitivity setting from sysfs. I found the reported id 0x7 is not in drivers/input/mouse/trackpoint.c's trackpoint_start_protocol() after debugging, the trackpoint is probed and works well after add the id 0x7 there. So I thought this should be a ELAN device w/ ID 0x7 and cooked this patch. > > THANKS > JINGLE > > -----Original Message----- > From: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Sent: Tuesday, November 10, 2026 10:36 AM > To: Yuan Yao <yaoyuan0329os@gmail.com>; Jingle Wu 吳金國 <jingle.wu@emc.com.tw> > Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>; Vishnu Sankar <vishnuocv@gmail.com>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Phoenix Huang 黃世鵬 <phoenix@emc.com.tw>; Stanley Chen 陳建維 <stanley.chen@emc.com.tw> > Subject: Re: [PATCH 1/1] Input: trackpoint - Add new ELAN trackpoint device variant id 7 > > ⚠ External Email: This email originated from outside the organization. Please use caution when opening links or attachments. > ⚠ 外部郵件： 此郵件來自公司外部，請謹慎開啟連結或附件。 > > Hi Yuan, > > On Mon, Nov 02, 2026 at 09:08:36PM +0800, Yuan Yao wrote: > > The new ELAN trackpoint variant id 7 is found on thinkpad > > X14 Gen1 laptop(Product Name: 21XMA006CD), it's now incorrectly probed > > as Generic or Logitech PS/2 mouse. > > > > Add ELAN variant id 7 to match the TP_READ_ID command return value, > > probe the device as trackpoint correctly. > > > > BEFORE: > > input: PS/2 Generic Mouse as > > /devices/platform/i8042/serio1/input/input63 > > > > AFTER: > > psmouse serio1: trackpoint: Elan_variant7 TrackPoint firmware: 0xa1, > > buttons: 3/3 > > input: TPPS/2 Elan_variant7 TrackPoint as > > /devices/platform/i8042/serio1/input/input65 > > > > Signed-off-by: Yuan Yao <yaoyuan0329os@gmail.com> > > --- > > drivers/input/mouse/trackpoint.c | 2 ++ > > drivers/input/mouse/trackpoint.h | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/drivers/input/mouse/trackpoint.c > > b/drivers/input/mouse/trackpoint.c > > index 3bd8fdf56cd3..f46fc1665c96 100644 > > --- a/drivers/input/mouse/trackpoint.c > > +++ b/drivers/input/mouse/trackpoint.c > > @@ -25,6 +25,7 @@ static const char * const trackpoint_variants[] = { > > [TP_VARIANT_NXP] = "NXP", > > [TP_VARIANT_JYT_SYNAPTICS] = "JYT_Synaptics", > > [TP_VARIANT_SYNAPTICS] = "Synaptics", > > + [TP_VARIANT_ELAN_ID_7] = "Elan_variant7" > > I wonder if we really need to say "Elan_variant7" or if we should simply say "Elan" here as well. > > Jingle, is this your part? What is the difference from Elan trackpoint reporting 0x03 as its variant? > > Thanks. > > -- > Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Input: trackpoint - Add new ELAN trackpoint device variant id 7 2026-11-10 2:36 ` Dmitry Torokhov 2026-11-10 5:26 ` Jingle Wu 吳金國 @ 2026-11-10 13:22 ` Yao Yuan 1 sibling, 0 replies; 6+ messages in thread From: Yao Yuan @ 2026-11-10 13:22 UTC (permalink / raw) To: Dmitry Torokhov Cc: Jingle Wu, Ilpo Järvinen, Vishnu Sankar, linux-input, linux-kernel, Phoenix Huang 黃世鵬, Stanley Chen 陳建維 On Mon, Nov 09, 2026 at 06:36:15PM -0800, Dmitry Torokhov wrote: > Hi Yuan, > > On Mon, Nov 02, 2026 at 09:08:36PM +0800, Yuan Yao wrote: > > The new ELAN trackpoint variant id 7 is found on thinkpad > > X14 Gen1 laptop(Product Name: 21XMA006CD), it's now > > incorrectly probed as Generic or Logitech PS/2 mouse. > > > > Add ELAN variant id 7 to match the TP_READ_ID command > > return value, probe the device as trackpoint correctly. > > > > BEFORE: > > input: PS/2 Generic Mouse as /devices/platform/i8042/serio1/input/input63 > > > > AFTER: > > psmouse serio1: trackpoint: Elan_variant7 TrackPoint firmware: 0xa1, buttons: 3/3 > > input: TPPS/2 Elan_variant7 TrackPoint as /devices/platform/i8042/serio1/input/input65 > > > > Signed-off-by: Yuan Yao <yaoyuan0329os@gmail.com> > > --- > > drivers/input/mouse/trackpoint.c | 2 ++ > > drivers/input/mouse/trackpoint.h | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c > > index 3bd8fdf56cd3..f46fc1665c96 100644 > > --- a/drivers/input/mouse/trackpoint.c > > +++ b/drivers/input/mouse/trackpoint.c > > @@ -25,6 +25,7 @@ static const char * const trackpoint_variants[] = { > > [TP_VARIANT_NXP] = "NXP", > > [TP_VARIANT_JYT_SYNAPTICS] = "JYT_Synaptics", > > [TP_VARIANT_SYNAPTICS] = "Synaptics", > > + [TP_VARIANT_ELAN_ID_7] = "Elan_variant7" > Hi Dmitry, > I wonder if we really need to say "Elan_variant7" or if we should simply > say "Elan" here as well. Thanks for your reply. I'm fine to just "Elan" if it's ok to you. I just want to highlight the device has id 7 from other ELAN devices which has 3, so I give it "Elan_variant7". > > Jingle, is this your part? What is the difference from Elan trackpoint > reporting 0x03 as its variant? > > Thanks. > > -- > Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-10 13:48 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-11-02 13:08 [PATCH 0/1] Input/trackpoint: Add new ELAN trackpoint device variant id 7 Yuan Yao 2026-11-02 13:08 ` [PATCH 1/1] Input: trackpoint - " Yuan Yao 2026-11-10 2:36 ` Dmitry Torokhov 2026-11-10 5:26 ` Jingle Wu 吳金國 2026-11-10 13:48 ` Yao Yuan 2026-11-10 13:22 ` Yao Yuan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®