From: Harry Yoo <harry@kernel.org>
To: Hao Li <hao.li@linux.dev>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Vlastimil Babka <vbabka@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-mm@kvack.org, loongarch@lists.linux.dev,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/slub: Genericize x86-specific cmpxchg16b comment
Date: Tue, 10 Nov 2026 14:33:33 +0100 [thread overview]
Message-ID: <avMcw2Poqn2uk5cl@thinkstation> (raw)
In-Reply-To: <avK8RqLl69zIkVY2@fedora>
On Tue, Nov 10, 2026 at 03:05:14PM +0800, Hao Li wrote:
> On Tue, Nov 10, 2026 at 09:29:04AM +0800, Tiezhu Yang wrote:
> > On 11/10/26 2:25 AM, Alexei Starovoitov wrote:
> > > On Sun, Nov 08, 2026 at 07:59 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> > > > atomic primitive is satisfied by different hardware implementations:
> > > > (1) arm64: satisfies it via LSE atomics ('casp' instruction)
> > > [...]
> > > > Update the comment to "double-width atomic cmpxchg", which provides the
> > > > following advantages:
> > > > (1) Accurately describes the cross-platform hardware invariant.
> > >
> > > You ignored Hao's point about shorter commit logs.
> >
> > If the following shorter commit message is preferred:
> >
> > mm/slub: Genericize x86-specific cmpxchg16b comment
> >
> > In __kmalloc_nolock_noprof(), update the comment from x86-specific
> > "cmpxchg16b" to generic "double-width atomic cmpxchg".
>
> Ok, LGTM.
Looks good to me too.
> > I will wait for a while for more feedback from mm maintainers and send
> > v3 if necessary.
Please send v3.
> > Thanks,
> > Tiezhu
--
Cheers,
Harry / Hyeonggon
prev parent reply other threads:[~2026-11-10 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 3:59 Tiezhu Yang
2026-11-09 18:25 ` Alexei Starovoitov
2026-11-10 1:29 ` Tiezhu Yang
2026-11-10 7:05 ` Hao Li
2026-11-10 13:33 ` Harry Yoo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avMcw2Poqn2uk5cl@thinkstation \
--to=harry@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cl@gentwo.org \
--cc=hao.li@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=loongarch@lists.linux.dev \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®