From: Harry Yoo <harry@kernel.org>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: Vlastimil Babka <vbabka@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>, Hao Li <hao.li@linux.dev>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Roman Gushchin <roman.gushchin@linux.dev>
Subject: Re: [PATCH] mm/slab: remove outdated comment in create_kmalloc_caches()
Date: Tue, 10 Nov 2026 14:37:32 +0100 [thread overview]
Message-ID: <avMdQuXxfqMCBbBA@thinkstation> (raw)
In-Reply-To: <20261104144753.2266231-1-ekffu200098@gmail.com>
On Wed, Nov 04, 2026 at 11:47:51PM +0900, Sang-Heon Jeon wrote:
> Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
> removed SLAB, no kmalloc cache is created before create_kmalloc_caches().
>
> So remove the outdated comment.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
> mm/slab_common.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index e66c0778ee98..c4a386f0dd90 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1029,9 +1029,7 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
> }
>
> /*
> - * Create the kmalloc array. Some of the regular kmalloc arrays
> - * may already have been created because they were needed to
> - * enable allocations for slab creation.
> + * Create the kmalloc array.
> */
LGTM, but maybe let's just drop the comment?
The name "create_kmalloc_caches" already covers
"Create the kmalloc array"
> void __init create_kmalloc_caches(void)
> {
>
> base-commit: d15d7703166daf7bd62c844a3cb1b3a6279adb4c
> --
> 2.43.0
>
--
Cheers,
Harry / Hyeonggon
next prev parent reply other threads:[~2026-11-10 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 14:47 Sang-Heon Jeon
2026-11-10 13:37 ` Harry Yoo [this message]
2026-11-10 13:41 ` Sang-Heon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avMdQuXxfqMCBbBA@thinkstation \
--to=harry@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=ekffu200098@gmail.com \
--cc=hao.li@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®