* [PATCH] mm/slab: remove outdated comment in create_kmalloc_caches()
@ 2026-11-04 14:47 Sang-Heon Jeon
2026-11-10 13:37 ` Harry Yoo
0 siblings, 1 reply; 3+ messages in thread
From: Sang-Heon Jeon @ 2026-11-04 14:47 UTC (permalink / raw)
To: Vlastimil Babka, Harry Yoo, Andrew Morton
Cc: Christoph Lameter, David Rientjes, Hao Li, linux-kernel,
linux-mm, Roman Gushchin
Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
removed SLAB, no kmalloc cache is created before create_kmalloc_caches().
So remove the outdated comment.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
mm/slab_common.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/slab_common.c b/mm/slab_common.c
index e66c0778ee98..c4a386f0dd90 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -1029,9 +1029,7 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
}
/*
- * Create the kmalloc array. Some of the regular kmalloc arrays
- * may already have been created because they were needed to
- * enable allocations for slab creation.
+ * Create the kmalloc array.
*/
void __init create_kmalloc_caches(void)
{
base-commit: d15d7703166daf7bd62c844a3cb1b3a6279adb4c
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/slab: remove outdated comment in create_kmalloc_caches()
2026-11-04 14:47 [PATCH] mm/slab: remove outdated comment in create_kmalloc_caches() Sang-Heon Jeon
@ 2026-11-10 13:37 ` Harry Yoo
2026-11-10 13:41 ` Sang-Heon Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Harry Yoo @ 2026-11-10 13:37 UTC (permalink / raw)
To: Sang-Heon Jeon
Cc: Vlastimil Babka, Andrew Morton, Christoph Lameter,
David Rientjes, Hao Li, linux-kernel, linux-mm, Roman Gushchin
On Wed, Nov 04, 2026 at 11:47:51PM +0900, Sang-Heon Jeon wrote:
> Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
> removed SLAB, no kmalloc cache is created before create_kmalloc_caches().
>
> So remove the outdated comment.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
> mm/slab_common.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index e66c0778ee98..c4a386f0dd90 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1029,9 +1029,7 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
> }
>
> /*
> - * Create the kmalloc array. Some of the regular kmalloc arrays
> - * may already have been created because they were needed to
> - * enable allocations for slab creation.
> + * Create the kmalloc array.
> */
LGTM, but maybe let's just drop the comment?
The name "create_kmalloc_caches" already covers
"Create the kmalloc array"
> void __init create_kmalloc_caches(void)
> {
>
> base-commit: d15d7703166daf7bd62c844a3cb1b3a6279adb4c
> --
> 2.43.0
>
--
Cheers,
Harry / Hyeonggon
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/slab: remove outdated comment in create_kmalloc_caches()
2026-11-10 13:37 ` Harry Yoo
@ 2026-11-10 13:41 ` Sang-Heon Jeon
0 siblings, 0 replies; 3+ messages in thread
From: Sang-Heon Jeon @ 2026-11-10 13:41 UTC (permalink / raw)
To: Harry Yoo
Cc: Vlastimil Babka, Andrew Morton, Christoph Lameter,
David Rientjes, Hao Li, linux-kernel, linux-mm, Roman Gushchin
2026년 11월 10일 (화) 오후 10:37, Harry Yoo <harry@kernel.org>님이 작성:
>
> On Wed, Nov 04, 2026 at 11:47:51PM +0900, Sang-Heon Jeon wrote:
> > Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
> > removed SLAB, no kmalloc cache is created before create_kmalloc_caches().
> >
> > So remove the outdated comment.
> >
> > Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> > ---
> > mm/slab_common.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/mm/slab_common.c b/mm/slab_common.c
> > index e66c0778ee98..c4a386f0dd90 100644
> > --- a/mm/slab_common.c
> > +++ b/mm/slab_common.c
> > @@ -1029,9 +1029,7 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
> > }
> >
> > /*
> > - * Create the kmalloc array. Some of the regular kmalloc arrays
> > - * may already have been created because they were needed to
> > - * enable allocations for slab creation.
> > + * Create the kmalloc array.
> > */
>
> LGTM, but maybe let's just drop the comment?
> The name "create_kmalloc_caches" already covers
> "Create the kmalloc array"
I don't have a strong opinion. I'll address it in v2.
> > void __init create_kmalloc_caches(void)
> > {
> >
> > base-commit: d15d7703166daf7bd62c844a3cb1b3a6279adb4c
> > --
> > 2.43.0
> >
>
> --
> Cheers,
> Harry / Hyeonggon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-10 13:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-04 14:47 [PATCH] mm/slab: remove outdated comment in create_kmalloc_caches() Sang-Heon Jeon
2026-11-10 13:37 ` Harry Yoo
2026-11-10 13:41 ` Sang-Heon Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®